All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] allocate pci id for mdpy
Date: Thu, 26 Apr 2018 18:10:48 +0300	[thread overview]
Message-ID: <20180426180955-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180424063857.29246-1-kraxel@redhat.com>

On Tue, Apr 24, 2018 at 08:38:57AM +0200, Gerd Hoffmann wrote:
> mdpy is a sample pci device for vfio-mdev.  Not (yet) merged upstream,
> patch available here:
> 
> https://www.kraxel.org/cgit/linux/commit/?h=vfio-sample-display&id=6fd86cff3d7df38ab89625b16fdd6434b1c18749
> 
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

I presume this should be merged together with the
device implementation in qemu, or do you want this
in tree sooner?

> ---
>  docs/specs/pci-ids.txt | 1 +
>  include/hw/pci/pci.h   | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt
> index bb99a0257e..4d53e5c7d9 100644
> --- a/docs/specs/pci-ids.txt
> +++ b/docs/specs/pci-ids.txt
> @@ -62,6 +62,7 @@ PCI devices (other than virtio):
>  1b36:000a  PCI-PCI bridge (multiseat)
>  1b36:000b  PCIe Expander Bridge (-device pxb-pcie)
>  1b36:000d  PCI xhci usb host adapter
> +1b36:000f  mdpy (mdev sample device), linux/samples/vfio-mdev/mdpy.c
>  
>  All these devices are documented in docs/specs.
>  
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index a9c3ee5aa2..990d6fcbde 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -101,6 +101,7 @@ extern bool pci_available;
>  #define PCI_DEVICE_ID_REDHAT_PCIE_RP     0x000c
>  #define PCI_DEVICE_ID_REDHAT_XHCI        0x000d
>  #define PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE 0x000e
> +#define PCI_DEVICE_ID_REDHAT_MDPY        0x000f
>  #define PCI_DEVICE_ID_REDHAT_QXL         0x0100
>  
>  #define FMT_PCIBUS                      PRIx64
> -- 
> 2.9.3

  reply	other threads:[~2018-04-26 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  6:38 [Qemu-devel] [PATCH] allocate pci id for mdpy Gerd Hoffmann
2018-04-26 15:10 ` Michael S. Tsirkin [this message]
2018-04-26 15:31   ` Gerd Hoffmann
2018-04-26 15:40     ` Michael S. Tsirkin
2018-04-26 17:00       ` Alex Williamson
2018-04-26 18:36         ` Michael S. Tsirkin
2018-04-27  6:18       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426180955-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.