All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/2] nvme/multipath: Fix multipath disabled naming collisions
Date: Fri, 27 Apr 2018 07:21:44 +0200	[thread overview]
Message-ID: <20180427052144.GC9698@lst.de> (raw)
In-Reply-To: <20180426214956.3377-3-keith.busch@intel.com>

On Thu, Apr 26, 2018@03:49:56PM -0600, Keith Busch wrote:
> When CONFIG_NVME_MULTIPATH is set, but we're not using nvme to multipath,
> namespaces with multiple paths were not creating unique names due to
> reusing the same instance number from the namespace's head.
> 
> This patch fixes this by falling back to the non-multipath naming method
> when the parameter disabled using multipath.
> 
> Reported-by: Mike Snitzer <snitzer at redhat.com>
> Signed-off-by: Keith Busch <keith.busch at intel.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>

  reply	other threads:[~2018-04-27  5:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 21:49 [PATCH 0/2] nvme multipath naming fixes Keith Busch
2018-04-26 21:49 ` [PATCH 1/2] nvme/multipath: Disable runtime writable enabling parameter Keith Busch
2018-04-27  5:20   ` Christoph Hellwig
2018-04-27 15:48     ` Keith Busch
2018-10-30 18:17   ` Sagi Grimberg
2018-10-30 18:18     ` Sagi Grimberg
2018-10-30 18:24       ` Keith Busch
2018-10-31  5:28         ` Christoph Hellwig
2018-04-26 21:49 ` [PATCH 2/2] nvme/multipath: Fix multipath disabled naming collisions Keith Busch
2018-04-27  5:21   ` Christoph Hellwig [this message]
2018-10-29 15:37   ` Stephen  Bates
2018-10-29 15:42     ` Keith Busch
2018-10-29 15:48       ` Stephen  Bates
2018-10-29 15:55         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427052144.GC9698@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.