From: Stephen Hemminger <stephen@networkplumber.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc
Date: Fri, 27 Apr 2018 09:17:02 -0700 [thread overview]
Message-ID: <20180427091702.2e91a5dc@xeon-e3> (raw)
In-Reply-To: <20180427121706.23273-2-toke@toke.dk>
On Fri, 27 Apr 2018 14:17:06 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> + } else if (strcmp(*argv, "datacentre") == 0) {
> + interval = 100;
> + target = 5;
> + } else if (strcmp(*argv, "lan") == 0) {
> + interval = 1000;
> + target = 50;
> + } else if (strcmp(*argv, "metro") == 0) {
> + interval = 10000;
> + target = 500;
> + } else if (strcmp(*argv, "regional") == 0) {
> + interval = 30000;
> + target = 1500;
> + } else if (strcmp(*argv, "internet") == 0) {
> + interval = 100000;
> + target = 5000;
> + } else if (strcmp(*argv, "oceanic") == 0) {
> + interval = 300000;
> + target = 15000;
> + } else if (strcmp(*argv, "satellite") == 0) {
> + interval = 1000000;
> + target = 50000;
> + } else if (strcmp(*argv, "interplanetary") == 0) {
> + interval = 1000000000;
> + target = 50000000;
> +
There enough tuning entries of this type, that it would be better
to make a table that can be expanded.
The code should also only allow one of these options. Use duparg()?
next prev parent reply other threads:[~2018-04-27 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 12:17 [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-04-27 12:17 ` [PATCH iproute2-next v5] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-27 16:17 ` Stephen Hemminger [this message]
2018-04-27 13:17 ` [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc Eric Dumazet
2018-04-27 13:38 ` Toke Høiland-Jørgensen
2018-04-27 13:44 ` Eric Dumazet
2018-04-27 13:45 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427091702.2e91a5dc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.