From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH V2 3/3] usb: xhci: tegra: Add support for managing powergates Date: Fri, 27 Apr 2018 12:13:00 +0200 Message-ID: <20180427101300.GR30388@ulmo> References: <1524754750-3633-1-git-send-email-jonathanh@nvidia.com> <1524754750-3633-3-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Kuk/n493crKO4rgR" Return-path: Content-Disposition: inline In-Reply-To: <1524754750-3633-3-git-send-email-jonathanh@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Jon Hunter Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org --Kuk/n493crKO4rgR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 26, 2018 at 03:59:10PM +0100, Jon Hunter wrote: > The Tegra XHCI controller requires that the XUSBA (for superspeed) and > XUSBC (for host) power-domains are enabled. Commit 8df127456f29 > ("soc/tegra: pmc: Enable XUSB partitions on boot") was added to force > on these power-domains if the XHCI driver is enabled while proper > power-domain support is added, to ensure the device did not hang on > boot. However, rather than forcing on these power-domains in the PMC > driver we can use the legacy Tegra powergate APIs to turn on these > power-domains during the probe of the Tegra XHCI driver. >=20 > In the near future we plan to move the Tegra XHCI driver to use the > generic PM domain framework for power-domains and so to prepare for > this only use the legacy Tegra powergate API if there is not PM > domain associated with device (ie. dev.pm_domain is NULL). Please > note that in the future the superspeed and host resets will be handled > by the generic PM domain provider and so these are only these are only > needed in the case where there is no generic PM domain. >=20 > Signed-off-by: Jon Hunter > --- >=20 > Changes since V1: > - None >=20 > drivers/usb/host/xhci-tegra.c | 68 +++++++++++++++++++++++++++++++------= ------ > 1 file changed, 49 insertions(+), 19 deletions(-) Seems fine to me: Reviewed-by: Thierry Reding Acked-by: Thierry Reding --Kuk/n493crKO4rgR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlri96sACgkQ3SOs138+ s6HZhw//egJEzwCSLViIX7vjQ8k/H9ZEACSjHStMmwnvl6iemM0c6UwIX9Zwpbc+ d3yKlTj1CLBgNus9hVGH2OoXCK1ve+XMisUKvQUAXxOCONqWXQ5RI20aWleQJx6g rpwX3R/GFfRuNvSEUoQmWHUMZw6HcJGMMU5JvwqimWqlDStEn8APzxpBx/5x51Rt XgmDgArgb248qotsu4sYz0dEeoQkKdvId4TL/SR9JV4c4XrxPmaglDh+eJo+sFFm CG34Ro9rcHdzLu1rhYnnZuKxN9cR4A1vxWnrB/ETCBlIZpQ/zSQeqN/1lutm1B1r np/zUcpZtxNyU1BU01/XUdnrgm5tonFQoO/UpFk4JAJ0eqmwhS6gL6e2vtJ0j2+/ GEoA+mllur7IBnsTsY16PGu5cfm+JQe+XCsU4pcqemF1594KlDiRxLXeqH3W/U+6 6Av+VXp0xQhF6Gqmzxfygkj8R7RD1ng+rpwZAResezH4GJZk3MZCMGdfxzw13PeL UnCEdqukPqcTSZI+QcQJ3+yFnDzl65t7MnPSJT4LrVCzMiPxND7YUzx2oX230GIv ZUvj9CIrc4r1IUSKK0hz43Rsie6O3gVvSPYPsexpy9v4pHdKu/RCh/QhIaERbx2F 5tn5qh+3s/DiHn+LnOxDJUbHCsZhrC70oh6XbKT0EfGOzivueNg= =B7hL -----END PGP SIGNATURE----- --Kuk/n493crKO4rgR-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V2,3/3] usb: xhci: tegra: Add support for managing powergates From: Thierry Reding Message-Id: <20180427101300.GR30388@ulmo> Date: Fri, 27 Apr 2018 12:13:00 +0200 To: Jon Hunter Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMDM6NTk6MTBQTSArMDEwMCwgSm9uIEh1bnRlciB3cm90 ZToKPiBUaGUgVGVncmEgWEhDSSBjb250cm9sbGVyIHJlcXVpcmVzIHRoYXQgdGhlIFhVU0JBIChm b3Igc3VwZXJzcGVlZCkgYW5kCj4gWFVTQkMgKGZvciBob3N0KSBwb3dlci1kb21haW5zIGFyZSBl bmFibGVkLiBDb21taXQgOGRmMTI3NDU2ZjI5Cj4gKCJzb2MvdGVncmE6IHBtYzogRW5hYmxlIFhV U0IgcGFydGl0aW9ucyBvbiBib290Iikgd2FzIGFkZGVkIHRvIGZvcmNlCj4gb24gdGhlc2UgcG93 ZXItZG9tYWlucyBpZiB0aGUgWEhDSSBkcml2ZXIgaXMgZW5hYmxlZCB3aGlsZSBwcm9wZXIKPiBw b3dlci1kb21haW4gc3VwcG9ydCBpcyBhZGRlZCwgdG8gZW5zdXJlIHRoZSBkZXZpY2UgZGlkIG5v dCBoYW5nIG9uCj4gYm9vdC4gSG93ZXZlciwgcmF0aGVyIHRoYW4gZm9yY2luZyBvbiB0aGVzZSBw b3dlci1kb21haW5zIGluIHRoZSBQTUMKPiBkcml2ZXIgd2UgY2FuIHVzZSB0aGUgbGVnYWN5IFRl Z3JhIHBvd2VyZ2F0ZSBBUElzIHRvIHR1cm4gb24gdGhlc2UKPiBwb3dlci1kb21haW5zIGR1cmlu ZyB0aGUgcHJvYmUgb2YgdGhlIFRlZ3JhIFhIQ0kgZHJpdmVyLgo+IAo+IEluIHRoZSBuZWFyIGZ1 dHVyZSB3ZSBwbGFuIHRvIG1vdmUgdGhlIFRlZ3JhIFhIQ0kgZHJpdmVyIHRvIHVzZSB0aGUKPiBn ZW5lcmljIFBNIGRvbWFpbiBmcmFtZXdvcmsgZm9yIHBvd2VyLWRvbWFpbnMgYW5kIHNvIHRvIHBy ZXBhcmUgZm9yCj4gdGhpcyBvbmx5IHVzZSB0aGUgbGVnYWN5IFRlZ3JhIHBvd2VyZ2F0ZSBBUEkg aWYgdGhlcmUgaXMgbm90IFBNCj4gZG9tYWluIGFzc29jaWF0ZWQgd2l0aCBkZXZpY2UgKGllLiBk ZXYucG1fZG9tYWluIGlzIE5VTEwpLiBQbGVhc2UKPiBub3RlIHRoYXQgaW4gdGhlIGZ1dHVyZSB0 aGUgc3VwZXJzcGVlZCBhbmQgaG9zdCByZXNldHMgd2lsbCBiZSBoYW5kbGVkCj4gYnkgdGhlIGdl bmVyaWMgUE0gZG9tYWluIHByb3ZpZGVyIGFuZCBzbyB0aGVzZSBhcmUgb25seSB0aGVzZSBhcmUg b25seQo+IG5lZWRlZCBpbiB0aGUgY2FzZSB3aGVyZSB0aGVyZSBpcyBubyBnZW5lcmljIFBNIGRv bWFpbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKb24gSHVudGVyIDxqb25hdGhhbmhAbnZpZGlhLmNv bT4KPiAtLS0KPiAKPiBDaGFuZ2VzIHNpbmNlIFYxOgo+IC0gTm9uZQo+IAo+ICBkcml2ZXJzL3Vz Yi9ob3N0L3hoY2ktdGVncmEuYyB8IDY4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDE5IGRlbGV0 aW9ucygtKQoKU2VlbXMgZmluZSB0byBtZToKClJldmlld2VkLWJ5OiBUaGllcnJ5IFJlZGluZyA8 dHJlZGluZ0BudmlkaWEuY29tPgpBY2tlZC1ieTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZp ZGlhLmNvbT4K