From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] eal: fix threads block on barrier
Date: Fri, 27 Apr 2018 10:39:45 -0700
Message-ID: <20180427103945.511a118e@xeon-e3>
References: <1524847302-88110-1-git-send-email-jianfeng.tan@intel.com>
 <HE1PR0402MB2780B91365742CFF549F7F8F908D0@HE1PR0402MB2780.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Jianfeng Tan <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "thomas@monjalon.net" <thomas@monjalon.net>, Olivier Matz
 <olivier.matz@6wind.com>, Anatoly Burakov <anatoly.burakov@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67])
 by dpdk.org (Postfix) with ESMTP id A9E45AAF5
 for <dev@dpdk.org>; Fri, 27 Apr 2018 19:39:48 +0200 (CEST)
Received: by mail-pg0-f67.google.com with SMTP id i6-v6so2080825pgv.3
 for <dev@dpdk.org>; Fri, 27 Apr 2018 10:39:48 -0700 (PDT)
In-Reply-To: <HE1PR0402MB2780B91365742CFF549F7F8F908D0@HE1PR0402MB2780.eurprd04.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 27 Apr 2018 17:36:56 +0000
Shreyansh Jain <shreyansh.jain@nxp.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianfeng Tan
> > Sent: Friday, April 27, 2018 10:12 PM
> > To: dev@dpdk.org
> > Cc: thomas@monjalon.net; Jianfeng Tan <jianfeng.tan@intel.com>; Olivier
> > Matz <olivier.matz@6wind.com>; Anatoly Burakov
> > <anatoly.burakov@intel.com>
> > Subject: [dpdk-dev] [PATCH] eal: fix threads block on barrier
> > 
> > Below commit introduced pthread barrier for synchronization.
> > But two IPC threads block on the barrier, and never wake up.
> > 
> >   (gdb) bt
> >   #0  futex_wait (private=0, expected=0, futex_word=0x7fffffffcff4)
> >       at ../sysdeps/unix/sysv/linux/futex-internal.h:61
> >   #1  futex_wait_simple (private=0, expected=0,
> > futex_word=0x7fffffffcff4)
> >       at ../sysdeps/nptl/futex-internal.h:135
> >   #2  __pthread_barrier_wait (barrier=0x7fffffffcff0) at
> > pthread_barrier_wait.c:184
> >   #3  rte_thread_init (arg=0x7fffffffcfe0)
> >       at ../dpdk/lib/librte_eal/common/eal_common_thread.c:160
> >   #4  start_thread (arg=0x7ffff6ecf700) at pthread_create.c:333
> >   #5  clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> > 
> > Through analysis, we find the barrier defined on the stack could be the
> > root cause. This patch will change to use heap memory as the barrier.
> > 
> > Fixes: d651ee4919cd ("eal: set affinity for control threads")
> > 
> > Cc: Olivier Matz <olivier.matz@6wind.com>
> > Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> > 
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>  
> 
> Though I have seen Stephen's comment on this (possibly a library bug), this at least fixes an issue which was dogging dpaa and dpaa2 - generating bus errors and futex errors with variation in core masks provided to applications.
> 
> Thanks a lot for this.
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Could you verify there is not a use after free by using valgrind or some library that poisons memory on free.