From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC] drm/i915: Rework "Potential atomic update error" to handle PSR exit Date: Fri, 27 Apr 2018 15:41:42 +0300 Message-ID: <20180427124142.GU23723@intel.com> References: <20180426021009.178880-1-tarun.vyas@intel.com> <20180426134157.GL23723@intel.com> <1524764860.28916.3.camel@dk-H97M-D3H> <20180426213904.GA50779@otc-chromeosbuild-5> <20180427030956.GA195018@otc-chromeosbuild-5> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26C856E8EB for ; Fri, 27 Apr 2018 12:41:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180427030956.GA195018@otc-chromeosbuild-5> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tarun Vyas Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMDg6MDk6NTZQTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90 ZToKPiBPbiBUaHUsIEFwciAyNiwgMjAxOCBhdCAwMjozOTowNFBNIC0wNzAwLCBUYXJ1biBWeWFz IHdyb3RlOgo+ID4gT24gVGh1LCBBcHIgMjYsIDIwMTggYXQgMTA6NDc6NDBBTSAtMDcwMCwgRGhp bmFrYXJhbiBQYW5kaXlhbiB3cm90ZToKPiA+ID4gCj4gPiA+IAo+ID4gPiAKPiA+ID4gT24gVGh1 LCAyMDE4LTA0LTI2IGF0IDE2OjQxICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+ ID4gT24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDc6MTA6MDlQTSAtMDcwMCwgdGFydW4udnlhc0Bp bnRlbC5jb20gd3JvdGU6Cj4gPiA+ID4gPiBGcm9tOiBUYXJ1biA8dGFydW4udnlhc0BpbnRlbC5j b20+Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IFRoZSBEaXNwbGF5IHNjYW5saW5lIGNvdW50ZXIgZnJl ZXplcyBvbiBQU1IgZW50cnkuIEluc2lkZQo+ID4gPiA+ID4gaW50ZWxfcGlwZV91cGRhdGVfc3Rh cnQsIG9uY2UgVmJsYW5rIGludGVycnVwdHMgYXJlIGVuYWJsZWQsIHdlIHN0YXJ0Cj4gPiA+ID4g PiBleGl0aW5nIFBTUiwgYnV0IGJ5IHRoZSB0aW1lIHRoZSBzY2FubGluZSBjb3VudGVyIGlzIHJl YWQsIHdlIG1heSBub3QKPiA+ID4gPiA+IGhhdmUgY29tcGxldGVseSBleGl0ZWQgUFNSIHdoaWNo IGxlYWRzIHVzIHRvIHNjaGVkdWxlIG91dCBhbmQgY2hlY2sgYmFjawo+ID4gPiA+ID4gbGF0ZXIu Cj4gPiA+ID4gPiBPbiBDaHJvbWVPUy00LjQga2VybmVsLCB3aGljaCBpcyBmYWlybHkgdXAtdG8t ZGF0ZSB3LnIudCBkcm0vaTkxNSBidXQKPiA+ID4gPiA+IGxhZ3Mgdy5yLnQgY29yZSBrZXJuZWwg Y29kZSwgaG90IHBsdWdnaW5nIGFuIGV4dGVybmFsIGRpc3BsYXkgdHJpZ2dlcnMKPiA+ID4gPiA+ IHRvbnMgb2YgInBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGVycm9ycyIgaW4gdGhlIGRtZXNnLCBv biAqcGlwZSBBKi4gQQo+ID4gPiA+ID4gY2xvc2VyIGFuYWx5c2lzIHJldmVhbHMgdGhhdCB3ZSB0 cnkgdG8gcmVhZCB0aGUgc2NhbmxpbmUgMyB0aW1lcyBhbmQKPiA+ID4gPiA+IGV2ZW50dWFsbHkg dGltZW91dCwgYi9jIFBTUiBoYXNuJ3QgZXhpdGVkIGZ1bGx5IGxlYWRpbmcgdG8gYSBQSVBFRFNM IHN0dWNrIEAKPiA+ID4gPiA+IDE1OTkuCj4gPiA+ID4gPiBUaGlzIGlzc3VlIGlzIG5vdCBzZWVu IG9uIHVwc3RyZWFtIGtlcm5lbHMsIGIvYyBmb3IgKnNvbWUqIHJlYXNvbiB3ZQo+ID4gPiA+ID4g bG9vcCBpbnNpZGUgaW50ZWxfcGlwZV91cGRhdGUgc3RhcnQgZm9yIH4yKyBtc2VjIHdoaWNoIGlu IHRoaXMgY2FzZSBpcwo+ID4gPiA+ID4gbW9yZSB0aGFuIGVub3VnaCB0byBleGl0IFBTUiBmdWxs eSwgaGVuY2UgYW4gKnVuc3R1Y2sqIFBJUEVEU0wgY291bnRlciwKPiA+ID4gPiA+IGhlbmNlIG5v IGVycm9yLiBPbiB0aGUgb3RoZXIgaGFuZCwgdGhlIENocm9tZU9TIGtlcm5lbCBzcGVuZHMgfjEu MSBtc2VjCj4gPiA+ID4gPiBsb29waW5nIGluc2lkZSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydCBh bmQgaGVuY2UgZXJyb3JzIG91dCBiL2MgdGhlCj4gPiA+ID4gPiBzb3VyY2UgaXMgc3RpbGwgaW4g UFNSLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBJZiBQU1IgaXMgZW5hYmxlZCwgdGhlbiB3ZSBzaG91 bGQgKndhaXQqIGZvciAgdGhlIFBTUgo+ID4gPiA+ID4gc3RhdGUgdG8gbW92ZSB0byBJRExFIGJl Zm9yZSByZS1yZWFkaW5nIHRoZSBQSVBFRFNMIHNvIGFzIHRvIGF2b2lkIGJvZ3VzCj4gPiA+ID4g PiBhbmQgYW5ub3lpbmcgInBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGVycm9yIiBtZXNzYWdlcy4K PiA+ID4gPiA+IAo+ID4gPiA+ID4gUC5TOiBUaGlzIHNjZW5hcmlvIGFwcGxpZXMgdG8gYSBjb25m aWd1cmF0aW9uIHdpdGggYW4gYWRkaXRpb25hbCBwaXBlLAo+ID4gPiA+ID4gYXMgb2Ygbm93Lgo+ ID4gPiA+ID4gCj4gPiA+IAo+ID4gPiBWaWxsZSwgCj4gPiA+IAo+ID4gPiBBbnkgaWRlYSB3aGF0 IGNvdWxkIGJlIHRoZSByZWFzb24gdGhlIHdhcm5pbmdzIHN0YXJ0IGFwcGVhcmluZyB3aGVuIGFu Cj4gPiA+IGV4dGVybmFsIGRpc3BsYXkgaXMgY29ubmVjdGVkPyBXZSBjb3VsZG4ndCBjb21lIHVw IHdpdGggYW4gZXhwbGFuYXRpb24uCj4gPiA+IAo+ID4gQW5vdGhlciBzb3VyY2Ugb2YgY29uZnVz aW9uIGZvciBtZSBpcyB0aGF0IG9uIHRoZSB1cHN0cmVhbSBrZXJuZWxzLCBpdCAqYXBwZWFycyog dG8gdGFrZSBtb3JlIHRpbWUgZm9yIHVzIHRvIGdldCAqcmUtc2NoZWR1bGVkKiBhZnRlciB3ZSBj YWxsIHNjaGVkdWxlX3RpbWVvdXQoKS4gU28gd2l0aCB+Mittc2VjIHNwZW50IGluIHRoZSBsb29w LCBpdCBzZWVtcyB0byBiZSBub3Qgd29ya2luZyBhcyBpbnRlbmRlZCBiL2Mgd2UgZW5kIHVwIHNw ZW5kaW5nIGEgbG90IG1vcmUgdGltZSBpbiB0aGUgbG9vcCwgd2hpY2ggaW4gdHVybiBjb250cmli dXRlcyB0byB0aGlzIGlzc3VlIG5vdCBiZWluZyBzZWVuIG9uIHVwc3RyZWFtIGtlcm5lbHMuCj4g PiA+IAo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogVGFydW4gPHRhcnVuLnZ5YXNAaW50ZWwuY29t Pgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3By aXRlLmMgfCAxOSArKysrKysrKysrKysrKystLS0tCj4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQs IDE1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiAKPiA+ID4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+ID4gPiBpbmRleCBhYTFkZmFhNjkyYjku Ljc3ZGQzYjkzNjEzMSAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Nwcml0ZS5jCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9zcHJpdGUuYwo+ID4gPiA+ID4gQEAgLTkyLDExICs5MiwxMyBAQCB2b2lkIGludGVsX3BpcGVf dXBkYXRlX3N0YXJ0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0 ZSkKPiA+ID4gPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShjcnRjLT5iYXNlLmRldik7Cj4gPiA+ID4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICphZGp1c3RlZF9tb2RlID0gJm5ld19jcnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGU7 Cj4gPiA+ID4gPiAgCWxvbmcgdGltZW91dCA9IG1zZWNzX3RvX2ppZmZpZXNfdGltZW91dCgxKTsK PiA+ID4gPiA+IC0JaW50IHNjYW5saW5lLCBtaW4sIG1heCwgdmJsYW5rX3N0YXJ0Owo+ID4gPiA+ ID4gKwlpbnQgc2NhbmxpbmUsIG1pbiwgbWF4LCB2Ymxhbmtfc3RhcnQsIG9sZF9zY2FubGluZSwg bmV3X3NjYW5saW5lOwo+ID4gPiA+ID4gKwlib29sIHJldHJpZWQgPSBmYWxzZTsKPiA+ID4gPiA+ ICAJd2FpdF9xdWV1ZV9oZWFkX3QgKndxID0gZHJtX2NydGNfdmJsYW5rX3dhaXRxdWV1ZSgmY3J0 Yy0+YmFzZSk7Cj4gPiA+ID4gPiAgCWJvb2wgbmVlZF92bHZfZHNpX3dhID0gKElTX1ZBTExFWVZJ RVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSAmJgo+ID4gPiA+ID4gIAkJ aW50ZWxfY3J0Y19oYXNfdHlwZShuZXdfY3J0Y19zdGF0ZSwgSU5URUxfT1VUUFVUX0RTSSk7Cj4g PiA+ID4gPiAgCURFRklORV9XQUlUKHdhaXQpOwo+ID4gPiA+ID4gKwlvbGRfc2NhbmxpbmUgPSBu ZXdfc2NhbmxpbmUgPSAtMTsKPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICAJdmJsYW5rX3N0YXJ0ID0g YWRqdXN0ZWRfbW9kZS0+Y3J0Y192Ymxhbmtfc3RhcnQ7Cj4gPiA+ID4gPiAgCWlmIChhZGp1c3Rl ZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfSU5URVJMQUNFKQo+ID4gPiA+ID4gQEAgLTEy NiwxNSArMTI4LDI0IEBAIHZvaWQgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQoY29uc3Qgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlKQo+ID4gPiA+ID4gIAkJICogcmVhZCB0 aGUgc2NhbmxpbmUuCj4gPiA+ID4gPiAgCQkgKi8KPiA+ID4gPiA+ICAJCXByZXBhcmVfdG9fd2Fp dCh3cSwgJndhaXQsIFRBU0tfVU5JTlRFUlJVUFRJQkxFKTsKPiA+ID4gPiA+IC0KPiA+ID4gPiA+ ICtyZXRyeToKPiA+ID4gPiA+ICAJCXNjYW5saW5lID0gaW50ZWxfZ2V0X2NydGNfc2NhbmxpbmUo Y3J0Yyk7Cj4gPiA+ID4gPiArCQlvbGRfc2NhbmxpbmUgPSBuZXdfc2NhbmxpbmUsIG5ld19zY2Fu bGluZSA9IHNjYW5saW5lOwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gIAkJaWYgKHNjYW5saW5lIDwg bWluIHx8IHNjYW5saW5lID4gbWF4KQo+ID4gPiA+ID4gIAkJCWJyZWFrOwo+ID4gPiA+ID4gIAo+ ID4gPiA+ID4gIAkJaWYgKHRpbWVvdXQgPD0gMCkgewo+ID4gPiA+ID4gLQkJCURSTV9FUlJPUigi UG90ZW50aWFsIGF0b21pYyB1cGRhdGUgZmFpbHVyZSBvbiBwaXBlICVjXG4iLAo+ID4gPiA+ID4g KwkJCWlmKCFpOTE1LmVuYWJsZV9wc3IgfHwgcmV0cmllZCkgewo+ID4gPiAKPiA+ID4gWW91IGNv dWxkIHVzZSB0aGUgQ0FOX1BTUigpIG1hY3JvIHRoYXQgY2hlY2tzIGZvciBzb3VyY2UgYW5kIHNp bmsKPiA+ID4gc3VwcG9ydC4KPiA+ID4gCj4gPiBXaWxsIGRvLgo+ID4gPiA+ID4gKwkJCQlEUk1f RVJST1IoIlBvdGVudGlhbCBhdG9taWMgdXBkYXRlIGZhaWx1cmUgb24gcGlwZSAlY1xuIiwKPiA+ ID4gPiA+ICAJCQkJICBwaXBlX25hbWUoY3J0Yy0+cGlwZSkpOwo+ID4gPiA+ID4gLQkJCWJyZWFr Owo+ID4gPiA+ID4gKwkJCQlicmVhazsKPiA+ID4gPiA+ICsJCQl9Cj4gPiA+ID4gPiArCQkJZWxz ZSBpZihvbGRfc2NhbmxpbmUgPT0gbmV3X3NjYW5saW5lICYmICFyZXRyaWVkKSB7Cj4gPiA+ID4g PiArCQkJCXJldHJpZWQgPSB0cnVlOwo+ID4gPiA+ID4gKwkJCQlpbnRlbF93YWl0X2Zvcl9yZWdp c3RlcihkZXZfcHJpdiwgRURQX1BTUl9TVEFUVVNfQ1RMLCBFRFBfUFNSX1NUQVRVU19TVEFURV9N QVNLLCBFRFBfUFNSX1NUQVRVU19TVEFURV9JRExFLCAxMCk7Cj4gPiA+ID4gCj4gPiA+ID4gV2hh dCdzIHRoZSBwb2ludCBvZiBvYmZ1c2NhdGluZyB0aGUgbG9vcCB3aXRoIHRoaXMgc3R1ZmY/Cj4g PiA+ID4gSnVzdCB3YWl0IGZvciB0aGUgUFNSIGV4aXQgYmVmb3JlIHdlIGV2ZW4gZW50ZXIgdGhl IGxvb3A/Cj4gPiA+ID4KPiA+IEFncmVlZC4KPiBPbiBhIHNlY29uZCB0aG91Z2h0LCBJIHdhcyBk b2luZyBpdCB3cm9uZyBpbiB0aGUgaW5pdGlhbCBSRkMuIENhbid0IGRvIGEgd2FpdF9mb3JfcmVn aXN0ZXIgd2l0aCBpcnFzIGRpc2FibGVkIGJ5IGxvY2FsX2lycV9kaXNhYmxlKCkuIFNvLCB3aWxs IGhhdmUgdG8gKnBvbGwqIHRoZSBQU1JfU1RBVEUsIGJ1dCB3aWxsIHRoYXQgYmUgZGVzaXJhYmxl ID8KCkRvIGl0IGJlZm9yZSBkaXNhYmxpbmcgdGhlIGlycXM/IEFzIGxvbmcgYXMgd2UgcHJldmVu dCBpdCBmcm9tCnJlLWVudGVyaW5nIFBTUiBhZnRlciB0aGUgd2FpdCBpdCBzaG91bGQgYmUgc2Fm ZS4gTWF5YmUgdGhlIHZibGFuayBpcnEKaXMgdGhlIGJlc3Qgd2F5IHRvIHByZXZlbnQgdGhlIHJl LWVudHJ5PwoKPiA+ID4gPiA+ICsJCQkJZ290byByZXRyeTsKPiA+ID4gPiA+ICsJCQl9Cj4gPiA+ ID4gPiAgCQl9Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAgCQlsb2NhbF9pcnFfZW5hYmxlKCk7Cj4g PiA+ID4gPiAtLSAKPiA+ID4gPiA+IDIuMTMuNQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiA+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+ID4gPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngKPiA+ID4gPiAKPiA+ID4gCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=