From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v12 08/10] drm: Expose modes with aspect ratio, only if requested Date: Fri, 27 Apr 2018 17:05:23 +0300 Message-ID: <20180427140523.GX23723@intel.com> References: <1524831296-11198-1-git-send-email-ankit.k.nautiyal@intel.com> <1524831296-11198-9-git-send-email-ankit.k.nautiyal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1524831296-11198-9-git-send-email-ankit.k.nautiyal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Nautiyal, Ankit K" Cc: intel-gfx@lists.freedesktop.org, ppaalanen@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMjcsIDIwMTggYXQgMDU6NDQ6NTRQTSArMDUzMCwgTmF1dGl5YWwsIEFua2l0 IEsgd3JvdGU6Cj4gRnJvbTogQW5raXQgTmF1dGl5YWwgPGFua2l0LmsubmF1dGl5YWxAaW50ZWwu Y29tPgo+IAo+IFdlIHBhcnNlIHRoZSBFRElEIGFuZCBhZGQgYWxsIHRoZSBtb2RlcyBpbiB0aGUg Y29ubmVjdG9yJ3MgbW9kZWxpc3QuCj4gVGhpcyBhZGRzIENFQSBtb2RlcyB3aXRoIGFzcGVjdCBy YXRpbyBpbmZvcm1hdGlvbiB0b28sIHJlZ2FkbGVzcyBvZgo+IHdoZXRoZXIgdXNlciBzcGFjZSBy ZXF1ZXN0ZWQgdGhpcyBpbmZvcm1hdGlvbiBvciBub3QuCj4gCj4gVGhpcyBwYXRjaCBwcnVuZXMg dGhlIG1vZGVzIHdpdGggYXNwZWN0LXJhdGlvIGluZm9ybWF0aW9uLCBmcm9tIGEKPiBjb25uZWN0 b3IncyBtb2RlbGlzdCwgaWYgdGhlIHVzZXItc3BhY2UgaGFzIG5vdCBzZXQgdGhlIGFzcGVjdCBy YXRpbwo+IERSTSBjbGllbnQgY2FwLiBIb3dldmVyIGlmIHN1Y2ggYSBtb2RlIGlzIHVuaXF1ZSBp biB0aGUgbGlzdCwgaXQgaXMKPiBrZXB0IGluIHRoZSBsaXN0LCB3aXRoIGFzcGVjdC1yYXRpbyBm bGFncyByZXNldC4KPiAKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gQ2M6IFNoYXNoYW5rIFNoYXJtYSA8c2hhc2hhbmsuc2hhcm1hQGludGVsLmNv bT4KPiBDYzogSm9zZSBBYnJldSA8am9zZS5hYnJldUBzeW5vcHN5cy5jb20+Cj4gCj4gU2lnbmVk LW9mZi1ieTogQW5raXQgTmF1dGl5YWwgPGFua2l0LmsubmF1dGl5YWxAaW50ZWwuY29tPgo+IAo+ IFYzOiBBcyBzdWdnZXN0ZWQgYnkgVmlsbGUsIG1vZGlmaWVkIHRoZSBtZWNoYW5pc20gb2YgcHJ1 bmluZyBvZiBtb2Rlcwo+ICAgICB3aXRoIGFzcGVjdC1yYXRpbywgaWYgdGhlIGFzcGVjdC1yYXRp byBpcyBub3Qgc3VwcG9ydGVkLiBJbnN0ZWFkCj4gICAgIG9mIHN0cmFpZ2h0IGF3YXkgcHJ1bmlu ZyBzdWNoIGEgbW9kZSwgdGhlIG1vZGUgaXMgcmV0YWluZWQgd2l0aAo+ICAgICBhc3BlY3QgcmF0 aW8gYml0cyBzZXQgdG8gemVybywgcHJvdmlkZWQgaXQgaXMgdW5pcXVlLgo+IFY0OiByZWJhc2UK PiBWNTogQWRkcmVzc2VkIHJldmlldyBjb21tZW50cyBmcm9tIFZpbGxlOgo+ICAgICAtdXNlZCBh IHBvaW50ZXIgdG8gc3RvcmUgbGFzdCB2YWxpZCBtb2RlLgo+ICAgICAtYXZvaWRlZCwgbW9kaWZ5 aW5nIG9mIHBpY3R1cmVfYXNwZWN0X3JhdGlvIGluIGtlcm5lbCBtb2RlLAo+ICAgICAgaW5zdGVh ZCBvbmx5IGZsYWdzIGJpdHMgb2YgdXNlciBtb2RlIGFyZSByZXNldCAoaWYgYXNwZWN0LXJhdGlv Cj4gICAgICBpcyBub3Qgc3VwcG9ydGVkKS4KPiBWNjogQXMgc3VnZ2VzdGVkIGJ5IFZpbGxlLCBj b3JyZWN0ZWQgdGhlIG1vZGUgcHJ1bmluZyBsb2dpYyBhbmQKPiAgICAgZWxhYm9yYXRlZCB0aGUg bW9kZSBwcnVuaW5nIGxvZ2ljIGFuZCB0aGUgYXNzdW1wdGlvbnMgdGFrZW4uCj4gVjc6IHJlYmFz ZQo+IFY4OiByZWJhc2UKPiBWOTogcmViYXNlCj4gVjEwOiByZWJhc2UKPiBWMTE6IEZpeGVkIHRo ZSBpc3N1ZSBjYXVzZWQgaW4ga21zXzNkIHRlc3QsIGFuZCBlbmhhbmNlZCB0aGUgcHJ1bmluZwo+ ICAgICAgbG9naWMgdG8gY29ycmVjdGx5IGlkZW50aWZ5IGFuZCBwcnVuZSBtb2RlcyB3aXRoIGFz cGVjdC1yYXRpbywKPiAgICAgIGlmIGFzcGVjdC1yYXRpbyBjYXAgaXMgbm90IHNldC4KPiBWMTI6 IEFzIHN1Z2dlc3RlZCBieSBWaWxsZSwgYWRkZWQgYW5vdGhlciBsaXN0X2hlYWQgaW4KPiAgICAg IGRybV9tb2RlX2Rpc3BsYXkgdG8gdHJhdmVyc2UgdGhlIGxpc3Qgb2YgZXhwb3NlZCBtb2RlcyBh bmQKPiAgICAgIGF2b2lkZWQgZHVwbGljYXRpb24gb2YgbW9kZXMuCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9kcm1fY29ubmVjdG9yLmMgfCA1MiArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLQo+ICBpbmNsdWRlL2RybS9kcm1fbW9kZXMuaCAgICAgICAgIHwgIDkgKysr KysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gaW5kZXggYjNjZGU4OS4uZTEyOTY0YiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYwo+IEBAIC0xNTMxLDE1ICsxNTMxLDM1IEBAIHN0YXRp YyBzdHJ1Y3QgZHJtX2VuY29kZXIgKmRybV9jb25uZWN0b3JfZ2V0X2VuY29kZXIoc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lCj4gIAlyZXR1cm4gY29ubmVjdG9yLT5lbmNvZGVyOwo+ICB9Cj4g IAo+IC1zdGF0aWMgYm9vbCBkcm1fbW9kZV9leHBvc2VfdG9fdXNlcnNwYWNlKGNvbnN0IHN0cnVj dCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+IC0JCQkJCSBjb25zdCBzdHJ1Y3QgZHJtX2ZpbGUg KmZpbGVfcHJpdikKPiArc3RhdGljIGJvb2wKPiArZHJtX21vZGVfZXhwb3NlX3RvX3VzZXJzcGFj ZShjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiArCQkJICAgICBjb25zdCBz dHJ1Y3QgbGlzdF9oZWFkICptb2RlbGlzdCwKPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX2Zp bGUgKmZpbGVfcHJpdikKPiAgewo+ICAJLyoKPiAgCSAqIElmIHVzZXItc3BhY2UgaGFzbid0IGNv bmZpZ3VyZWQgdGhlIGRyaXZlciB0byBleHBvc2UgdGhlIHN0ZXJlbyAzRAo+ICAJICogbW9kZXMs IGRvbid0IGV4cG9zZSB0aGVtLgo+ICAJICovCj4gKwlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAq bW9kZV9pdHI7Cj4gKwoKVGhpcyBpcyBjbGVhcmx5IG1pc3BsYWNlZC4gSXQgc2hvdWxkIGJlIGJl Zm9yZSB0aGUgY29tbWVudC4gSG1tLCAKYXR1YWxseSBiZXR0ZXIgbW92ZSBpdCBpbnRvIHRoZSBh c3BlY3QgcmF0aW8gaWYgYmxvY2sgc2luY2UgaXQncwpub3QgbmVlZGVkIGVsc2V3aGVyZS4KCj4g IAlpZiAoIWZpbGVfcHJpdi0+c3RlcmVvX2FsbG93ZWQgJiYgZHJtX21vZGVfaXNfc3RlcmVvKG1v ZGUpKQo+ICAJCXJldHVybiBmYWxzZTsKPiArCS8qCj4gKwkgKiBJZiB1c2VyLXNwYWNlIGhhc24n dCBjb25maWd1cmVkIHRoZSBkcml2ZXIgdG8gZXhwb3NlIHRoZSBtb2Rlcwo+ICsJICogd2l0aCBh c3BlY3QtcmF0aW8sIGRvbid0IGV4cG9zZSB0aGVtLiBIb3dldmVyIGlmIHN1Y2ggYSBtb2RlCj4g KwkgKiBpcyB1bmlxdWUsIGxldCBpdCBiZSBleHBvc2VkLCBidXQgcmVzZXQgdGhlIGFzcGVjdC1y YXRpbyBmbGFncwo+ICsJICogd2hpbGUgcHJlcGFyaW5nIHRoZSBsaXN0IG9mIHVzZXItbW9kZXMu Cj4gKwkgKi8KPiArCWlmICghZmlsZV9wcml2LT5hc3BlY3RfcmF0aW9fYWxsb3dlZCAmJgo+ICsJ ICAgIG1vZGUtPnBpY3R1cmVfYXNwZWN0X3JhdGlvICE9IEhETUlfUElDVFVSRV9BU1BFQ1RfTk9O RSkgewo+ICsJCWxpc3RfZm9yX2VhY2hfZW50cnkobW9kZV9pdHIsIG1vZGVsaXN0LCBleHBfaGVh ZCkKPiArCQkJaWYgKGRybV9tb2RlX21hdGNoKG1vZGVfaXRyLCBtb2RlLAo+ICsJCQkJCSAgIERS TV9NT0RFX01BVENIX1RJTUlOR1MgfAo+ICsJCQkJCSAgIERSTV9NT0RFX01BVENIX0NMT0NLIHwK PiArCQkJCQkgICBEUk1fTU9ERV9NQVRDSF9GTEFHUyB8Cj4gKwkJCQkJICAgRFJNX01PREVfTUFU Q0hfM0RfRkxBR1MpKQo+ICsJCQkJcmV0dXJuIGZhbHNlOwo+ICsJfQo+ICAKPiAgCXJldHVybiB0 cnVlOwo+ICB9Cj4gQEAgLTE1NTAsNyArMTU3MCw4IEBAIGludCBkcm1fbW9kZV9nZXRjb25uZWN0 b3Ioc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXN0cnVjdCBkcm1fbW9k ZV9nZXRfY29ubmVjdG9yICpvdXRfcmVzcCA9IGRhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyOwo+IC0Jc3RydWN0 IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4gKwlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k ZSwgKnRtcDsKPiArCXN0cnVjdCBsaXN0X2hlYWQgbW9kZWxpc3Q7CgpMSVNUX0hFQURfSU5JVCht b2RlbGlzdCk7CgpBbmQgbWF5YmUgY2FsbCBpdCBleHBvcnRfbGlzdCBvciBzb21ldGhpbmcgbGlr ZSB0aGF0LgoKPiAgCWludCBtb2RlX2NvdW50ID0gMDsKPiAgCWludCBlbmNvZGVyc19jb3VudCA9 IDA7Cj4gIAlpbnQgcmV0ID0gMDsKPiBAQCAtMTYwNSwyMyArMTYyNiwzNCBAQCBpbnQgZHJtX21v ZGVfZ2V0Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlv dXRfcmVzcC0+c3VicGl4ZWwgPSBjb25uZWN0b3ItPmRpc3BsYXlfaW5mby5zdWJwaXhlbF9vcmRl cjsKPiAgCW91dF9yZXNwLT5jb25uZWN0aW9uID0gY29ubmVjdG9yLT5zdGF0dXM7Cj4gIAo+ICsJ SU5JVF9MSVNUX0hFQUQoJm1vZGVsaXN0KTsKPiArCj4gIAkvKiBkZWxheWVkIHNvIHdlIGdldCBt b2RlcyByZWdhcmRsZXNzIG9mIHByZS1maWxsX21vZGVzIHN0YXRlICovCj4gIAlsaXN0X2Zvcl9l YWNoX2VudHJ5KG1vZGUsICZjb25uZWN0b3ItPm1vZGVzLCBoZWFkKQo+IC0JCWlmIChkcm1fbW9k ZV9leHBvc2VfdG9fdXNlcnNwYWNlKG1vZGUsIGZpbGVfcHJpdikpCj4gKwkJaWYgKGRybV9tb2Rl X2V4cG9zZV90b191c2Vyc3BhY2UobW9kZSwgJm1vZGVsaXN0LAo+ICsJCQkJCQkgZmlsZV9wcml2 KSkgewo+ICsJCQlsaXN0X2FkZF90YWlsKCZtb2RlLT5leHBfaGVhZCwgJm1vZGVsaXN0KTsKPiAg CQkJbW9kZV9jb3VudCsrOwo+ICsJCX0KPiAgCj4gIAkvKgo+ICAJICogVGhpcyBpb2N0bCBpcyBj YWxsZWQgdHdpY2UsIG9uY2UgdG8gZGV0ZXJtaW5lIGhvdyBtdWNoIHNwYWNlIGlzCj4gIAkgKiBu ZWVkZWQsIGFuZCB0aGUgMm5kIHRpbWUgdG8gZmlsbCBpdC4KPiArCSAqIFRoZSBtb2RlcyB0aGF0 IG5lZWQgdG8gYmUgZXhwb3NlZCB0byB0aGUgdXNlciBhcmUgbWFpbnRhaW5lZCBpbiB0aGUKPiAr CSAqICdtb2RlbGlzdCcuIFdoZW4gdGhlIGlvY3RsIGlzIGNhbGxlZCBmaXJzdCB0aW1lIHRvIGRl dGVybWluZSB0aGUsCj4gKwkgKiBzcGFjZSwgdGhlIG1vZGVsaXN0IGdldHMgZmlsbGVkLCB0byBm aW5kIHRoZSBuby4gb2YgbW9kZXMuIEluIHRoZQo+ICsJICogMm5kIHRpbWUsIHRoZSB1c2VyIG1v ZGVzIGFyZSBmaWxsZWQsIG9uZSBieSBvbmUgZnJvbSB0aGUgbW9kZWxpc3QuCj4gIAkgKi8KPiAg CWlmICgob3V0X3Jlc3AtPmNvdW50X21vZGVzID49IG1vZGVfY291bnQpICYmIG1vZGVfY291bnQp IHsKPiAgCQljb3BpZWQgPSAwOwo+ICAJCW1vZGVfcHRyID0gKHN0cnVjdCBkcm1fbW9kZV9tb2Rl aW5mbyBfX3VzZXIgKikodW5zaWduZWQgbG9uZylvdXRfcmVzcC0+bW9kZXNfcHRyOwo+IC0JCWxp c3RfZm9yX2VhY2hfZW50cnkobW9kZSwgJmNvbm5lY3Rvci0+bW9kZXMsIGhlYWQpIHsKPiAtCQkJ aWYgKCFkcm1fbW9kZV9leHBvc2VfdG9fdXNlcnNwYWNlKG1vZGUsIGZpbGVfcHJpdikpCj4gLQkJ CQljb250aW51ZTsKPiAtCj4gKwkJbGlzdF9mb3JfZWFjaF9lbnRyeShtb2RlLCAmbW9kZWxpc3Qs IGV4cF9oZWFkKSB7Cj4gIAkJCWRybV9tb2RlX2NvbnZlcnRfdG9fdW1vZGUoJnVfbW9kZSwgbW9k ZSk7Cj4gKwkJCS8qCj4gKwkJCSAqIFJlc2V0IGFzcGVjdCByYXRpbyBmbGFncyBvZiB1c2VyLW1v ZGUsIGlmIG1vZGVzIHdpdGgKPiArCQkJICogYXNwZWN0LXJhdGlvIGFyZSBub3Qgc3VwcG9ydGVk Lgo+ICsJCQkgKi8KPiArCQkJZHJtX21vZGVfZmlsdGVyX2FzcGVjdF9yYXRpb19mbGFncyhmaWxl X3ByaXYsICZ1X21vZGUpOwo+ICAJCQlpZiAoY29weV90b191c2VyKG1vZGVfcHRyICsgY29waWVk LAo+ICAJCQkJCSAmdV9tb2RlLCBzaXplb2YodV9tb2RlKSkpIHsKPiAgCQkJCXJldCA9IC1FRkFV TFQ7Cj4gQEAgLTE2NTEsNiArMTY4MywxMCBAQCBpbnQgZHJtX21vZGVfZ2V0Y29ubmVjdG9yKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlkcm1fbW9kZXNldF91bmxvY2so JmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCk7Cj4gIAo+ICBvdXQ6Cj4gKwlsaXN0 X2Zvcl9lYWNoX2VudHJ5X3NhZmUobW9kZSwgdG1wLCAmbW9kZWxpc3QsIGV4cF9oZWFkKQo+ICsJ CWxpc3RfZGVsKCZtb2RlLT5leHBfaGVhZCk7Cj4gKwlsaXN0X2RlbCgmbW9kZWxpc3QpOwoKVGhh dCBsYXN0IGxpc3RfZGVsKCkgZG9lc24ndCBtYWtlIHNlbnNlLiBBbHNvIHlvdSBjYW4ndCB0b3Vj aCB0aGUKbW9kZS0+ZXhwX2hlYWQgd2l0aG91dCBsb2NraW5nLiBXZSBzaG91bGQgZG9jdW1lbnQg dGhhdCBpdCdzCnByb3RlY3RlZCBieSBtb2RlX2NvbmZpZy5tdXRleC4KClNpbmNlIHdlIGRvbid0 IGFjdHVhbGx5IGNhcmUgYWJvdXQgZXhwX2hlYWQgb3V0c2lkZSBvZiB0aGlzIGZ1bmN0aW9uCkkg dGhpbmsgd2UgY2FuIGp1c3QgbGVhdmUgdGhlIHN0YWxlIHBvaW50ZXJzIGluIHBsYWNlLiBObyBv bmUgZWxzZSBpcwpzdXBwb3NlZCB0byBsb29rIGF0IHRoZW0sIGEgZmFjdCB3ZSBzaG91bGQgcHJv YmFseSBhbHNvIGluY2x1ZGUgaW4gdGhlCmRvY3VtZW50YXRpb24uCgo+ICsKPiAgCWRybV9jb25u ZWN0b3JfcHV0KGNvbm5lY3Rvcik7Cj4gIAo+ICAJcmV0dXJuIHJldDsKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9kcm0vZHJtX21vZGVzLmggYi9pbmNsdWRlL2RybS9kcm1fbW9kZXMuaAo+IGluZGV4 IGUwYjA2MGQuLjE4ODhlYzcgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX21vZGVzLmgK PiArKysgYi9pbmNsdWRlL2RybS9kcm1fbW9kZXMuaAo+IEBAIC00MTEsNiArNDExLDE1IEBAIHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlIHsKPiAgCSAqIEZpZWxkIGZvciBzZXR0aW5nIHRoZSBIRE1J IHBpY3R1cmUgYXNwZWN0IHJhdGlvIG9mIGEgbW9kZS4KPiAgCSAqLwo+ICAJZW51bSBoZG1pX3Bp Y3R1cmVfYXNwZWN0IHBpY3R1cmVfYXNwZWN0X3JhdGlvOwo+ICsKPiArCS8qKgo+ICsJICogQGV4 cF9oZWFkOgoKSSB0aGluayB3ZSBjYW4gYWZmb3JkIHRvIHdyaXRlICdleHBvcnRfaGVhZCcuCgo+ ICsJICoKPiArCSAqIHN0cnVjdCBsaXN0X2hlYWQgZm9yIG1vZGVzIHRvIGJlIGV4cG9zZWQgdG8g dGhlIHVzZXJzcGFjZS4KPiArCSAqCj4gKwkgKi8KPiArCXN0cnVjdCBsaXN0X2hlYWQgZXhwX2hl YWQ7Cj4gKwo+ICB9Owo+ICAKPiAgLyoqCj4gLS0gCj4gMi43LjQKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==