From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] python-subprocess32: new package
Date: Fri, 27 Apr 2018 22:48:37 +0200 [thread overview]
Message-ID: <20180427224837.3bf6d9c9@windsurf> (raw)
In-Reply-To: <20180427071614.24506-1-asafka7@gmail.com>
Hello Asaf,
On Fri, 27 Apr 2018 10:16:14 +0300, Asaf Kahlon wrote:
> A backport of the Python 3 subprocess module for use on Python 2.
>
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Why did you resend the patch ? You didn't increase the version number,
and didn't provide a changelog.
If all you did is add the Reviewed-by: from Yegor, then it is totally
unneeded: patchwork automatically accumulates the
Acked-by/Tested-by/Reviewed-by tags.
In any case, if you send a new version of a patch, please add a version
number (git format-patch -vX, where X is the version number) and
provide a changelog below the "---" sign, right after the Signed-off-by.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-27 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 7:16 [Buildroot] [PATCH 1/1] python-subprocess32: new package Asaf Kahlon
2018-04-27 20:48 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-27 6:53 Asaf Kahlon
2018-04-27 6:58 ` Yegor Yefremov
2018-04-26 18:23 Asaf Kahlon
2018-04-27 6:44 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427224837.3bf6d9c9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.