From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jon Medhurst <tixy@linaro.org>, Will Deacon <will.deacon@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
David Howells <dhowells@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"Tobin C . Harding" <me@tobin.cc>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Richter <tmricht@linux.ibm.com>,
akpm@linux-foundation.org, acme@kernel.org, rostedt@goodmis.org,
brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
stable@vger.kernel.org
Subject: Re: [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages
Date: Sat, 28 Apr 2018 00:06:30 +0900 [thread overview]
Message-ID: <20180428000630.aa8584a67686dd68d1bc9f83@kernel.org> (raw)
In-Reply-To: <20180427065817.tedhin5sy7brgq7m@gmail.com>
On Fri, 27 Apr 2018 08:58:17 +0200
Ingo Molnar <mingo@kernel.org> wrote:
>
> * Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > (addr < (u8 *) jprobe_return_end)) {
> > if (stack_addr(regs) != saved_sp) {
> > struct pt_regs *saved_regs = &kcb->jprobe_saved_regs;
> > - printk(KERN_ERR
> > - "current sp %p does not match saved sp %p\n",
> > + pr_err("current sp %pS does not match saved sp %pS\n",
> > stack_addr(regs), saved_sp);
>
> Why does this use %pS? Stack pointers are typically pointing into general kernel
> RAM, which is totally pointless to display 'symbolically'.
That was I pointed in the last thread, but not accepted.
OK, anyway, there are no good reason to show such a dynamic value.
And now jprobes are gone. I just drop %p from this part.
Thanks,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-04-27 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 6:39 [PATCH v3 0/7] kprobes: Fix %p in kprobes Masami Hiramatsu
2018-04-27 6:39 ` Masami Hiramatsu
2018-04-27 6:40 ` [PATCH v3 1/7] kprobes: Make blacklist root user read only Masami Hiramatsu
2018-04-27 6:56 ` Greg KH
2018-04-27 14:52 ` Masami Hiramatsu
2018-04-27 7:04 ` Ingo Molnar
2018-04-27 15:58 ` Masami Hiramatsu
2018-04-27 6:40 ` [PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does Masami Hiramatsu
2018-04-27 7:14 ` Ingo Molnar
2018-04-27 16:10 ` Masami Hiramatsu
2018-04-27 6:41 ` [PATCH v3 3/7] kprobes: Show address of kprobes if " Masami Hiramatsu
2018-04-27 6:41 ` [PATCH v3 4/7] kprobes: Replace %p with other pointer types Masami Hiramatsu
2018-04-27 6:56 ` Ingo Molnar
2018-04-27 15:42 ` Masami Hiramatsu
2018-04-28 4:43 ` Masami Hiramatsu
2018-04-27 6:42 ` [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages Masami Hiramatsu
2018-04-27 6:58 ` Ingo Molnar
2018-04-27 15:06 ` Masami Hiramatsu [this message]
2018-04-27 6:42 ` [PATCH v3 6/7] kprobes/arm: " Masami Hiramatsu
2018-04-27 6:43 ` [PATCH v3 7/7] kprobes/arm64: " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428000630.aa8584a67686dd68d1bc9f83@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=brueckner@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tixy@linaro.org \
--cc=tmricht@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.