From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Sat, 28 Apr 2018 12:48:27 +0200 Subject: [PATCH 14/17] dt-bindings/interrupt-controller: add description for Marvell SEI node In-Reply-To: <20180427205032.6u5zzf7265wpgppg@rob-hp-laptop> References: <20180421135537.24716-1-miquel.raynal@bootlin.com> <20180421135537.24716-15-miquel.raynal@bootlin.com> <20180427205032.6u5zzf7265wpgppg@rob-hp-laptop> Message-ID: <20180428124827.3992b1ee@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On Fri, 27 Apr 2018 15:50:32 -0500, Rob Herring wrote: > On Sat, Apr 21, 2018 at 03:55:34PM +0200, Miquel Raynal wrote: > > Describe the SEI (System Error Interrupt) controller driver. The > > controller is part of the GIC. It aggregates two types of interrupts, > > wired and MSIs from respectively the AP and the CPs, into a single SPI > > interrupt. > > > > Suggested-by: Haim Boot > > Signed-off-by: Miquel Raynal > > --- > > .../bindings/interrupt-controller/marvell,sei.txt | 54 ++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,sei.txt > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/marvell,sei.txt b/Documentation/devicetree/bindings/interrupt-controller/marvell,sei.txt > > new file mode 100644 > > index 000000000000..a246d59552b1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/marvell,sei.txt > > @@ -0,0 +1,54 @@ > > +Marvell SEI (System Error Interrupt) Controller > > +----------------------------------------------- > > + > > +Marvell SEI (System Error Interrupt) controller is an interrupt aggregator. > > +It receives interrupts from several sources and aggregates them to a single > > +interrupt line (an SPI) on the primary interrupt controller. > > + > > +The IRQ chip can handle up to 64 SEIs, a set comes from the AP and is > > +wired while a second set comes from the CPs by the mean of MSIs. Each > > +'domain' is represented as a subnode. > > + > > +Required properties: > > + > > +- compatible: should be "marvell,armada-8k-sei". > > +- reg: SEI registers location and length. > > +- interrupts: identifies the parent IRQ that will be triggered. > > +- #address-cells: should be '1', represents the position of the first > > + IRQ of a given type in the SEI range. > > +- #size-cells: should be '1', represents the number of a given type of > > + IRQs. > > + > > +Child node 'sei-wired-controller' required properties: > > + > > +- reg: the range of wired interrupts. > > +- #interrupt-cells: number of cells to define an SEI wired interrupt > > + coming from the AP, should be 1. The cell is the IRQ > > + number. > > +- interrupt-controller: identifies the node as an interrupt controller. > > + > > +Child node 'sei-msi-controller' required properties: > > + > > +- reg: the range of non-wired interrupts triggered by way of MSIs. > > +- msi-controller: identifies the node as an MSI controller. > > + > > +Example: > > + > > + sei: sei at 3f0200 { > > + compatible = "marvell,armada-8k-sei"; > > + reg = <0x3f0200 0x40>; > > + interrupts = ; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + sei_wired_controller: sei-wired-controller at 0 { > > + reg = <0 21>; > > Using interrupt numbers in reg is strange. I thought the reg property was the one to choose here, I can of course change it, what would you suggest? > > > + #interrupt-cells = <1>; > > + interrupt-controller; > > + }; > > + > > + sei_msi_controller: sei-msi-controller at 21 { > > + reg = <21 43>; > > + msi-controller; > > Can't the parent be both an interrupt-controller and msi-controller? We need to know which one aggregates interrupts, which one receives MSIs and most importantly which interrupt is what (within the 64 that are handled by the SEI). I thought it would describe the hardware pretty well, do you think to another solution? > > > + }; > > + }; > > -- > > 2.14.1 > > Thanks, Miqu?l -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 14/17] dt-bindings/interrupt-controller: add description for Marvell SEI node Date: Sat, 28 Apr 2018 12:48:27 +0200 Message-ID: <20180428124827.3992b1ee@xps13> References: <20180421135537.24716-1-miquel.raynal@bootlin.com> <20180421135537.24716-15-miquel.raynal@bootlin.com> <20180427205032.6u5zzf7265wpgppg@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180427205032.6u5zzf7265wpgppg@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Marc Zyngier , Catalin Marinas , Gregory Clement , Haim Boot , Will Deacon , Maxime Chevallier , Nadav Haklai , Antoine Tenart , Thomas Petazzoni , Thomas Gleixner , Hanna Hawa , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgUm9iLAoKT24gRnJpLCAyNyBBcHIgMjAxOCAxNTo1MDozMiAtMDUwMCwgUm9iIEhlcnJpbmcg PHJvYmhAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFNhdCwgQXByIDIxLCAyMDE4IGF0IDAzOjU1 OjM0UE0gKzAyMDAsIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBEZXNjcmliZSB0aGUgU0VJIChT eXN0ZW0gRXJyb3IgSW50ZXJydXB0KSBjb250cm9sbGVyIGRyaXZlci4gVGhlCj4gPiBjb250cm9s bGVyIGlzIHBhcnQgb2YgdGhlIEdJQy4gSXQgYWdncmVnYXRlcyB0d28gdHlwZXMgb2YgaW50ZXJy dXB0cywKPiA+IHdpcmVkIGFuZCBNU0lzIGZyb20gcmVzcGVjdGl2ZWx5IHRoZSBBUCBhbmQgdGhl IENQcywgaW50byBhIHNpbmdsZSBTUEkKPiA+IGludGVycnVwdC4KPiA+IAo+ID4gU3VnZ2VzdGVk LWJ5OiBIYWltIEJvb3QgPGhheWltQG1hcnZlbGwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogTWlx dWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KPiA+IC0tLQo+ID4gIC4uLi9i aW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9tYXJ2ZWxsLHNlaS50eHQgIHwgNTQgKysrKysr KysrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1NCBpbnNlcnRpb25zKCspCj4g PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9p bnRlcnJ1cHQtY29udHJvbGxlci9tYXJ2ZWxsLHNlaS50eHQKPiA+IAo+ID4gZGlmZiAtLWdpdCBh L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9t YXJ2ZWxsLHNlaS50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW50ZXJy dXB0LWNvbnRyb2xsZXIvbWFydmVsbCxzZWkudHh0Cj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ ID4gaW5kZXggMDAwMDAwMDAwMDAwLi5hMjQ2ZDU5NTUyYjEKPiA+IC0tLSAvZGV2L251bGwKPiA+ ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJv bGxlci9tYXJ2ZWxsLHNlaS50eHQKPiA+IEBAIC0wLDAgKzEsNTQgQEAKPiA+ICtNYXJ2ZWxsIFNF SSAoU3lzdGVtIEVycm9yIEludGVycnVwdCkgQ29udHJvbGxlcgo+ID4gKy0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiArCj4gPiArTWFydmVsbCBTRUkg KFN5c3RlbSBFcnJvciBJbnRlcnJ1cHQpIGNvbnRyb2xsZXIgaXMgYW4gaW50ZXJydXB0IGFnZ3Jl Z2F0b3IuCj4gPiArSXQgcmVjZWl2ZXMgaW50ZXJydXB0cyBmcm9tIHNldmVyYWwgc291cmNlcyBh bmQgYWdncmVnYXRlcyB0aGVtIHRvIGEgc2luZ2xlCj4gPiAraW50ZXJydXB0IGxpbmUgKGFuIFNQ SSkgb24gdGhlIHByaW1hcnkgaW50ZXJydXB0IGNvbnRyb2xsZXIuCj4gPiArCj4gPiArVGhlIElS USBjaGlwIGNhbiBoYW5kbGUgdXAgdG8gNjQgU0VJcywgYSBzZXQgY29tZXMgZnJvbSB0aGUgQVAg YW5kIGlzCj4gPiArd2lyZWQgd2hpbGUgYSBzZWNvbmQgc2V0IGNvbWVzIGZyb20gdGhlIENQcyBi eSB0aGUgbWVhbiBvZiBNU0lzLiBFYWNoCj4gPiArJ2RvbWFpbicgaXMgcmVwcmVzZW50ZWQgYXMg YSBzdWJub2RlLgo+ID4gKwo+ID4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiArCj4gPiArLSBj b21wYXRpYmxlOiBzaG91bGQgYmUgIm1hcnZlbGwsYXJtYWRhLThrLXNlaSIuCj4gPiArLSByZWc6 IFNFSSByZWdpc3RlcnMgbG9jYXRpb24gYW5kIGxlbmd0aC4KPiA+ICstIGludGVycnVwdHM6IGlk ZW50aWZpZXMgdGhlIHBhcmVudCBJUlEgdGhhdCB3aWxsIGJlIHRyaWdnZXJlZC4KPiA+ICstICNh ZGRyZXNzLWNlbGxzOiBzaG91bGQgYmUgJzEnLCByZXByZXNlbnRzIHRoZSBwb3NpdGlvbiBvZiB0 aGUgZmlyc3QKPiA+ICsgICAgICAgICAgICAgICAgICBJUlEgb2YgYSBnaXZlbiB0eXBlIGluIHRo ZSBTRUkgcmFuZ2UuCj4gPiArLSAjc2l6ZS1jZWxsczogc2hvdWxkIGJlICcxJywgcmVwcmVzZW50 cyB0aGUgbnVtYmVyIG9mIGEgZ2l2ZW4gdHlwZSBvZgo+ID4gKyAgICAgICAgICAgICAgIElSUXMu Cj4gPiArCj4gPiArQ2hpbGQgbm9kZSAnc2VpLXdpcmVkLWNvbnRyb2xsZXInIHJlcXVpcmVkIHBy b3BlcnRpZXM6Cj4gPiArCj4gPiArLSByZWc6IHRoZSByYW5nZSBvZiB3aXJlZCBpbnRlcnJ1cHRz Lgo+ID4gKy0gI2ludGVycnVwdC1jZWxsczogbnVtYmVyIG9mIGNlbGxzIHRvIGRlZmluZSBhbiBT RUkgd2lyZWQgaW50ZXJydXB0Cj4gPiArICAgICAgICAgICAgICAgICAgICBjb21pbmcgZnJvbSB0 aGUgQVAsIHNob3VsZCBiZSAxLiBUaGUgY2VsbCBpcyB0aGUgSVJRCj4gPiArICAgICAgICAgICAg ICAgICAgICBudW1iZXIuCj4gPiArLSBpbnRlcnJ1cHQtY29udHJvbGxlcjogaWRlbnRpZmllcyB0 aGUgbm9kZSBhcyBhbiBpbnRlcnJ1cHQgY29udHJvbGxlci4KPiA+ICsKPiA+ICtDaGlsZCBub2Rl ICdzZWktbXNpLWNvbnRyb2xsZXInIHJlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiArCj4gPiArLSBy ZWc6IHRoZSByYW5nZSBvZiBub24td2lyZWQgaW50ZXJydXB0cyB0cmlnZ2VyZWQgYnkgd2F5IG9m IE1TSXMuCj4gPiArLSBtc2ktY29udHJvbGxlcjogaWRlbnRpZmllcyB0aGUgbm9kZSBhcyBhbiBN U0kgY29udHJvbGxlci4KPiA+ICsKPiA+ICtFeGFtcGxlOgo+ID4gKwo+ID4gKyAgICAgICAgc2Vp OiBzZWlAM2YwMjAwIHsKPiA+ICsgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm1hcnZlbGws YXJtYWRhLThrLXNlaSI7Cj4gPiArICAgICAgICAgICAgICAgcmVnID0gPDB4M2YwMjAwIDB4NDA+ Owo+ID4gKyAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAwIElSUV9UWVBFX0xF VkVMX0hJR0g+Owo+ID4gKyAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ID4g KyAgICAgICAgICAgICAgICNzaXplLWNlbGxzID0gPDE+Owo+ID4gKwo+ID4gKyAgICAgICAgICAg ICAgIHNlaV93aXJlZF9jb250cm9sbGVyOiBzZWktd2lyZWQtY29udHJvbGxlckAwIHsKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwwIDIxPjsgIAo+IAo+IFVzaW5nIGludGVycnVw dCBudW1iZXJzIGluIHJlZyBpcyBzdHJhbmdlLgoKSSB0aG91Z2h0IHRoZSByZWcgcHJvcGVydHkg d2FzIHRoZSBvbmUgdG8gY2hvb3NlIGhlcmUsIEkgY2FuIG9mIGNvdXJzZQpjaGFuZ2UgaXQsIHdo YXQgd291bGQgeW91IHN1Z2dlc3Q/Cgo+IAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgI2lu dGVycnVwdC1jZWxscyA9IDwxPjsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGludGVycnVw dC1jb250cm9sbGVyOwo+ID4gKyAgICAgICAgICAgICAgIH07Cj4gPiArCj4gPiArICAgICAgICAg ICAgICAgc2VpX21zaV9jb250cm9sbGVyOiBzZWktbXNpLWNvbnRyb2xsZXJAMjEgewo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDIxIDQzPjsKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIG1zaS1jb250cm9sbGVyOyAgCj4gCj4gQ2FuJ3QgdGhlIHBhcmVudCBiZSBib3RoIGFu IGludGVycnVwdC1jb250cm9sbGVyIGFuZCBtc2ktY29udHJvbGxlcj8KCldlIG5lZWQgdG8ga25v dyB3aGljaCBvbmUgYWdncmVnYXRlcyBpbnRlcnJ1cHRzLCB3aGljaCBvbmUgcmVjZWl2ZXMKTVNJ cyBhbmQgbW9zdCBpbXBvcnRhbnRseSB3aGljaCBpbnRlcnJ1cHQgaXMgd2hhdCAod2l0aGluIHRo ZSA2NAp0aGF0IGFyZSBoYW5kbGVkIGJ5IHRoZSBTRUkpLgoKSSB0aG91Z2h0IGl0IHdvdWxkIGRl c2NyaWJlIHRoZSBoYXJkd2FyZSBwcmV0dHkgd2VsbCwgZG8geW91IHRoaW5rIHRvCmFub3RoZXIg c29sdXRpb24/CiAKPiAKPiA+ICsgICAgICAgICAgICAgICB9Owo+ID4gKyAgICAgICB9Owo+ID4g LS0gCj4gPiAyLjE0LjEKPiA+ICAgCgpUaGFua3MsCk1pcXXDqGwKCi0tIApNaXF1ZWwgUmF5bmFs LCBCb290bGluIChmb3JtZXJseSBGcmVlIEVsZWN0cm9ucykKRW1iZWRkZWQgTGludXggYW5kIEtl cm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==