From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 17/27] dt-bindings: ap806: add the thermal node in the syscon file Date: Sat, 28 Apr 2018 13:07:14 +0200 Message-ID: <20180428130714.3ee3883b@xps13> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> <20180421151255.29929-18-miquel.raynal@bootlin.com> <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgUm9iLAoKT24gRnJpLCAyNyBBcHIgMjAxOCAxNjowNzoyMiAtMDUwMCwgUm9iIEhlcnJpbmcg PHJvYmhAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFNhdCwgQXByIDIxLCAyMDE4IGF0IDA1OjEy OjQ1UE0gKzAyMDAsIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBFeHBsYWluIHRoZSB0aGVybWFs IGJpbmRpbmdzIG5vdyB0aGF0IHRoZSB0aGVybWFsIElQIGlzIGRlc2NyaWJlZCBiZWluZwo+ID4g aW5zaWRlIG9mIGEgc3lzdGVtIGNvbnRyb2xsZXIuIEFkZCBhIHJlZmVyZW5jZSB0byB0aGUgdGhl cm1hbC16b25lIG5vZGUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1p cXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gPiAtLS0KPiA+ICAuLi4vYXJtL21hcnZlbGwvYXA4 MDYtc3lzdGVtLWNvbnRyb2xsZXIudHh0ICAgICAgICB8IDQzICsrKysrKysrKysrKysrKysrKysr KysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9tYXJ2ZWxsL2FwODA2 LXN5c3RlbS1jb250cm9sbGVyLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9hcm0vbWFydmVsbC9hcDgwNi1zeXN0ZW0tY29udHJvbGxlci50eHQKPiA+IGluZGV4IGE4NTZl YjlhNGUwNS4uYzk1ZjNhYzVjNzI4IDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2FybS9tYXJ2ZWxsL2FwODA2LXN5c3RlbS1jb250cm9sbGVyLnR4dAo+ ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9tYXJ2ZWxsL2Fw ODA2LXN5c3RlbS1jb250cm9sbGVyLnR4dAo+ID4gQEAgLTExLDYgKzExLDkgQEAgRm9yIHRoZSB0 b3AgbGV2ZWwgbm9kZToKPiA+ICAgLSBjb21wYXRpYmxlOiBtdXN0IGJlOiAic3lzY29uIiwgInNp bXBsZS1tZmQiOwo+ID4gICAtIHJlZzogcmVnaXN0ZXIgYXJlYSBvZiB0aGUgQVA4MDYgc3lzdGVt IGNvbnRyb2xsZXIKPiA+ICAKPiA+ICtTWVNURU0gQ09OVFJPTExFUiAwCj4gPiArPT09PT09PT09 PT09PT09PT09PQo+ID4gKwo+ID4gIENsb2NrczoKPiA+ICAtLS0tLS0tCj4gPiAgCj4gPiBAQCAt OTgsMyArMTAxLDQzIEBAIGFwX3N5c2Nvbjogc3lzdGVtLWNvbnRyb2xsZXJANmY0MDAwIHsKPiA+ ICAJCWdwaW8tcmFuZ2VzID0gPCZhcF9waW5jdHJsIDAgMCAxOT47Cj4gPiAgCX07Cj4gPiAgfTsK PiA+ICsKPiA+ICtTWVNURU0gQ09OVFJPTExFUiAxCj4gPiArPT09PT09PT09PT09PT09PT09PQo+ ID4gKwo+ID4gK1RoZXJtYWw6Cj4gPiArLS0tLS0tLS0KPiA+ICsKPiA+ICtGb3IgY29tbW9uIGJp bmRpbmcgcGFydCBhbmQgdXNhZ2UsIHJlZmVyIHRvCj4gPiArRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3RoZXJtYWwvdGhlcm1hbC50eHQKPiA+ICsKPiA+ICtUaGUgdGhlcm1hbCBJ UCBjYW4gcHJvYmUgdGhlIHRlbXBlcmF0dXJlIGFsbCBhcm91bmQgdGhlIHByb2Nlc3Nvci4gSXQK PiA+ICttYXkgZmVhdHVyZSBzZXZlcmFsIGNoYW5uZWxzLCBlYWNoIG9mIHRoZW0gd2lyZWQgdG8g b25lIHNlbnNvci4KPiA+ICsKPiA+ICtJdCBpcyBwb3NzaWJsZSB0byBzZXR1cCBhbiBvdmVyaGVh dCBpbnRlcnJ1cHQgYnkgZ2l2aW5nIGF0IGxlYXN0IG9uZQo+ID4gK2NyaXRpY2FsIHBvaW50IHRv IGFueSBzdWJub2RlIG9mIHRoZSB0aGVybWFsLXpvbmUgbm9kZS4KPiA+ICsKPiA+ICtSZXF1aXJl ZCBwcm9wZXJ0aWVzOgo+ID4gKy0gY29tcGF0aWJsZTogIm1hcnZlbGwsYXJtYWRhLWFwODA2LXRo ZXJtYWwiCj4gPiArCj4gPiArT3B0aW9uYWwgcHJvcGVydGllczoKPiA+ICstIGludGVycnVwdC1w YXJlbnQvaW50ZXJydXB0czogb3ZlcmhlYXQgaW50ZXJydXB0IGhhbmRsZS4gU2hvdWxkIHBvaW50 IHRvCj4gPiArICBsaW5lIDE4IG9mIHRoZSBTRUkgaXJxY2hpcC4KPiA+ICsgIFNlZSBpbnRlcnJ1 cHQtY29udHJvbGxlci9pbnRlcnJ1cHRzLnR4dAo+ID4gKy0gI3RoZXJtYWwtc2Vuc29yLWNlbGxz OiBzaGFsbCBiZSA8MT4gd2hlbiB0aGVybWFsLXpvbmVzIHN1Ym5vZGVzIHJlZmVyCj4gPiArICB0 byB0aGlzIElQIGFuZCByZXByZXNlbnRzIHRoZSBjaGFubmVsIElELiBUaGVyZSBpcyBvbmUgc2Vu c29yIHBlcgo+ID4gKyAgY2hhbm5lbC4gTyByZWZlcnMgdG8gdGhlIHRoZXJtYWwgSVAgaW50ZXJu YWwgY2hhbm5lbCwgd2hpbGUgcG9zaXRpdmUKPiA+ICsgIElEcyByZWZlciB0byBlYWNoIENQVS4K PiA+ICsKPiA+ICtFeGFtcGxlOgo+ID4gK2FwX3N5c2NvbjE6IHN5c3RlbS1jb250cm9sbGVyQDZm ODAwMCB7Cj4gPiArCWNvbXBhdGlibGUgPSAic3lzY29uIiwgInNpbXBsZS1tZmQiOwo+ID4gKwly ZWcgPSA8MHg2ZjgwMDAgMHgxMDAwPjsKPiA+ICsKPiA+ICsJYXBfdGhlcm1hbDogYXAtdGhlcm1h bCB7Cj4gPiArCQljb21wYXRpYmxlID0gIm1hcnZlbGwsYXJtYWRhLWFwODA2LXRoZXJtYWwiOyAg Cj4gCj4gSXMgdGhlcmUgYSByZWdpc3RlciByYW5nZSBhc3NvY2lhdGVkIHdpdGggdGhlIHRoZXJt YWwgZnVuY3Rpb25zPwoKWWVzLCBJIHdpbGwgYWRkIGl0LgoKVGhhbmtzLApNaXF1w6hsCgo+IAo+ ID4gKwkJaW50ZXJydXB0LXBhcmVudCA9IDwmc2VpPjsKPiA+ICsJCWludGVycnVwdHMgPSA8MTg+ Owo+ID4gKwkJI3RoZXJtYWwtc2Vuc29yLWNlbGxzID0gPDE+Owo+ID4gKwl9Owo+ID4gK307Cj4g PiAtLSAKPiA+IDIuMTQuMQo+ID4gICAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Sat, 28 Apr 2018 13:07:14 +0200 Subject: [PATCH 17/27] dt-bindings: ap806: add the thermal node in the syscon file In-Reply-To: <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> <20180421151255.29929-18-miquel.raynal@bootlin.com> <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> Message-ID: <20180428130714.3ee3883b@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On Fri, 27 Apr 2018 16:07:22 -0500, Rob Herring wrote: > On Sat, Apr 21, 2018 at 05:12:45PM +0200, Miquel Raynal wrote: > > Explain the thermal bindings now that the thermal IP is described being > > inside of a system controller. Add a reference to the thermal-zone node. > > > > Signed-off-by: Miquel Raynal > > --- > > .../arm/marvell/ap806-system-controller.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > > index a856eb9a4e05..c95f3ac5c728 100644 > > --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > > +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > > @@ -11,6 +11,9 @@ For the top level node: > > - compatible: must be: "syscon", "simple-mfd"; > > - reg: register area of the AP806 system controller > > > > +SYSTEM CONTROLLER 0 > > +=================== > > + > > Clocks: > > ------- > > > > @@ -98,3 +101,43 @@ ap_syscon: system-controller at 6f4000 { > > gpio-ranges = <&ap_pinctrl 0 0 19>; > > }; > > }; > > + > > +SYSTEM CONTROLLER 1 > > +=================== > > + > > +Thermal: > > +-------- > > + > > +For common binding part and usage, refer to > > +Documentation/devicetree/bindings/thermal/thermal.txt > > + > > +The thermal IP can probe the temperature all around the processor. It > > +may feature several channels, each of them wired to one sensor. > > + > > +It is possible to setup an overheat interrupt by giving at least one > > +critical point to any subnode of the thermal-zone node. > > + > > +Required properties: > > +- compatible: "marvell,armada-ap806-thermal" > > + > > +Optional properties: > > +- interrupt-parent/interrupts: overheat interrupt handle. Should point to > > + line 18 of the SEI irqchip. > > + See interrupt-controller/interrupts.txt > > +- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer > > + to this IP and represents the channel ID. There is one sensor per > > + channel. O refers to the thermal IP internal channel, while positive > > + IDs refer to each CPU. > > + > > +Example: > > +ap_syscon1: system-controller at 6f8000 { > > + compatible = "syscon", "simple-mfd"; > > + reg = <0x6f8000 0x1000>; > > + > > + ap_thermal: ap-thermal { > > + compatible = "marvell,armada-ap806-thermal"; > > Is there a register range associated with the thermal functions? Yes, I will add it. Thanks, Miqu?l > > > + interrupt-parent = <&sei>; > > + interrupts = <18>; > > + #thermal-sensor-cells = <1>; > > + }; > > +}; > > -- > > 2.14.1 > >