From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 16/27] dt-bindings: cp110: prepare the syscon file to list other syscons nodes Date: Sat, 28 Apr 2018 13:20:21 +0200 Message-ID: <20180428132021.46883eb8@xps13> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> <20180421151255.29929-17-miquel.raynal@bootlin.com> <20180427210603.fkcuxnug3rgq3wjl@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180427210603.fkcuxnug3rgq3wjl@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgUm9iLAoKT24gRnJpLCAyNyBBcHIgMjAxOCAxNjowNjowMyAtMDUwMCwgUm9iIEhlcnJpbmcg PHJvYmhAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFNhdCwgQXByIDIxLCAyMDE4IGF0IDA1OjEy OjQ0UE0gKzAyMDAsIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBUaGVyZSBhcmUgbXVsdGlwbGUg c3lzdGVtIGNvbnRyb2xsZXJzIGluIENQMTEwLiBCZWNhdXNlIGFsbCBzeXNjb24gbm9kZXMKPiA+ IHVzZSB0aGUgc2FtZSBjb21wYXRpYmxlLCBpdCBpcyBwZXJ0aW5lbnQgdG8gdXNlIHRoaXMgc2Ft ZSBmaWxlIHRvIGxpc3QKPiA+IElQcyBpbnNpZGUgaXQuIFRodXMsIGNoYW5nZSB0aGUgaGVhZGVy IHRvIGJlIG1vcmUgZ2VuZXJpYywgYW5kIGFsaWduCj4gPiB3aXRoIEFQODA2IGZpbGUuCj4gPiAK PiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5j b20+Cj4gPiAtLS0KPiA+ICAuLi4vYmluZGluZ3MvYXJtL21hcnZlbGwvY3AxMTAtc3lzdGVtLWNv bnRyb2xsZXIudHh0ICAgICAgIHwgMTQgKysrKysrKy0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdl ZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9tYXJ2ZWxsL2NwMTEwLXN5c3Rl bS1jb250cm9sbGVyLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0v bWFydmVsbC9jcDExMC1zeXN0ZW0tY29udHJvbGxlci50eHQKPiA+IGluZGV4IDI5Y2RiYWU2YzVh Yy4uNTZlN2ZiMTE1M2U3IDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2FybS9tYXJ2ZWxsL2NwMTEwLXN5c3RlbS1jb250cm9sbGVyLnR4dAo+ID4gKysr IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9tYXJ2ZWxsL2NwMTEwLXN5 c3RlbS1jb250cm9sbGVyLnR4dAo+ID4gQEAgLTEsMTUgKzEsMTUgQEAKPiA+IC1NYXJ2ZWxsIEFy bWFkYSBDUDExMCBTeXN0ZW0gQ29udHJvbGxlciAwCj4gPiAtPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQo+ID4gK01hcnZlbGwgQXJtYWRhIENQMTEwIFN5c3RlbSBDb250 cm9sbGVyCj4gPiArPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiA+ICAK PiA+ICBUaGUgQ1AxMTAgaXMgb25lIG9mIHRoZSB0d28gY29yZSBIVyBibG9ja3Mgb2YgdGhlIE1h cnZlbGwgQXJtYWRhIDdLLzhLCj4gPiAtU29Dcy4gSXQgY29udGFpbnMgdHdvIHNldHMgb2Ygc3lz dGVtIGNvbnRyb2wgcmVnaXN0ZXJzLCBTeXN0ZW0KPiA+IC1Db250cm9sbGVyIDAgYW5kIFN5c3Rl bSBDb250cm9sbGVyIDEuIFRoaXMgRGV2aWNlIFRyZWUgYmluZGluZyBhbGxvd3MKPiA+IC10byBk ZXNjcmliZSB0aGUgZmlyc3Qgc3lzdGVtIGNvbnRyb2xsZXIsIHdoaWNoIHByb3ZpZGVzIHJlZ2lz dGVycyB0bwo+ID4gLWNvbmZpZ3VyZSB2YXJpb3VzIGFzcGVjdHMgb2YgdGhlIFNvQy4KPiA+ICtT b0NzLiBJdCBjb250YWlucyBzeXN0ZW0gY29udHJvbGxlcnMsIHdoaWNoIHByb3ZpZGUgc2V2ZXJh bCByZWdpc3RlcnMgIAo+IAo+IElzIHRoaXMgcmVhbGx5IG11bHRpcGxlIGRpc2NyZXRlIGJsb2Nr cz8KCkkgY2FuJ3QgdGVsbCBmb3Igc3VyZSwgYnV0IHRoZSBzcGVjaWZpY2F0aW9uIGNsZWFybHkg bmFtZXMgdGhlCiM2ZjgwMDAtIzZmOTAwMCByZWdpb24gYXMgIkFQIEdlbmVyYWwgTWFuYWdlbWVu dCBSZWdpc3RlcnMiIGFuZCBkb2VzCm5vdCByZWZlciBpbiBhbnkgbWFubmVyIHRvIHRoZSBvdGhl ciAoYWxyZWFkeSBkZXNjcmliZWQpIHN5c2NvbiBhdAojNmY0MDAwLSM2ZjYwMDAgd2hpY2ggaXMg dXNlZCBmb3IgY2xvY2tzIGFuZCBwaW5jdHJsIG1hbmFnZW1lbnQKYWxyZWFkeS4KCj4gCj4gPiAr Z2l2aW5nIGFjY2VzcyB0byBudW1lcm91cyBmZWF0dXJlczogY2xvY2tzLCBwaW4tbXV4aW5nIGFu ZCBtYW55IG90aGVyCj4gPiArU29DIGNvbmZpZ3VyYXRpb24gaXRlbXMuIFRoaXMgRFQgYmluZGlu ZyBhbGxvd3MgdG8gZGVzY3JpYmUgdGhlc2UKPiA+ICtzeXN0ZW0gY29udHJvbGxlcnMuCj4gPiAg Cj4gPiAgRm9yIHRoZSB0b3AgbGV2ZWwgbm9kZToKPiA+ICAgLSBjb21wYXRpYmxlOiBtdXN0IGJl OiAic3lzY29uIiwgInNpbXBsZS1tZmQiOwo+ID4gLSAtIHJlZzogcmVnaXN0ZXIgYXJlYSBvZiB0 aGUgQ1AxMTAgc3lzdGVtIGNvbnRyb2xsZXIgMAo+ID4gKyAtIHJlZzogcmVnaXN0ZXIgYXJlYSBv ZiB0aGUgQ1AxMTAgc3lzdGVtIGNvbnRyb2xsZXIKPiA+ICAKPiA+ICBDbG9ja3M6Cj4gPiAgLS0t LS0tLQo+ID4gLS0gCj4gPiAyLjE0LjEKPiA+ICAgCgpSZWdhcmRzLApNaXF1w6hsCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Sat, 28 Apr 2018 13:20:21 +0200 Subject: [PATCH 16/27] dt-bindings: cp110: prepare the syscon file to list other syscons nodes In-Reply-To: <20180427210603.fkcuxnug3rgq3wjl@rob-hp-laptop> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> <20180421151255.29929-17-miquel.raynal@bootlin.com> <20180427210603.fkcuxnug3rgq3wjl@rob-hp-laptop> Message-ID: <20180428132021.46883eb8@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On Fri, 27 Apr 2018 16:06:03 -0500, Rob Herring wrote: > On Sat, Apr 21, 2018 at 05:12:44PM +0200, Miquel Raynal wrote: > > There are multiple system controllers in CP110. Because all syscon nodes > > use the same compatible, it is pertinent to use this same file to list > > IPs inside it. Thus, change the header to be more generic, and align > > with AP806 file. > > > > Signed-off-by: Miquel Raynal > > --- > > .../bindings/arm/marvell/cp110-system-controller.txt | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt > > index 29cdbae6c5ac..56e7fb1153e7 100644 > > --- a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt > > +++ b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt > > @@ -1,15 +1,15 @@ > > -Marvell Armada CP110 System Controller 0 > > -======================================== > > +Marvell Armada CP110 System Controller > > +====================================== > > > > The CP110 is one of the two core HW blocks of the Marvell Armada 7K/8K > > -SoCs. It contains two sets of system control registers, System > > -Controller 0 and System Controller 1. This Device Tree binding allows > > -to describe the first system controller, which provides registers to > > -configure various aspects of the SoC. > > +SoCs. It contains system controllers, which provide several registers > > Is this really multiple discrete blocks? I can't tell for sure, but the specification clearly names the #6f8000-#6f9000 region as "AP General Management Registers" and does not refer in any manner to the other (already described) syscon at #6f4000-#6f6000 which is used for clocks and pinctrl management already. > > > +giving access to numerous features: clocks, pin-muxing and many other > > +SoC configuration items. This DT binding allows to describe these > > +system controllers. > > > > For the top level node: > > - compatible: must be: "syscon", "simple-mfd"; > > - - reg: register area of the CP110 system controller 0 > > + - reg: register area of the CP110 system controller > > > > Clocks: > > ------- > > -- > > 2.14.1 > > Regards, Miqu?l