From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED From: mdf@kernel.org Message-Id: <20180428195754.3053-1-mdf@kernel.org> Date: Sat, 28 Apr 2018 12:57:54 -0700 To: linux-kernel@vger.kernel.org Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com, lars@metafoo.de, Moritz Fischer List-ID: UmVxdWVzdCBJUlEgd2l0aCBJUlFGX1NIQVJFRCBmbGFnIHRvIGVuYWJsZSBzZXR1cHMgd2l0aCBt dWx0aXBsZQppbnN0YW5jZXMgb2YgdGhlIGNvcmUgc2hhcmluZyBhIHNpbmdsZSBJUlEgbGluZS4K VGhpcyB3b3JrcyBvdXQgc2luY2UgdGhlIElSUSBoYW5kbGVyIGFscmVhZHkgY2hlY2tzIGlmIHRo ZXJlIGlzCmFuIGFjdHVhbCBJUlEgcGVuZGluZyBhbmQgcmV0dXJucyBJUlFfTk9ORSBvdGhlcndp c2UuCgpBY2tlZC1ieTogTGFycy1QZXRlciBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+ClNpZ25l ZC1vZmYtYnk6IE1vcml0eiBGaXNjaGVyIDxtZGZAa2VybmVsLm9yZz4KLS0tCgpDaGFuZ2VzIGZy b20gdjI6Ci0gUmV3b3JkZWQgY29tbWl0IG1lc3NhZ2UKCkNoYW5nZXMgZnJvbSB2MToKLSBBZGRl ZCBMYXJzJyBBY2tlZC1ieQotIERyb3BwZWQgcGF0Y2ggWzEvMl0gYW5kIGNoYW5nZWQgYWNjb3Jk aW5nbHkKCi0tLQogZHJpdmVycy9kbWEvZG1hLWF4aS1kbWFjLmMgfCAyICstCiAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJz L2RtYS9kbWEtYXhpLWRtYWMuYyBiL2RyaXZlcnMvZG1hL2RtYS1heGktZG1hYy5jCmluZGV4IDI0 MTlmZTUyNGRhYS4uMTViMjQ1M2QyNjQ3IDEwMDY0NAotLS0gYS9kcml2ZXJzL2RtYS9kbWEtYXhp LWRtYWMuYworKysgYi9kcml2ZXJzL2RtYS9kbWEtYXhpLWRtYWMuYwpAQCAtNjg3LDcgKzY4Nyw3 IEBAIHN0YXRpYyBpbnQgYXhpX2RtYWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKIAlpZiAocmV0KQogCQlnb3RvIGVycl91bnJlZ2lzdGVyX2RldmljZTsKIAotCXJldCA9IHJl cXVlc3RfaXJxKGRtYWMtPmlycSwgYXhpX2RtYWNfaW50ZXJydXB0X2hhbmRsZXIsIDAsCisJcmV0 ID0gcmVxdWVzdF9pcnEoZG1hYy0+aXJxLCBheGlfZG1hY19pbnRlcnJ1cHRfaGFuZGxlciwgSVJR Rl9TSEFSRUQsCiAJCWRldl9uYW1lKCZwZGV2LT5kZXYpLCBkbWFjKTsKIAlpZiAocmV0KQogCQln b3RvIGVycl91bnJlZ2lzdGVyX29mOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbeD1UFG (ORCPT ); Sat, 28 Apr 2018 16:05:06 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:41914 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbeD1UFF (ORCPT ); Sat, 28 Apr 2018 16:05:05 -0400 X-Google-Smtp-Source: AB8JxZqTswvteeOhOQaoE6Ja8hZ/a6rKBxAvPvrUJ3uY6rok4irs1BWNw9A6trtcCL+hOgRzS3Z4dQ== From: Moritz Fischer To: linux-kernel@vger.kernel.org Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com, lars@metafoo.de, Moritz Fischer Subject: [PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Date: Sat, 28 Apr 2018 12:57:54 -0700 Message-Id: <20180428195754.3053-1-mdf@kernel.org> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Request IRQ with IRQF_SHARED flag to enable setups with multiple instances of the core sharing a single IRQ line. This works out since the IRQ handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Acked-by: Lars-Peter Clausen Signed-off-by: Moritz Fischer --- Changes from v2: - Reworded commit message Changes from v1: - Added Lars' Acked-by - Dropped patch [1/2] and changed accordingly --- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index 2419fe524daa..15b2453d2647 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev) if (ret) goto err_unregister_device; - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0, + ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED, dev_name(&pdev->dev), dmac); if (ret) goto err_unregister_of; -- 2.17.0