From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from userp2130.oracle.com ([156.151.31.86]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fCycI-0006zc-26 for speck@linutronix.de; Mon, 30 Apr 2018 04:32:38 +0200 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3U2VTUE157639 for ; Mon, 30 Apr 2018 02:32:31 GMT Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2hmgdjac19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 30 Apr 2018 02:32:31 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3U2WUTP025999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 30 Apr 2018 02:32:30 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w3U2WUsO019136 for ; Mon, 30 Apr 2018 02:32:30 GMT Date: Sun, 29 Apr 2018 22:32:29 -0400 From: Konrad Rzeszutek Wilk Subject: [MODERATED] Re: [patch V7 15/15] SBB 15 Message-ID: <20180430023229.GC30984@char.us.oracle.com> References: <20180429193045.711908246@linutronix.de> <20180429193938.717571156@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20180429193938.717571156@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > +static int sbb_prctl_set(unsigned long ctrl) > +{ > + bool rds = !!test_tsk_thread_flag(current, TIF_RDS); > + > + if (ssb_mode != SPEC_STORE_BYPASS_PRCTL) > + return -ENXIO; > + > + if (ctrl == PR_SPEC_ENABLE) > + clear_tsk_thread_flag(current, TIF_RDS); > + else > + set_tsk_thread_flag(current, TIF_RDS); > + > + if (rds != !!test_tsk_thread_flag(current, TIF_RDS)) > + speculative_store_bypass_update(); I would have added an \n here, but you the boss so if you prefer them this way that is cool too. Either way: Reviewed-by: Konrad Rzeszutek Wilk