From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1 Date: Mon, 30 Apr 2018 10:54:15 +0100 Message-ID: <20180430095415.GB5147@dell> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-4-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F02C89FBC for ; Mon, 30 Apr 2018 09:54:19 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id o78so13308188wmg.0 for ; Mon, 30 Apr 2018 02:54:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180425174253.4616-4-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , gregkh@linuxfoundation.org Cc: Thomas Petazzoni , Daniel Thompson , Jingoo Han , LKML , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org R3JlZywgVGhvbWFzLAoKT24gV2VkLCAyNSBBcHIgMjAxOCwgRGFuaWVsIFZldHRlciB3cm90ZToK PiBMZWFraW5nIGRyaXZlciBpbnRlcm5hbCB0cmFja2luZyBpbnRvIHRoZSBhbHJlYWR5IG1hc3Np dmVseSBjb25mdXNpbmcKPiBiYWNrbGlnaHQgcG93ZXIgdHJhY2tpbmcgaXMgcmVhbGx5IGNvbmZ1 c2luZy4KPiAKPiBMdWNraWx5IHdlIGhhdmUgYWxyZWFkeSBhIGRydmRhdGEgc3RydWN0dXJlLCBz byBmaXhpbmcgdGhpcyBpcyByZWFsbHkKPiBlYXN5Lgo+IAo+IENjOiBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBs aW5hcm8ub3JnPgo+IENjOiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPiBDYzog VGhvbWFzIFBldGF6em9uaSA8dGhvbWFzLnBldGF6em9uaUBmcmVlLWVsZWN0cm9ucy5jb20+Cj4g QWNrZWQtYnk6IERhbmllbCBUaG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4g U2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvc3RhZ2luZy9mYnRmdC9mYnRmdC1jb3JlLmMgfCA0ICsrLS0KPiAgZHJp dmVycy9zdGFnaW5nL2ZidGZ0L2ZidGZ0LmggICAgICB8IDEgKwo+ICAyIGZpbGVzIGNoYW5nZWQs IDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCkRvIHlvdSB3YW50IGEgcHVsbC1yZXF1 ZXN0IGZvciB0aGlzIHBhdGNoIG9yIGNhbiBJIGp1c3QgdGFrZSBpdD8KCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvc3RhZ2luZy9mYnRmdC9mYnRmdC1jb3JlLmMgYi9kcml2ZXJzL3N0YWdpbmcvZmJ0 ZnQvZmJ0ZnQtY29yZS5jCj4gaW5kZXggMGUzNmI2NmFlNWY3Li43MzFlNDcxNDlhZjggMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9zdGFnaW5nL2ZidGZ0L2ZidGZ0LWNvcmUuYwo+ICsrKyBiL2RyaXZl cnMvc3RhZ2luZy9mYnRmdC9mYnRmdC1jb3JlLmMKPiBAQCAtMjQ2LDcgKzI0Niw3IEBAIHN0YXRp YyBpbnQgZmJ0ZnRfcmVxdWVzdF9ncGlvc19kdChzdHJ1Y3QgZmJ0ZnRfcGFyICpwYXIpCj4gIHN0 YXRpYyBpbnQgZmJ0ZnRfYmFja2xpZ2h0X3VwZGF0ZV9zdGF0dXMoc3RydWN0IGJhY2tsaWdodF9k ZXZpY2UgKmJkKQo+ICB7Cj4gIAlzdHJ1Y3QgZmJ0ZnRfcGFyICpwYXIgPSBibF9nZXRfZGF0YShi ZCk7Cj4gLQlib29sIHBvbGFyaXR5ID0gISEoYmQtPnByb3BzLnN0YXRlICYgQkxfQ09SRV9EUklW RVIxKTsKPiArCWJvb2wgcG9sYXJpdHkgPSBwYXItPnBvbGFyaXR5Owo+ICAKPiAgCWZidGZ0X3Bh cl9kYmcoREVCVUdfQkFDS0xJR0hULCBwYXIsCj4gIAkJIiVzOiBwb2xhcml0eT0lZCwgcG93ZXI9 JWQsIGZiX2JsYW5rPSVkXG4iLAo+IEBAIC0yOTYsNyArMjk2LDcgQEAgdm9pZCBmYnRmdF9yZWdp c3Rlcl9iYWNrbGlnaHQoc3RydWN0IGZidGZ0X3BhciAqcGFyKQo+ICAJLyogQXNzdW1lIGJhY2ts aWdodCBpcyBvZmYsIGdldCBwb2xhcml0eSBmcm9tIGN1cnJlbnQgc3RhdGUgb2YgcGluICovCj4g IAlibF9wcm9wcy5wb3dlciA9IEZCX0JMQU5LX1BPV0VSRE9XTjsKPiAgCWlmICghZ3Bpb19nZXRf dmFsdWUocGFyLT5ncGlvLmxlZFswXSkpCj4gLQkJYmxfcHJvcHMuc3RhdGUgfD0gQkxfQ09SRV9E UklWRVIxOwo+ICsJCXBhci0+cG9sYXJpdHkgPSB0cnVlOwo+ICAKPiAgCWJkID0gYmFja2xpZ2h0 X2RldmljZV9yZWdpc3RlcihkZXZfZHJpdmVyX3N0cmluZyhwYXItPmluZm8tPmRldmljZSksCj4g IAkJCQkgICAgICAgcGFyLT5pbmZvLT5kZXZpY2UsIHBhciwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9zdGFnaW5nL2ZidGZ0L2ZidGZ0LmggYi9kcml2ZXJzL3N0YWdpbmcvZmJ0ZnQvZmJ0ZnQuaAo+ IGluZGV4IGUxOWU2NGUwZDA5NC4uYzdjYjRhNzg5NmY0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv c3RhZ2luZy9mYnRmdC9mYnRmdC5oCj4gKysrIGIvZHJpdmVycy9zdGFnaW5nL2ZidGZ0L2ZidGZ0 LmgKPiBAQCAtMjI5LDYgKzIyOSw3IEBAIHN0cnVjdCBmYnRmdF9wYXIgewo+ICAJa3RpbWVfdCB1 cGRhdGVfdGltZTsKPiAgCWJvb2wgYmdyOwo+ICAJdm9pZCAqZXh0cmE7Cj4gKwlib29sIHBvbGFy aXR5Owo+ICB9Owo+ICAKPiAgI2RlZmluZSBOVU1BUkdTKC4uLikgIChzaXplb2YoKGludFtdKXtf X1ZBX0FSR1NfX30pL3NpemVvZihpbnQpKQoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpMaW5h cm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29m dHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJs b2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1525082058; cv=none; d=google.com; s=arc-20160816; b=pYvJxtvNca/Lf6mWRTvg/tUjE6+DFm9MIMBLjgtDmSm+UirT967SscvGbSVX50pZGO 9lhTN8JIhccVbhRYpxDP8J3WwL2mjdJNsD+O3frf6H2AWv4DaNhswsEEalBv4iB0c3mt AGHosjuDq9y3Qbk3W1gyXojF7mkQP0v4DGCz8sWv4h/HRA0d45Pz+DLA+4q/3KK5GzGa jFg9Ng5XFx5lJUj3Aj+C/IkqrhZN7zCYQn8DAN/HP6gBrMOgf26rW0dsSu/cFdG2LUOn ONKn+StCOJGkLFd/JUhuyUxprOQCGvScNl7fDmHyFSSltdGt99jlbrVzzAqL9cAlwLde FvyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=tnfa2ji37OGEt41BnhHgOgenHFOUinkDkNCJvR7IrWU=; b=hOn3yKpodBrZFB2mNp1TTtoXURwwHFuvI8nEfWIDWnk4gQVaQFOf8rzgNDJCpb+YuO sb+yeBSklvl1KN8rGmBkA5JydzQBnyVvhR1mi/gGHtvQhk6BJlGtbKyhx+e6rjW1q0tf yAr8Z8jtvVT+UdH9UYKuUi57u4cvC09GJHI5bevzZZTbVozWxGWFj2a+Yb/H6TAex7iE DlfcjE9qDBtaZdMX98b0bTyRn0+EtEGQw4n/gBiVHWi60dKqw4AYx+YKS62qns/+6F0l 8mh30Jzi4V5e9kLzSN0KPcLw1ps4BQgacwyPS173eaPL6KGlKnHV4OliijaRnojxRD6x BD+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NThekE52; spf=pass (google.com: domain of lee.jones@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=lee.jones@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NThekE52; spf=pass (google.com: domain of lee.jones@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=lee.jones@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Google-Smtp-Source: AB8JxZo+u3VWbk7asqJVkVOUjP0/cQ3MN0cTpRCq9IEzaEYkuSIU70cXqC1G8aMbGMrNnvRHbqCvdg== Date: Mon, 30 Apr 2018 10:54:15 +0100 From: Lee Jones To: Daniel Vetter , gregkh@linuxfoundation.org, thomas.petazzoni@free-electrons.com Cc: DRI Development , LKML , Daniel Thompson , Jingoo Han , Thomas Petazzoni , Daniel Vetter Subject: Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1 Message-ID: <20180430095415.GB5147@dell> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-4-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180425174253.4616-4-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.9.4 (2018-02-28) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1599164444626352562?= X-GMAIL-MSGID: =?utf-8?q?1599164444626352562?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Greg, Thomas, On Wed, 25 Apr 2018, Daniel Vetter wrote: > Leaking driver internal tracking into the already massively confusing > backlight power tracking is really confusing. > > Luckily we have already a drvdata structure, so fixing this is really > easy. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Thomas Petazzoni > Acked-by: Daniel Thompson > Signed-off-by: Daniel Vetter > --- > drivers/staging/fbtft/fbtft-core.c | 4 ++-- > drivers/staging/fbtft/fbtft.h | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) Do you want a pull-request for this patch or can I just take it? > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index 0e36b66ae5f7..731e47149af8 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -246,7 +246,7 @@ static int fbtft_request_gpios_dt(struct fbtft_par *par) > static int fbtft_backlight_update_status(struct backlight_device *bd) > { > struct fbtft_par *par = bl_get_data(bd); > - bool polarity = !!(bd->props.state & BL_CORE_DRIVER1); > + bool polarity = par->polarity; > > fbtft_par_dbg(DEBUG_BACKLIGHT, par, > "%s: polarity=%d, power=%d, fb_blank=%d\n", > @@ -296,7 +296,7 @@ void fbtft_register_backlight(struct fbtft_par *par) > /* Assume backlight is off, get polarity from current state of pin */ > bl_props.power = FB_BLANK_POWERDOWN; > if (!gpio_get_value(par->gpio.led[0])) > - bl_props.state |= BL_CORE_DRIVER1; > + par->polarity = true; > > bd = backlight_device_register(dev_driver_string(par->info->device), > par->info->device, par, > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h > index e19e64e0d094..c7cb4a7896f4 100644 > --- a/drivers/staging/fbtft/fbtft.h > +++ b/drivers/staging/fbtft/fbtft.h > @@ -229,6 +229,7 @@ struct fbtft_par { > ktime_t update_time; > bool bgr; > void *extra; > + bool polarity; > }; > > #define NUMARGS(...) (sizeof((int[]){__VA_ARGS__})/sizeof(int)) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog