[Buildroot] [PATCH v6 2/4] package/libclc: new package

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello,

On Mon, 30 Apr 2018 09:54:10 +0200, Valentin Korenblit wrote:

> >> diff --git a/package/libclc/Config.in b/package/libclc/Config.in
> >> new file mode 100644
> >> index 0000000000..a0f388c4e1
> >> --- /dev/null
> >> +++ b/package/libclc/Config.in
> >> @@ -0,0 +1,22 @@
> >> +config BR2_PACKAGE_LIBCLC
> >> +	bool "libclc"
> >> +	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
> >> +	depends on BR2_HOST_GCC_AT_LEAST_4_8
> >> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> >> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> >> +	depends on BR2_INSTALL_LIBSTDCPP
> >> +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
> >> +	depends on !BR2_STATIC_LIBS
> >> +	depends on BR2_USE_WCHAR # std::wstring  
> > You seem to have replicated here all the dependencies of the target
> > LLVM package. However, you only depend on host-llvm and host-clang. Are
> > you sure all those dependencies are needed by libclc ?  
> 
> Actually, it wouldn't make sense to have libclc without target LLVM, but it
> is true that it is not a build dependency, so I'll remove them.

Is target LLVM a runtime dependency for libclc ? Could you explain a
bit the interaction between libclc and target LLVM, so that we can
decide what is the best way to express this dependency ?

> >> +# C++ compiler is used to build a small tool (prepare-builtins) for the host.
> >> +# It must be built with the C++ compiler from the host
> >> +LIBCLC_CONF_OPTS = --with-llvm-config=$(HOST_DIR)/usr/bin/llvm-config \
> >> +	--prefix="/usr" \
> >> +	--includedir="/usr/local/include" \  
> > I'm not a big fan of /usr/local/include. Perhaps we should use
> > something really special like /usr/share/libclc/ or something like
> > this ?  
> 
> Perfect, I'll change it to that directory

Thanks!

> >> +	--pkgconfigdir="/usr/lib/pkgconfig" \
> >> +	--with-cxx-compiler=$(HOSTCXX)  
> > Weird for a target package to use the host compiler, no ?  
> 
> Yes, it is used only in the target utils/prepare-builtins.o, all the
> other stuff is compiled with host-clang.

OK.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com