From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Date: Mon, 30 Apr 2018 13:14:59 +0100 Message-ID: <20180430121459.GF5147@dell> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-5-daniel.vetter@ffwll.ch> <87d0yh9elr.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC8246E0F5 for ; Mon, 30 Apr 2018 12:15:03 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id x12so11189006wmc.0 for ; Mon, 30 Apr 2018 05:15:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87d0yh9elr.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Daniel Thompson , Jingoo Han , LKML , DRI Development , Daniel Vetter , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAzMCBBcHIgMjAxOCwgSmFuaSBOaWt1bGEgd3JvdGU6Cgo+IE9uIFdlZCwgMjUgQXBy IDIwMTgsIERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+IHdyb3RlOgo+ID4g Tm93IHRoYXQgdGhlIDMgZHJpdmVycyB1c2luZyB0aGlzIGFyZSBjbGVhbmVkIHVwIHdlIGNhbiBh bHNvIHJlbW92ZQo+ID4gdGhpcyBmaW5hbCBiaXQgb2YgY29uZnVzaW9uIG9mIGxlYWtpbmcgZHJp dmVyIGludGVybmFscyBpbnRvIHRoZQo+ID4gYmFja2xpZ2h0IHBvd2VyIGludGVyZmFjZS4KPiA+ Cj4gPiBUaGUgYmFja2xpZ2h0IHBvd2VyIGludGVyZmFjZSBpdHNlbGYgaXMgc3RpbGwgYSBtYXNz aXZlIG1lc3MuCj4gPgo+ID4gQ2M6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4g PiBDYzogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJvLm9yZz4KPiA+IENj OiBKaW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KPiA+IEFja2VkLWJ5OiBEYW5pZWwg VGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBpbmNs dWRlL2xpbnV4L2JhY2tsaWdodC5oIHwgMSAtCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRp b24oLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaCBiL2lu Y2x1ZGUvbGludXgvYmFja2xpZ2h0LmgKPiA+IGluZGV4IDFkYjY3NjYyYmZjYi4uN2ZiZjA1Mzll MTRhIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaAo+ID4gKysrIGIv aW5jbHVkZS9saW51eC9iYWNrbGlnaHQuaAo+ID4gQEAgLTg0LDcgKzg0LDYgQEAgc3RydWN0IGJh Y2tsaWdodF9wcm9wZXJ0aWVzIHsKPiA+ICAKPiA+ICAjZGVmaW5lIEJMX0NPUkVfU1VTUEVOREVE CSgxIDw8IDApCS8qIGJhY2tsaWdodCBpcyBzdXNwZW5kZWQgKi8KPiA+ICAjZGVmaW5lIEJMX0NP UkVfRkJCTEFOSwkJKDEgPDwgMSkJLyogYmFja2xpZ2h0IGlzIHVuZGVyIGFuIGZiIGJsYW5rIGV2 ZW50ICovCj4gPiAtI2RlZmluZSBCTF9DT1JFX0RSSVZFUjEJCSgxIDw8IDMxKQkvKiByZXNlcnZl ZCBmb3IgZHJpdmVyIHNwZWNpZmljIHVzZSAqLwo+IAo+IFBsZWFzZSBhbHNvIHJlbW92ZSB0aGUK PiAKPiAJLyogVXBwZXIgNCBiaXRzIGFyZSByZXNlcnZlZCBmb3IgZHJpdmVyIGludGVybmFsIHVz ZSAqLwo+IAo+IGNvbW1lbnQgYSBmZXcgbGluZXMgdXAgdG8gbm90IGdpdmUgYW55b25lIGlkZWFz Lgo+IAo+IFdpdGggdGhhdCwKPiAKPiBSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlr dWxhQGludGVsLmNvbT4KCkknbSBtZXJnaW5nIHRoZXNlIHBhdGNoZXMgKHdpdGggSmFuaSdzIEFj a3MpIG5vdy4KClBsZWFzZSBzZW5kIHRoaXMgcmVxdWVzdCBhcyBhIHN1YnNlcXVlbnQgcGF0Y2gu CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVh ZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93 IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbeD3MPE (ORCPT ); Mon, 30 Apr 2018 08:15:04 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34140 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbeD3MPD (ORCPT ); Mon, 30 Apr 2018 08:15:03 -0400 X-Google-Smtp-Source: AB8JxZr+dWC7fHrLBB9LSN4xStCq1UQ63QHDXKGLJtyTKSvluIf7c+D0yIUqv3jLPWuvCMZUxfGoYg== Date: Mon, 30 Apr 2018 13:14:59 +0100 From: Lee Jones To: Jani Nikula Cc: Daniel Vetter , DRI Development , LKML , Daniel Vetter , Daniel Thompson , Jingoo Han Subject: Re: [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Message-ID: <20180430121459.GF5147@dell> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-5-daniel.vetter@ffwll.ch> <87d0yh9elr.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d0yh9elr.fsf@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Apr 2018, Jani Nikula wrote: > On Wed, 25 Apr 2018, Daniel Vetter wrote: > > Now that the 3 drivers using this are cleaned up we can also remove > > this final bit of confusion of leaking driver internals into the > > backlight power interface. > > > > The backlight power interface itself is still a massive mess. > > > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Acked-by: Daniel Thompson > > Signed-off-by: Daniel Vetter > > --- > > include/linux/backlight.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > > index 1db67662bfcb..7fbf0539e14a 100644 > > --- a/include/linux/backlight.h > > +++ b/include/linux/backlight.h > > @@ -84,7 +84,6 @@ struct backlight_properties { > > > > #define BL_CORE_SUSPENDED (1 << 0) /* backlight is suspended */ > > #define BL_CORE_FBBLANK (1 << 1) /* backlight is under an fb blank event */ > > -#define BL_CORE_DRIVER1 (1 << 31) /* reserved for driver specific use */ > > Please also remove the > > /* Upper 4 bits are reserved for driver internal use */ > > comment a few lines up to not give anyone ideas. > > With that, > > Reviewed-by: Jani Nikula I'm merging these patches (with Jani's Acks) now. Please send this request as a subsequent patch. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog