From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states Date: Mon, 30 Apr 2018 13:27:12 +0100 Message-ID: <20180430122712.GG5147@dell> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B5956E105 for ; Mon, 30 Apr 2018 12:27:16 +0000 (UTC) Received: by mail-wm0-x233.google.com with SMTP id a8so12842599wmg.5 for ; Mon, 30 Apr 2018 05:27:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180425174253.4616-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Thompson , Jingoo Han , LKML , DRI Development , Meghana Madhyastha , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNSBBcHIgMjAxOCwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gVGhlIGJhY2tsaWdo dCBwb3dlciBzdGF0ZSBoYW5kbGluZyBpcyBzdXByZW1lbHkgY29uZnVzaW5nLiBXZSBoYXZlOgo+ IC0gcHJvcHMucG93ZXIsIHVzaW5nIEZCX0JMQU5LXyogZGVmaW5lcwo+IC0gcHJvcHMuZmJfYmxh bmssIHVzaW5nIHRoZSBzYW1lLCBidXQgZGVwcmVjYXRlZCBpbnQgZmF2b3VyIG9mCj4gICBwcm9w cy5zdGF0ZQo+IC0gcHJvcHMuc3RhdGUsIHVzaW5nIHRoZSBCTF9DT1JFXyogZGVmaW5lcwo+IC0g YW5kIGZpbmFsbHkgYSBidW5jaCBvZiBiYWNrbGlnaHQgZHJpdmVycyB0cmVhdCBicmlnaHRuZXNz ID09IDAgYXMKPiAgIG9mZi4gQnV0IG9mIGNvdXJzZSBub3QgYWxsIG9mIHRoZW0uCj4gCj4gVGhp cyBpcyB3YXkgdG9vIG11Y2ggY29uZnVzaW9uIHRvIGZpeCBpbiBhIHNpbXBsZSBwYXRjaCwgYnV0 IGF0IGxlYXN0Cj4gcHJldmVudCBtb3JlIGhpbGFyaXR5IGZyb20gc3ByZWFkaW5nIGJ5IHJlbW92 aW5nIHRoZSB1bnVzZWQgQkxfQ09SRV8qCj4gZGVmaW5lcy4gSSBoYXZlIG5vIGlkZWEgd2h5IGV4 YWN0bHkgYW55b25lIHdvdWxkIG5lZWQgdGhhdC4KPiAKPiBXcnQgdGhlIGlkZWFsIHN0YXRlLCB3 ZSByZWFsbHkganVzdCB3YW50IGEgYm9vbGVhbiBzdGF0ZS4gVGhlIDQgcG93ZXIKPiBzYXZpbmcg c3RhdGVzIHRoYXQgdGhlIGZiZGV2IHN1YnN5c3RlbSB1c2VzIGFyZSBvdmVya2lsbCBpbiB0b2Rh eXMgaHcKPiAodGhpcyB3YXMgb25seSByZWxldmFudCBmb3IgVkdBIGFuZCBzaW1pbGFyIGFuYWxv ZyBjaXJjdWl0cyBsaWtlCj4gVFYtb3V0KSwgdGhlIG5ldyBkcm0gYXRvbWljIG1vZGVzZXQgYXBp IHNpbXBsaWZpZWQgZXZlbiB0aGUgdWFwaSB0byBhCj4gc2ltcGxlIGJvb2wuIEFuZCB0aGVyZSB3 YXMgbmV2ZXIgYSB2YWxpZCB0ZWNobmljYWwgcmVhc29uIHRvIGhhdmUgdGhlCj4gaW50ZXJtZWRp YXRlIGZiZGV2IHBvd2VyIHN0YXRlcyBmb3IgYmFja2xpZ2h0cyAodGhvc2UgcmVhbGx5IG9ubHkg Y2FuCj4gYmUgZWl0aGVyIG9mZiBvciBvbikuCj4gCj4gQ2xlYW51cCBtb3RpdmF0ZWQgYnkgTWVn aGFuYSdzIHF1ZXN0aW9ucyBhYm91dCBhbGwgdGhpcy4KCkFsbCBhcHBsaWVkLCB0aGFua3MuCgot LSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExp bmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbeD3M1R (ORCPT ); Mon, 30 Apr 2018 08:27:17 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:51038 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbeD3M1Q (ORCPT ); Mon, 30 Apr 2018 08:27:16 -0400 X-Google-Smtp-Source: AB8JxZqlgKpzadGBGDZs/5qtd26IR288QdlE/YuaamEEXzf0Hn+51ZDntG9B5YIszpVK7IINWcM10Q== Date: Mon, 30 Apr 2018 13:27:12 +0100 From: Lee Jones To: Daniel Vetter Cc: DRI Development , LKML , Daniel Thompson , Jingoo Han , Meghana Madhyastha , Daniel Vetter Subject: Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states Message-ID: <20180430122712.GG5147@dell> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180425174253.4616-1-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Apr 2018, Daniel Vetter wrote: > The backlight power state handling is supremely confusing. We have: > - props.power, using FB_BLANK_* defines > - props.fb_blank, using the same, but deprecated int favour of > props.state > - props.state, using the BL_CORE_* defines > - and finally a bunch of backlight drivers treat brightness == 0 as > off. But of course not all of them. > > This is way too much confusion to fix in a simple patch, but at least > prevent more hilarity from spreading by removing the unused BL_CORE_* > defines. I have no idea why exactly anyone would need that. > > Wrt the ideal state, we really just want a boolean state. The 4 power > saving states that the fbdev subsystem uses are overkill in todays hw > (this was only relevant for VGA and similar analog circuits like > TV-out), the new drm atomic modeset api simplified even the uapi to a > simple bool. And there was never a valid technical reason to have the > intermediate fbdev power states for backlights (those really only can > be either off or on). > > Cleanup motivated by Meghana's questions about all this. All applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog