From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH v2] drm/i915: Disable some extra clang warnings Date: Mon, 30 Apr 2018 12:31:19 -0700 Message-ID: <20180430193119.GB133494@google.com> References: <20180319191451.83910-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180319191451.83910-1-mka@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: Guenter Roeck , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBNYXIgMTksIDIwMTggYXQgMTI6MTQ6NTFQTSAtMDcwMCwgTWF0dGhpYXMgS2FlaGxj a2Ugd3JvdGU6Cj4gQ29tbWl0IDM5YmY0ZGU4OWZmNyAoImRybS9pOTE1OiBBZGQgLVdhbGwgLVdl eHRyYSB0byBvdXIgYnVpbGQsIHNldAo+IHdhcm5pbmdzIHRvIGZ1bGwiKSBlbmFibGVkIGV4dHJh IHdhcm5pbmdzIGZvciBpOTE1IHRvIHNwb3QgcG9zc2libGUKPiBidWdzIGluIG5ldyBjb2RlLCBh bmQgdGhlbiBkaXNhYmxlZCBhIHN1YnNldCBvZiB0aGVzZSB3YXJuaW5ncyB0byBrZWVwCj4gdGhl IGN1cnJlbnQgY29kZSBidWlsZGluZyB3aXRob3V0IHdhcm5pbmdzICh3aXRoIGdjYykuIEVuYWJs aW5nIHRoZQo+IGV4dHJhIHdhcm5pbmdzIGFsc28gZW5hYmxlZCBzb21lIGFkZGl0aW9uYWwgY2xh bmctb25seSB3YXJuaW5ncywgYXMgYQo+IHJlc3VsdCBidWlsZGluZyBpOTE1IHdpdGggY2xhbmcg Y3VycmVudGx5IGlzIGV4dHJlbWVseSBub2lzeS4gRm9yIG5vdwo+IGFsc28gZGlzYWJsZSB0aGUg Y2xhbmcgd2FybmluZ3Mgc2lnbi1jb21wYXJlLCBzb21ldGltZXMtdW5pbml0aWFsaXplZCwKPiB1 bm5lZWRlZC1pbnRlcm5hbC1kZWNsYXJhdGlvbiBhbmQgaW5pdGlhbGl6ZXItb3ZlcnJpZGVzLiBJ ZiBkZXNpcmVkCj4gdGhleSBjYW4gYmUgcmUtZW5hYmxlZCBhZnRlciB0aGUgY29kZSBoYXMgYmVl biBmaXhlZC4KPiAKPiBGaXhlczogMzliZjRkZTg5ZmY3ICgiZHJtL2k5MTU6IEFkZCAtV2FsbCAt V2V4dHJhIHRvIG91ciBidWlsZCwgc2V0Cj4gd2FybmluZ3MgdG8gZnVsbCIpCj4gU2lnbmVkLW9m Zi1ieTogTWF0dGhpYXMgS2FlaGxja2UgPG1rYUBjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gQ2hhbmdl cyBpbiB2MjoKPiAtIHJlYmFzZWQgb24gZHJtLXRpcAo+IC0gYWRkZWQgY29tbWVudCBpbmRpY2F0 aW5nIHRoYXQgZGlzYWJsZWQgd2FybmluZ3MgYXJlIGNsYW5nIHdhcm5pbmdzCj4gCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlIHwgNSArKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2Vm aWxlIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvTWFrZWZpbGUKPiBpbmRleCA0ZWVlOTFhM2EyMzYu Ljk3MTdjMDM3YjU4MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmls ZQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlCj4gQEAgLTE4LDYgKzE4LDEx IEBAIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgdHlwZS1s aW1pdHMpCj4gIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywg bWlzc2luZy1maWVsZC1pbml0aWFsaXplcnMpCj4gIHN1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxs IGNjLWRpc2FibGUtd2FybmluZywgaW1wbGljaXQtZmFsbHRocm91Z2gpCj4gIHN1YmRpci1jY2Zs YWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgdW51c2VkLWJ1dC1zZXQtdmFyaWFi bGUpCj4gKyMgY2xhbmcgd2FybmluZ3MKPiArc3ViZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2Mt ZGlzYWJsZS13YXJuaW5nLCBzaWduLWNvbXBhcmUpCj4gK3N1YmRpci1jY2ZsYWdzLXkgKz0gJChj YWxsIGNjLWRpc2FibGUtd2FybmluZywgc29tZXRpbWVzLXVuaW5pdGlhbGl6ZWQpCj4gK3N1YmRp ci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgdW5uZWVkZWQtaW50ZXJu YWwtZGVjbGFyYXRpb24pCj4gK3N1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUt d2FybmluZywgaW5pdGlhbGl6ZXItb3ZlcnJpZGVzKQo+ICBzdWJkaXItY2NmbGFncy0kKENPTkZJ R19EUk1fSTkxNV9XRVJST1IpICs9IC1XZXJyb3IKPiAgCj4gICMgRmluZSBncmFpbmVkIHdhcm5p bmdzIGRpc2FibGUKClBpbmcsIGl0IHNlZW1zIHRoaXMgb25lIHN3ZXB0IHVuZGVyIHRoZSByYWRh cgoKVGhhbmtzCgpNYXR0aGlhcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756528AbeD3TbZ (ORCPT ); Mon, 30 Apr 2018 15:31:25 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:38882 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755890AbeD3TbV (ORCPT ); Mon, 30 Apr 2018 15:31:21 -0400 X-Google-Smtp-Source: AB8JxZpRSGeLdkYk+M+tc3kYAqenAs0IgXKk4lOXStr54Zatq8zHuuVf3iLgw/H44feogbML598hjQ== Date: Mon, 30 Apr 2018 12:31:19 -0700 From: Matthias Kaehlcke To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: Re: [PATCH v2] drm/i915: Disable some extra clang warnings Message-ID: <20180430193119.GB133494@google.com> References: <20180319191451.83910-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180319191451.83910-1-mka@chromium.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep > the current code building without warnings (with gcc). Enabling the > extra warnings also enabled some additional clang-only warnings, as a > result building i915 with clang currently is extremely noisy. For now > also disable the clang warnings sign-compare, sometimes-uninitialized, > unneeded-internal-declaration and initializer-overrides. If desired > they can be re-enabled after the code has been fixed. > > Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") > Signed-off-by: Matthias Kaehlcke > --- > Changes in v2: > - rebased on drm-tip > - added comment indicating that disabled warnings are clang warnings > > drivers/gpu/drm/i915/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 4eee91a3a236..9717c037b582 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -18,6 +18,11 @@ subdir-ccflags-y += $(call cc-disable-warning, type-limits) > subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) > subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) > subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable) > +# clang warnings > +subdir-ccflags-y += $(call cc-disable-warning, sign-compare) > +subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized) > +subdir-ccflags-y += $(call cc-disable-warning, unneeded-internal-declaration) > +subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides) > subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror > > # Fine grained warnings disable Ping, it seems this one swept under the radar Thanks Matthias