From: Borislav Petkov <bp@alien8.de>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/6] x86/microcode/AMD: Check microcode container data in the late loader
Date: Tue, 1 May 2018 10:43:17 +0200 [thread overview]
Message-ID: <20180501084317.GC31863@pd.tnic> (raw)
In-Reply-To: <bce73502-0d18-e50c-b78b-8159dc9f8f66@maciej.szmigiero.name>
On Tue, May 01, 2018 at 12:27:51AM +0200, Maciej S. Szmigiero wrote:
> 1) -EINVAL maps to a valid return value of 4294967274 bytes.
> We have a different behavior for invalid data in the container file
> (including too large lengths) than for grave errors like a failed memory
> allocation.
WTF?
> 2) This function single caller (__load_microcode_amd()) normalized any
> error that verify_and_add_patch() returned to UCODE_ERROR anyway,
So?
> 3) The existing code uses a convention that zero return value means
> 'terminate processing' for the parse_container() function in the early
> loader which normally returns a 'bytes consumed' value, as this function
> does.
parse_container() could very well change its convention to return
negative on error and positive value if the loop is supposed to skip
bytes.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-05-01 8:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:34 [PATCH v5 0/6] x86/microcode/AMD: Check microcode file sanity before loading it Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 1/6] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 2/6] x86/microcode/AMD: Add microcode container data checking functions Maciej S. Szmigiero
2018-04-30 9:04 ` Borislav Petkov
2018-04-30 22:27 ` Maciej S. Szmigiero
2018-05-01 8:18 ` Borislav Petkov
2018-05-01 16:19 ` Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 3/6] x86/microcode/AMD: Check microcode container data in the early loader Maciej S. Szmigiero
2018-04-30 9:05 ` Borislav Petkov
2018-04-30 22:27 ` Maciej S. Szmigiero
2018-05-01 8:44 ` Borislav Petkov
2018-04-23 21:34 ` [PATCH v5 4/6] x86/microcode/AMD: Check microcode container data in the late loader Maciej S. Szmigiero
2018-04-30 9:05 ` Borislav Petkov
2018-04-30 22:27 ` Maciej S. Szmigiero
2018-05-01 8:43 ` Borislav Petkov [this message]
2018-05-01 16:19 ` Maciej S. Szmigiero
2018-05-01 20:03 ` Borislav Petkov
2018-05-02 0:47 ` Maciej S. Szmigiero
2018-05-03 10:01 ` Borislav Petkov
2018-05-03 23:26 ` Maciej S. Szmigiero
2018-05-07 16:35 ` Borislav Petkov
2018-04-23 21:34 ` [PATCH v5 5/6] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro Maciej S. Szmigiero
2018-04-23 21:34 ` [PATCH v5 6/6] x86/microcode/AMD: Check the equivalence table size when scanning it Maciej S. Szmigiero
2018-04-30 9:05 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501084317.GC31863@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.