All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: David Ahern <dsahern@gmail.com>
Cc: Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] ipv6: Allow non-gateway ECMP for IPv6
Date: Tue, 1 May 2018 16:20:48 +0300	[thread overview]
Message-ID: <20180501132048.GA15048@splinter.mtl.com> (raw)
In-Reply-To: <89497565-f1e6-a916-70d3-dfc7efa7a7e4@gmail.com>

On Mon, Apr 30, 2018 at 08:59:10PM -0600, David Ahern wrote:
> On 4/30/18 3:15 PM, Thomas Winter wrote:
> > It is valid to have static routes where the nexthop
> > is an interface not an address such as tunnels.
> > For IPv4 it was possible to use ECMP on these routes
> > but not for IPv6.
> > 
> > Signed-off-by: Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> > Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> > ---
> >  include/net/ip6_route.h | 3 +--
> >  net/ipv6/ip6_fib.c      | 3 ---
> >  2 files changed, 1 insertion(+), 5 deletions(-)
> > 
> 
> Interesting. Existing code inserts the dev nexthop as a separate route.
> 
> Change looks good to me.
> 
> Acked-by: David Ahern <dsahern@gmail.com>

Thanks for the Cc, David. I'll need to adjust mlxsw to support this.
Specifically, mlxsw_sp_fib6_rt_can_mp().

BTW, I hit this bug while looking into this:
https://patchwork.ozlabs.org/patch/907050/

  reply	other threads:[~2018-05-01 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 21:15 [PATCH] ipv6: Allow non-gateway ECMP for IPv6 Thomas Winter
2018-05-01  2:59 ` David Ahern
2018-05-01 13:20   ` Ido Schimmel [this message]
2018-05-01 18:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501132048.GA15048@splinter.mtl.com \
    --to=idosch@mellanox.com \
    --cc=Thomas.Winter@alliedtelesis.co.nz \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.