From: Lee Jones <lee.jones@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Gwendal Grignou <gwendal@chromium.org>,
Sameer Nanda <snanda@chromium.org>,
linux-pm@vger.kernel.org, Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
miguel.ojeda.sandonis@gmail.com
Subject: Re: [PATCH v2 2/3] power: supply: add cros-ec USBPD charger driver.
Date: Tue, 1 May 2018 14:27:02 +0100 [thread overview]
Message-ID: <20180501132702.GP5147@dell> (raw)
In-Reply-To: <20180501121728.65bow5vzpzfeq4en@earth.universe>
On Tue, 01 May 2018, Sebastian Reichel wrote:
> Hi Enric,
>
> On Mon, Apr 30, 2018 at 03:14:02PM +0200, Enric Balletbo i Serra wrote:
> > From: Sameer Nanda <snanda@chromium.org>
> >
> > This driver gets various bits of information about what is connected to
> > USB PD ports from the EC and converts that into power_supply properties.
> >
> > Signed-off-by: Sameer Nanda <snanda@chromium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >
> > Changes in v2:
> > - [2/3] Add SPDX header, use devm_ variant and drop .owner
> > - [2/3] Removed the PD log functionality (will be send on a follow up patch)
> > - [2/3] Removed the extra custom sysfs attributes (will be send on a follow up patch)
>
> Thanks, it makes reviewing the patchset easier.
>
> > drivers/power/supply/Kconfig | 10 +
> > drivers/power/supply/Makefile | 1 +
> > drivers/power/supply/cros_usbpd-charger.c | 511 ++++++++++++++++++++++
> > include/linux/mfd/cros_ec.h | 2 +
> > 4 files changed, 524 insertions(+)
> > create mode 100644 drivers/power/supply/cros_usbpd-charger.c
[...]
Sebastian,
When you review a patch, would you mind chopping/snipping unnecessary
text please? The chunks in-between the ones you reply to.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-05-01 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 13:14 [PATCH v2 0/3] mfd/power: cros_ec: add support for USBPD charger driver Enric Balletbo i Serra
2018-04-30 13:14 ` [PATCH v2 1/3] mfd: cros_ec: Add USBPD charger commands and struct definitions Enric Balletbo i Serra
2018-05-01 8:29 ` Lee Jones
2018-05-02 9:33 ` Enric Balletbo i Serra
2018-05-02 9:56 ` Lee Jones
2018-04-30 13:14 ` [PATCH v2 2/3] power: supply: add cros-ec USBPD charger driver Enric Balletbo i Serra
2018-04-30 13:20 ` Miguel Ojeda
2018-04-30 13:37 ` Enric Balletbo Serra
2018-05-01 8:29 ` Lee Jones
2018-05-01 12:17 ` Sebastian Reichel
2018-05-01 13:27 ` Lee Jones [this message]
2018-04-30 13:14 ` [PATCH v2 3/3] mfd: cros_ec_dev: Register cros_usbpd-charger driver as a subdevice Enric Balletbo i Serra
2018-05-01 8:32 ` Lee Jones
2018-05-02 9:42 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501132702.GP5147@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=snanda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.