All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>,
	Mike Snitzer <msnitzer@redhat.com>,
	"Alasdair G. Kergon" <agk@redhat.com>,
	Milan Broz <mbroz@redhat.com>
Cc: dm-devel@redhat.com
Subject: [patch 2/8] dm-integrity: change the variable suspending from bool to int
Date: Tue, 01 May 2018 15:55:18 +0200	[thread overview]
Message-ID: <20180501135600.434701234@debian.vm> (raw)
In-Reply-To: 20180501135516.961417937@debian.vm

[-- Attachment #1: dm-integrity-suspending.patch --]
[-- Type: text/plain, Size: 1182 bytes --]

The early alpha processors can't write a byte or short atomically, so
asynchronously-modified variables shouldn't really have byte type.
Change is to int.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

---
 drivers/md/dm-integrity.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/drivers/md/dm-integrity.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-integrity.c	2018-05-01 00:23:32.000000000 +0200
+++ linux-2.6/drivers/md/dm-integrity.c	2018-05-01 00:38:57.000000000 +0200
@@ -178,7 +178,7 @@ struct dm_integrity_c {
 	__u8 sectors_per_block;
 
 	unsigned char mode;
-	bool suspending;
+	int suspending;
 
 	int failed;
 
@@ -2210,7 +2210,7 @@ static void dm_integrity_postsuspend(str
 
 	del_timer_sync(&ic->autocommit_timer);
 
-	ic->suspending = true;
+	WRITE_ONCE(ic->suspending, 1);
 
 	queue_work(ic->commit_wq, &ic->commit_work);
 	drain_workqueue(ic->commit_wq);
@@ -2220,7 +2220,7 @@ static void dm_integrity_postsuspend(str
 		dm_integrity_flush_buffers(ic);
 	}
 
-	ic->suspending = false;
+	WRITE_ONCE(ic->suspending, 0);
 
 	BUG_ON(!RB_EMPTY_ROOT(&ic->in_progress));
 

  parent reply	other threads:[~2018-05-01 13:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 13:55 [patch 0/8] dm-integrity patches Mikulas Patocka
2018-05-01 13:55 ` [patch 1/8] dm-integrity: use kvfree Mikulas Patocka
2018-05-01 13:55 ` Mikulas Patocka [this message]
2018-05-01 13:55 ` [patch 3/8] dm-integrity: report size in the status Mikulas Patocka
2018-05-01 13:55 ` [patch 4/8] dm-integrity: add ic->start in get_data_sector Mikulas Patocka
2018-05-01 13:55 ` [patch 5/8] dm-integrity: allow external devices Mikulas Patocka
2018-05-01 13:55 ` [patch 6/8] dm-integrity: use version 2 for separate metadata Mikulas Patocka
2018-05-01 13:55 ` [patch 7/8] dm-integrity: flush journal on suspend when using separate device Mikulas Patocka
2018-05-01 13:55 ` [patch 8/8] dm-integrity: recalculate checksums Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501135600.434701234@debian.vm \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mbroz@redhat.com \
    --cc=msnitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.