From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joel Fernandes <joelaf@google.com>,
linux-kernel@vger.kernel.org,
Peter Zilstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Glexiner <tglx@linutronix.de>,
Boqun Feng <boqun.feng@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Fenguang Wu <fengguang.wu@intel.com>,
Baohong Liu <baohong.liu@intel.com>,
Vedang Patel <vedang.patel@intel.com>,
kernel-team@android.com
Subject: Re: [PATCH RFC v5 3/6] srcu: Add notrace variant of srcu_dereference
Date: Tue, 1 May 2018 08:27:43 -0700 [thread overview]
Message-ID: <20180501152743.GK26088@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180501110403.0b661039@gandalf.local.home>
On Tue, May 01, 2018 at 11:04:03AM -0400, Steven Rostedt wrote:
> On Tue, 1 May 2018 07:18:17 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
>
> > > diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> > > index 2ec618979b20..a1c4947be877 100644
> > > --- a/include/linux/srcu.h
> > > +++ b/include/linux/srcu.h
> > > @@ -135,6 +135,11 @@ static inline int srcu_read_lock_held(const struct srcu_struct *sp)
> > > */
> > > #define srcu_dereference(p, sp) srcu_dereference_check((p), (sp), 0)
> > >
> > > +/**
> > > + * srcu_dereference_notrace - no tracing and no lockdep calls from here
> > > + */
> > > +#define srcu_dereference_notrace(p, sp) srcu_dereference_check((p), (sp), 1)
> >
> > Given that this is a one-liner, why not just use srcu_dereference_check()
> > directly, with 1 as you do above to disable lockdep?
>
> I prefer what Joel did. It documents why we are doing this. Open coding
> the call directly will just confuse others that touch tracepoint code.
I suppose...
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
next prev parent reply other threads:[~2018-05-01 15:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 1:41 [PATCH RFC v5 0/6] Centralize and unify usage of preempt/irq tracepoints Joel Fernandes
2018-05-01 1:41 ` [PATCH RFC v5 1/6] softirq: reorder trace_softirqs_on to prevent lockdep splat Joel Fernandes
2018-05-01 14:02 ` Steven Rostedt
2018-05-01 15:00 ` Joel Fernandes
2018-05-01 1:42 ` [PATCH RFC v5 2/6] srcu: Add notrace variants of srcu_read_{lock,unlock} Joel Fernandes
2018-05-01 14:04 ` Steven Rostedt
2018-05-01 1:42 ` [PATCH RFC v5 3/6] srcu: Add notrace variant of srcu_dereference Joel Fernandes
2018-05-01 14:06 ` Steven Rostedt
2018-05-01 15:07 ` Joel Fernandes
2018-05-01 14:18 ` Paul E. McKenney
2018-05-01 15:04 ` Steven Rostedt
2018-05-01 15:27 ` Paul E. McKenney [this message]
2018-05-01 1:42 ` [PATCH RFC v5 4/6] trace/irqsoff: Split reset into seperate functions Joel Fernandes
2018-05-01 3:45 ` Randy Dunlap
2018-05-01 3:46 ` [kernel-team] " Joel Fernandes
2018-05-01 1:42 ` [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU Joel Fernandes
2018-05-01 1:56 ` Joel Fernandes
2018-05-01 14:24 ` Steven Rostedt
2018-05-01 14:24 ` Steven Rostedt
2018-05-01 14:36 ` Paul E. McKenney
2018-05-01 15:16 ` Joel Fernandes
2018-05-01 15:21 ` Paul E. McKenney
2018-05-01 15:23 ` Joel Fernandes
2018-05-01 15:42 ` Paul E. McKenney
2018-05-01 15:53 ` Joel Fernandes
2018-05-01 16:44 ` Joel Fernandes
2018-05-01 1:42 ` [PATCH RFC v5 6/6] tracing: Centralize preemptirq tracepoints and unify their usage Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501152743.GK26088@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=baohong.liu@intel.com \
--cc=boqun.feng@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=joelaf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.