From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/python: add upstream GCC8 build fix
Date: Wed, 2 May 2018 14:52:56 +0200 [thread overview]
Message-ID: <20180502145256.6dec17cc@windsurf> (raw)
In-Reply-To: <20180502111448.14995-1-chemobejk@gmail.com>
Hello Stefan,
On Wed, 2 May 2018 14:14:48 +0300, Stefan Becker wrote:
> Fedora 28 switched to GCC8.
>
> Signed-off-by: Stefan Becker <chemobejk@gmail.com>
I've applied, after fixing one small formatting issue, see below.
> ---
> package/python/0035-GCC8-alignment-fix.patch | 66 ++++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 package/python/0035-GCC8-alignment-fix.patch
>
> diff --git a/package/python/0035-GCC8-alignment-fix.patch b/package/python/0035-GCC8-alignment-fix.patch
> new file mode 100644
> index 0000000000..34618d9b18
> --- /dev/null
> +++ b/package/python/0035-GCC8-alignment-fix.patch
> @@ -0,0 +1,66 @@
> +From 0b91f8a668201fc58fa732b8acc496caedfdbae0 Mon Sep 17 00:00:00 2001
> +From: Florian Weimer <fw@deneb.enyo.de>
> +Date: Sun, 29 Apr 2018 12:18:33 -0700
> +Subject: [PATCH] Indicate that _PyGC_Head is only 8-byte aligned. (closes
> + bpo-33374)
> +
> +By spec, the "long double" in _PyGC_Head requires the union to always be 16-byte
> +aligned. However, obmalloc only yields 8-byte alignment. Compilers including GCC
> +8 are starting to use alignment information to do store-merging. So, the "long
> +double" needs to be changed to a simple "double" as was long ago done in Python
> +3 by e348c8d154cf6342c79d627ebfe89dfe9de23817. For 2.7, we need to add some
> +dummy padding to make sure _PyGC_Head stays the same size.
The Upstream status and SoB should have been here.
> +---
> + Include/objimpl.h | 17 ++++++++++++++++-
> + .../2018-04-29-12-07-00.bpo-33374.-xegL6.rst | 3 +++
> + 2 files changed, 19 insertions(+), 1 deletion(-)
> + create mode 100644 Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst
> +
> +Upstream: https://bugs.python.org/issue33374
> +Signed-off-by: Stefan Becker <chemobejk@gmail.com>
Not here.
Once again: applied with this issue fixed. Thanks a lot!
Peter: I guess we want this as well for 2018.02.x.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-02 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 11:14 [Buildroot] [PATCH] package/python: add upstream GCC8 build fix Stefan Becker
2018-05-02 12:52 ` Thomas Petazzoni [this message]
2018-05-02 19:30 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502145256.6dec17cc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.