From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Amit Pundir <amit.pundir@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Christophe Ricard <christophe.ricard@gmail.com>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call
Date: Wed, 2 May 2018 11:03:56 -0700 [thread overview]
Message-ID: <20180502180356.GA4660@kroah.com> (raw)
In-Reply-To: <1525283968.21176.633.camel@linux.intel.com>
On Wed, May 02, 2018 at 08:59:28PM +0300, Andy Shevchenko wrote:
> On Wed, 2018-05-02 at 23:19 +0530, Amit Pundir wrote:
>
> > - dev_dbg(dev, "%s\n", __func__);
> > + dev_dbg(dev, "\n");
>
> If one enables function tracer this will be redundant completely.
Yes those kinds of "trace" debug log messages should be just deleted.
prev parent reply other threads:[~2018-05-02 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 17:49 [PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call Amit Pundir
2018-05-02 17:59 ` Andy Shevchenko
2018-05-02 18:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502180356.GA4660@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit.pundir@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christophe.ricard@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.