From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update Date: Wed, 2 May 2018 21:51:43 +0300 Message-ID: <20180502185143.GN23723@intel.com> References: <20180430040018.79272-1-tarun.vyas@intel.com> <20180430171933.GI3617@intel.com> <20180502181913.GA14677@otc-chromeosbuild-5> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id A96036E62C for ; Wed, 2 May 2018 18:51:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180502181913.GA14677@otc-chromeosbuild-5> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tarun Vyas Cc: Deak@otc-chromeosbuild-5, intel-gfx@lists.freedesktop.org, Pandiyan@otc-chromeosbuild-5, Dhinakaran , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDIsIDIwMTggYXQgMTE6MTk6MTRBTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90 ZToKPiBPbiBNb24sIEFwciAzMCwgMjAxOCBhdCAxMDoxOTozM0FNIC0wNzAwLCBSb2RyaWdvIFZp dmkgd3JvdGU6Cj4gPiBPbiBTdW4sIEFwciAyOSwgMjAxOCBhdCAwOTowMDoxOFBNIC0wNzAwLCBU YXJ1biBWeWFzIHdyb3RlOgo+ID4gPiBGcm9tOiBUYXJ1biA8dGFydW4udnlhc0BpbnRlbC5jb20+ Cj4gPiA+IAo+ID4gPiBUaGUgUElQRURTTCBmcmVlemVzIG9uIFBTUiBlbnRyeSBhbmQgaWYgUFNS IGhhc24ndCBmdWxseSBleGl0ZWQsIHRoZW4KPiA+ID4gdGhlIHBpcGVfdXBkYXRlX3N0YXJ0IGNh bGwgc2NoZWR1bGVzIGl0c2VsZiBvdXQgdG8gY2hlY2sgYmFjayBsYXRlci4KPiA+ID4gCj4gPiA+ IE9uIENocm9tZU9TLTQuNCBrZXJuZWwsIHdoaWNoIGlzIGZhaXJseSB1cC10by1kYXRlIHcuci50 IGRybS9pOTE1IGJ1dAo+ID4gPiBsYWdzIHcuci50IGNvcmUga2VybmVsIGNvZGUsIGhvdCBwbHVn Z2luZyBhbiBleHRlcm5hbCBkaXNwbGF5IHRyaWdnZXJzCj4gPiA+IHRvbnMgb2YgInBvdGVudGlh bCBhdG9taWMgdXBkYXRlIGVycm9ycyIgaW4gdGhlIGRtZXNnLCBvbiAqcGlwZSBBKi4gQQo+ID4g PiBjbG9zZXIgYW5hbHlzaXMgcmV2ZWFscyB0aGF0IHdlIHRyeSB0byByZWFkIHRoZSBzY2FubGlu ZSAzIHRpbWVzIGFuZAo+ID4gPiBldmVudHVhbGx5IHRpbWVvdXQsIGIvYyBQU1IgaGFzbid0IGV4 aXRlZCBmdWxseSBsZWFkaW5nIHRvIGEgUElQRURTTAo+ID4gPiBzdHVjayBAIDE1OTkuIFRoaXMg aXNzdWUgaXMgbm90IHNlZW4gb24gdXBzdHJlYW0ga2VybmVscywgYi9jIGZvciAqc29tZSoKPiA+ ID4gcmVhc29uIHdlIGxvb3AgaW5zaWRlIGludGVsX3BpcGVfdXBkYXRlIHN0YXJ0IGZvciB+Misg bXNlYyB3aGljaCBpbiB0aGlzCj4gPiA+IGNhc2UgaXMgbW9yZSB0aGFuIGVub3VnaCB0byBleGl0 IFBTUiBmdWxseSwgaGVuY2UgYW4gKnVuc3R1Y2sqIFBJUEVEU0wKPiA+ID4gY291bnRlciwgaGVu Y2Ugbm8gZXJyb3IuIE9uIHRoZSBvdGhlciBoYW5kLCB0aGUgQ2hyb21lT1Mga2VybmVsIHNwZW5k cwo+ID4gPiB+MS4xIG1zZWMgbG9vcGluZyBpbnNpZGUgaW50ZWxfcGlwZV91cGRhdGVfc3RhcnQg YW5kIGhlbmNlIGVycm9ycyBvdXQKPiA+ID4gYi9jIHRoZSBzb3VyY2UgaXMgc3RpbGwgaW4gUFNS Lgo+ID4gPiAKPiA+ID4gUmVnYXJkbGVzcywgd2Ugc2hvdWxkIHdhaXQgZm9yIFBTUiBleGl0IChp ZiBQU1IgaXMgc3VwcG9ydGVkIGFuZCBhY3RpdmUKPiA+ID4gb24gdGhlIGN1cnJlbnQgcGlwZSkg YmVmb3JlIHJlYWRpbmcgdGhlIFBJUEVEU0wsIGIvYyBpZiB3ZSBoYXZlbid0Cj4gPiA+IGZ1bGx5 IGV4aXRlZCBQU1IsIHRoZW4gY2hlY2tpbmcgZm9yIHZibGFuayBldmFzaW9uIGlzbid0IGFjdHVh bGx5Cj4gPiA+IGFwcGxpY2FibGUuCj4gPiA+IAo+ID4gPiBUaGlzIHNjZW5hcmlvIGFwcGxpZXMg dG8gYSBjb25maWd1cmF0aW9uIHdpdGggYW4gYWRkaXRpb25hbCBwaXBlLAo+ID4gPiBhcyBvZiBu b3cuCj4gPiAKPiA+IEkgaG9uZXN0bHkgYmVsaWV2ZSB5b3UgcGlja2luZyB0aGUgd3JvbmcgY3Vs cHJpdCBoZXJlLiBCeSAiY29pbmNpZGVuY2UiLgo+ID4gUFNSIHdpbGwgYWxsb3cgREMgc3RhdGUg d2l0aCBzY3JlZW4gb24gYW5kIERDIHN0YXRlIHdpbGwgbWVzcyB1cCB3aXRoIGFsbAo+ID4gcmVn aXN0ZXJzIHJlYWRzLi4uLgo+ID4gCj4gPiBwcm9iYWJseSB3aGF0IHlvdSBhcmUgbWlzc2luZyB5 b3UgeW91ciBrZXJuZWwgaXMgc29tZSBwb3dlciBkb21haW4KPiA+IGdyYWIgdGhhdCB3b3VsZCBr ZWVwIERDX09GRiBhbmQgY29uc2VxdWVudGx5IGEgc2FuZSByZWFkIG9mIHRoZXNlCj4gPiByZWdp c3RlcnMuCj4gPiAKPiA+IE1heWJlIEltcmUgaGFzIGEgcXVpY2sgaWRlYSBvZiB3aGF0IHlvdSBj b3VsZCBiZSBtaXNzaW5nIG9uIHlvdXIga2VybmVsCj4gPiB0aGF0IHdlIGFscmVhZHkgaGF2ZSBv biB1cHN0cmVhbSBvbmUuCj4gPiAKPiA+IFRoYW5rcywKPiA+IFJvZHJpZ28uCj4gPgo+IFRoYW5r cyBmb3IgdGhlIHF1aWNrIHJlc3BvbnNlIFJvZHJpZ28gIQo+IFNvbWUga2V5IG9ic2VydmF0aW9u cyBiYXNlZCBvbiBteSBleHBlcmltZW50cyBzbyBmYXI6Cj4gICAgICAgIGZvciAoOzspIHsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIAo+ICAgICAgICAgICAgICAgICAvKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiAgICAgICAgICAgICAgICAgICogcHJl cGFyZV90b193YWl0KCkgaGFzIGEgbWVtb3J5IGJhcnJpZXIsIHdoaWNoIGd1YXJhbnRlZXMgICAg ICAgCj4gICAgICAgICAgICAgICAgICAqIG90aGVyIENQVXMgY2FuIHNlZSB0aGUgdGFzayBzdGF0 ZSB1cGRhdGUgYnkgdGhlIHRpbWUgd2UgICAgICAgIAo+ICAgICAgICAgICAgICAgICAgKiByZWFk IHRoZSBzY2FubGluZS4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKPiAgICAgICAgICAgICAgICAgICovICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gICAgICAgICAgICAgICAgIHByZXBhcmVf dG9fd2FpdCh3cSwgJndhaXQsIFRBU0tfVU5JTlRFUlJVUFRJQkxFKTsgICAgICAgICAgICAgICAg IAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiAgICAgICAgICAgICAgICAgc2NhbmxpbmUg PSBpbnRlbF9nZXRfY3J0Y19zY2FubGluZShjcnRjKTsgICAgICAgICAgICAgICAgICAgICAgICAg Cj4gICAgICAgICAgICAgICAgIGlmIChzY2FubGluZSA8IG1pbiB8fCBzY2FubGluZSA+IG1heCkg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIAo+ICAgICAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gICAgICAgICAgICAgICAgIGlmICh0aW1lb3V0 IDw9IDApIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAo+ ICAgICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiUG90ZW50aWFsIGF0b21pYyB1cGRh dGUgZmFpbHVyZSBvbiBwaXBlICVjXG4iLCAKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcGlwZV9uYW1lKGNydGMtPnBpcGUpKTsgICAgICAgICAgICAgICAgICAgICAgICAgCj4g ICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIAo+ICAgICAgICAgICAgICAgICB9ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCj4gICAgICAgICAgICAgICAgIGxvY2FsX2lycV9lbmFi bGUoKTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAo+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAKPiAgICAgICAgICAgICAgICAgdGltZW91dCA9IHNjaGVk dWxlX3RpbWVvdXQodGltZW91dCk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIAo+ICAgICAgICAgICAgICAgICBsb2NhbF9pcnFfZGlzYWJs ZSgpOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiAgICAg ICAgIH0KPiAxLiBJbiB0aGUgYWJvdmUgbG9vcCBpbnNpZGUgcGlwZV91cGRhdGVfc3RhcnQsIHRo ZSAqZmlyc3QgdGltZSosIHdlIHJlYWQgdGhlIFBJUEVEU0wsIHdpdGggUFNSMSBhbmQgZXh0ZXJu YWwgZGlzcGxheSBjb25uZWN0ZWQsIGl0IGFsd2F5cyByZWFkcyAxNTk5LCBmb3IgKmJvdGgqIHRo ZSBrZXJuZWxzKHVwc3RyZWFtIGFuZCBDaHJvbWVPUy00LjQpIC4gVGhlIFBTUl9TVEFUVVMgYWxz byByZWFkcyB0aGUgZXhhY3Qgc2FtZSBmb3IgKmJvdGgqIGtlcm5lbHMgYW5kIHNob3dzIHRoYXQg d2UgaGF2ZW4ndCAqZnVsbHkqIGV4aXRlZCBQU1IuCj4gCj4gMi4gVGhlIGRpZmZlcmVuY2UgYmV0 d2VlbiB0aGUgdHdvIGtlcm5lbHMgY29tZXMgYWZ0ZXIgdGhpcyBmaXJzdCByZWFkIG9mIHRoZSBQ SVBFRFNMLiBDaHJvbWVPUy00LjQgc3BlbmRzIH4xIG1zZWMgaW5zaWRlIHRoYXQgbG9vcCBhbmQg dXBzdHJlYW0gc3BlbmRzIH4ybXNlYy4gSSBzdXNwZWN0IHRoYXQgaXQgaXMgYmVjYXVzZSBvZiB0 aGUgc2NoZWR1bGluZyBjaGFuZ2VzIGJldHdlZW4gdGhlIHR3byBrZXJuZWxzLCBiL2MgSSBjYW4n dCBmaW5kIGFueSBpOTE1IHNwZWNpZmljIGNvZGUgcnVubmluZyBpbiB0aGF0IGxvb3AsIGV4Y2Vw dCBmb3IgdmJsYW5rIHByb2Nlc3NpbmcuCj4gCj4gMy4gU28gdG8gc3VtbWFyaXplIGl0LCBib3Ro IHRoZSBrZXJuZWxzIGFyZSBpbiB0aGUgc2FtZSBzdGF0ZSB3LnIudCBQU1IgYW5kIFBJUEVEU0wg dmFsdWUgd2hlbiB0aGV5IHJlYWQgdGhlIFBJUEVEU0wgZm9yIHRoZSBmaXJzdCB0aW1lIGluc2lk ZSB0aGUgbG9vcC4gKldoZW4qIHRoZSBrZXJuZWxzICp0cmFuc2l0aW9uKiB0byBhICpmdWxsIFBT UiBleGl0KiBpcyB3aGF0IGlzIGRpZmZlcmluZy4KPiAKPiBNeSByYXRpb25hbGUgZm9yIHRoaXMg cGF0Y2ggaXMgdGhhdCwgdGhlIHBpcGVfdXBkYXRlX3N0YXJ0IGZ1bmN0aW9uIGlzIG1lYW50IHRv IGV2YWRlIDEwMCB1c2VjIGJlZm9yZSBhIHZibGFuaywgYnV0LCAqaWYqIHdlIGhhdmVuJ3QgKmZ1 bGx5KiBleGl0ZWQgUFNSICh3aGljaCBpcyB0cnVlIGZvciBib3RoIHRoZSBrZXJuZWxzIGZvciB0 aGUgZmlyc3QgUElQRURTTCByZWFkKSwgdGhlbiB2YmxhbmsgZXZhc2lvbiBpcyAqbm90IGFwcGxp Y2FibGUqIGIvYyB0aGUgUElQRURTTCB3aWxsIGJlIG1lc3NlZCB1cC4gU28gd2Ugc2hvdWxkbid0 IGJvdGhlciBldmFkaW5nIHZibGFuayB1bnRpbCB3ZSBoYXZlIGZ1bGx5IGV4aXRlZCBQU1IuCgpZ ZWFoLCBJIHRoaW5rIHRoaXMgaXMgdGhlIHJpZ2h0IGRpcmVjdGlvbi4gVGhlIHByb2JsZW0gcmVh bGx5IGlzIHRoZQpleHRyYSB2YmxhbmsgcHVsc2UgdGhhdCB0aGUgaGFyZHdhcmUgZ2VuZXJhdGVz IChvciBhdCBsZWFzdCBjYW4KZ2VuZXJhdGUgZGVwZW5kaW5nIG9uIGEgY2hpY2tlbiBiaXQpIHdo ZW4gaXQgZXhpdHMgUFNSLiBXZSBoYXZlIG5vCmNvbnRyb2wgb3ZlciB3aGVuIHRoYXQgaGFwcGVu cyBhbmQgaGVuY2Ugd2UgaGF2ZSBubyBjb250cm9sIG92ZXIgd2hlbgp0aGUgcmVnaXN0ZXJzIGdl dCBsYXRjaGVkLiBBbmQgeWV0IHdlIHN0aWxsIGhhdmUgdG8gc29tZWhvdyBwcmV2ZW50CnRoZSBy ZWdpc3RlciBsYXRjaGluZyBmcm9tIG9jY3VycmluZyB3aGlsZSB3ZSdyZSBpbiBtaWRkbGUgb2YK cmVwcm9ncmFtbWluZyB0aGVtLgoKVGhlcmUgYXJlIGEgY291cGxlIG9mIHdheXMgdG8gYXZvaWQg dGhpczoKMSkgU2V0IHRoZSBjaGlja2VuIGJpdCBzbyB0aGF0IHdlIGRvbid0IGdldCB0aGUgdmJs YW5rIHB1bHNlLiBUaGUKICAgcGlwZSBzaG91bGQgcmVzdGFydCBmcm9tIHRoZSB2Ymxhbmsgc3Rh cnQsIHNvIHdlIHdvdWxkIGhhdmUgb25lCiAgIGZ1bGwgZnJhbWUgdG8gcmVwcm9nYW0gdGhlIHJl Z2lzdGVycy4gSG93dmVyIElJUkMgREsgdG9sZCBtZQogICB0aGVyZSBpcyBubyB3YXkgdG8gZnVs bHkgZWxpbWluYXRlIGl0IGluIGFsbCBjYXNlcyBzbyB0aGlzCiAgIG9wdGlvbiBpcyBwcm9iYWJs eSBvdXQuIFRoZXJlIHdhcyBhbHNvIHNvbWUgaW1wbGljYXRpb24gZm9yIEZCQwogICB3aGljaCBJ IGFscmVhZHkgZm9yZ290LgoyKSBNYWtlIHN1cmUgd2UndmUgZXhpdGVkIFBTUiBiZWZvcmUgcmVw Z3JvZ2FtbWluZyB0aGUgcmVnaXN0ZXJzCiAgIChpZS4gd2hhdCB5b3UgZG8pLgozKSBVc2UgdGhl IERPVUJMRV9CVUZGRVJfQ1RMIHRvIHByZXZlbnQgdGhlIGV4dHJhIHZibGFuayBwdWxzZSBmcm9t CiAgIGxhdGNoaW5nIHRoZSByZWdpc3RlcnMgd2hpbGUgd2UncmUgc3RpbGwgcmVwcm9ncmFtbWlu ZyB0aGVtLgogICBUaGlzIGZlYXR1cmUgb25seSBleGlzdHMgb24gU0tMKyBzbyBpcyBub3QgYSBz b2x1dGlvbiBmb3IKICAgSFNXL0JEVy4gQnV0IG1heWJlIEhTVy9CRFcgZGlkbid0IGV2ZW4gaGF2 ZSB0aGUgZXh0cmEgdmJsYW5rCiAgIHB1bHNlPwoKT3B0aW9uIDIpIGRvZXMgcHJvdmlkZSBhIGNv bnNpc3RlbnQgYmVoYXZpb3VyIG9uIGFsbCBwbGF0Zm9ybXMsIHNvIEkKZG8ga2luZGEgbGlrZSBp dC4gSXQgYWxzbyBhdm9pZHMgYSBiaWdnZXIgcmV3b3JkIG9uIGFjY291bnQgb2YgdGhlCkRPVUJM RV9CVUZGRVJfQ1RMLiBJIGRvIHRoaW5rIHdlJ2xsIGhhdmUgdG8gc3RhcnQgdXNpbmcKRE9VQkxF X0JVRkZFUl9DVEwgYW55d2F5IGR1ZSB0byBvdGhlciBpc3N1ZXMsIGJ1dCBhdCBsZWFzdCB0aGlz IHdheQp3ZSBkb24ndCBibG9jayBQU1IgcHJvZ3Jlc3Mgb24gdGhhdCB3b3JrLgoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK