From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsahern@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Thomas.Winter@alliedtelesis.co.nz, davem@davemloft.net,
Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, pch@ordbogen.com, jkbs@redhat.com,
yoshfuji@linux-ipv6.org, mlxsw@mellanox.com
Subject: Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops
Date: Wed, 2 May 2018 22:04:01 +0300 [thread overview]
Message-ID: <20180502190401.GA470@splinter> (raw)
In-Reply-To: <017f58ee-8655-60d1-19aa-a6276c639065@gmail.com>
On Wed, May 02, 2018 at 12:58:56PM -0600, David Ahern wrote:
> On 5/2/18 12:53 PM, Ido Schimmel wrote:
> >
> > So this fixes the issue for me. To reproduce:
> >
> > # ip -6 address add 2001:db8::1/64 dev dummy0
> > # ip -6 address add 2001:db8::1/64 dev dummy1
> >
> > This reproduces the issue because due to above commit both local routes
> > are considered siblings... :/
> >
> > local 2001:db8::1 proto kernel metric 0
> > nexthop dev dummy0 weight 1
> > nexthop dev dummy1 weight 1 pref medium
> >
> > I think it's best to revert the patch and have Thomas submit a fixed
> > version to net-next. I was actually surprised to see it applied to net.
>
> ugly side effect of the way ecmp routes are managed in IPv6. I think
> revert is the best option for now.
OK. I'll send a patch.
next prev parent reply other threads:[~2018-05-02 19:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:40 [PATCH net-next 0/4] ipv6: Add support for non-equal-cost multipath Ido Schimmel
2018-01-09 14:40 ` [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops Ido Schimmel
2018-01-10 3:43 ` David Ahern
2018-05-02 16:43 ` Eric Dumazet
2018-05-02 17:21 ` Ido Schimmel
2018-05-02 17:52 ` Ido Schimmel
2018-05-02 18:53 ` Ido Schimmel
2018-05-02 18:58 ` David Ahern
2018-05-02 19:04 ` Ido Schimmel [this message]
2018-05-02 20:48 ` Thomas Winter
2018-05-02 20:56 ` David Ahern
2018-05-04 1:13 ` David Ahern
2018-01-09 14:40 ` [PATCH net-next 2/4] ipv6: Use a 31-bit multipath hash Ido Schimmel
2018-01-10 3:43 ` David Ahern
2018-01-09 14:40 ` [PATCH net-next 3/4] ipv6: Use hash-threshold instead of modulo-N Ido Schimmel
2018-01-10 3:54 ` David Ahern
2018-01-10 12:02 ` Ido Schimmel
2018-01-09 14:40 ` [PATCH net-next 4/4] ipv6: Add support for non-equal-cost multipath Ido Schimmel
2018-01-10 3:48 ` David Ahern
2018-01-10 11:47 ` Ido Schimmel
2018-01-10 15:53 ` David Ahern
2018-01-10 4:38 ` [PATCH net-next 0/4] " David Ahern
2018-01-10 12:31 ` Ido Schimmel
2018-01-10 20:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502190401.GA470@splinter \
--to=idosch@idosch.org \
--cc=Thomas.Winter@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=idosch@mellanox.com \
--cc=jkbs@redhat.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pch@ordbogen.com \
--cc=roopa@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.