From: "Tobin C. Harding" <me@tobin.cc>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Theodore Ts'o <tytso@mit.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option
Date: Thu, 3 May 2018 12:56:55 +1000 [thread overview]
Message-ID: <20180503025655.GL3791@eros> (raw)
In-Reply-To: <20180502145645.a1fa72b86f2501432f003edc@linux-foundation.org>
On Wed, May 02, 2018 at 02:56:45PM -0700, Andrew Morton wrote:
> On Wed, 2 May 2018 09:33:40 +1000 "Tobin C. Harding" <me@tobin.cc> wrote:
>
> > Currently if an attempt is made to print a pointer before there is
> > enough entropy then '(____ptrval____)' is printed. This makes debugging
> > early stage stack traces difficult. We can relax the requirement for
> > cryptographically secure hashing when debugging while still maintaining
> > pointer hashing behaviour.
> >
> > Add a command line option 'use-early-random-bytes'. When enabled get
> > key material from the hw RNG if available.
>
> Documentation/admin-guide/kernel-parameters.rst, please.
>
> > This option should NOT be enabled on production kernels.
>
> And the documentation should explain why this recommendation is made.
> Here was I scratching my head wondering why this feature isn't just
> permanently enabled. Still scratching away...
Thanks for the review. I think v2 covers your concerns, it patches
Documentation/kernel-parameters
If you are still scratching after reading v2 please do say so, I
appreciate the feedback.
thanks,
Tobin.
prev parent reply other threads:[~2018-05-03 2:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 23:33 [PATCH 0/3] enable early printing of hashed pointers Tobin C. Harding
2018-05-01 23:33 ` [PATCH 1/3] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-05-02 0:18 ` Theodore Y. Ts'o
2018-05-01 23:33 ` [PATCH 2/3] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-05-01 23:44 ` Tobin C. Harding
2018-05-02 0:19 ` Theodore Y. Ts'o
2018-05-02 1:39 ` Steven Rostedt
2018-05-02 2:07 ` Tobin C. Harding
2018-05-01 23:33 ` [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option Tobin C. Harding
2018-05-02 1:02 ` Linus Torvalds
2018-05-02 1:27 ` tcharding
2018-05-02 1:45 ` Steven Rostedt
2018-05-02 2:05 ` tcharding
2018-05-02 2:51 ` Linus Torvalds
2018-05-02 21:56 ` Andrew Morton
2018-05-03 2:56 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503025655.GL3791@eros \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.