From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] move_pages: fix integer overflow in memfree
Date: Thu, 3 May 2018 15:12:38 +0800 [thread overview]
Message-ID: <20180503071238.29890-1-liwang@redhat.com> (raw)
Move_page12 get integer overflow failure on large RAM machine as:
move_pages12.c:198: INFO: Free RAM -127127648 kB
move_pages12.c:201: BROK: Not enough free RAM
My test box:
# cat /proc/meminfo |grep -i memfree
MemFree: 21348021204 kB
Here changing the memfree type from 'int' to 'long' to avoid the problem.
Signed-off-by: Li Wang <liwang@redhat.com>
---
testcases/kernel/syscalls/move_pages/move_pages12.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/syscalls/move_pages/move_pages12.c b/testcases/kernel/syscalls/move_pages/move_pages12.c
index 4c37bfe..5e6245d 100644
--- a/testcases/kernel/syscalls/move_pages/move_pages12.c
+++ b/testcases/kernel/syscalls/move_pages/move_pages12.c
@@ -180,7 +180,8 @@ static void alloc_free_huge_on_node(unsigned int node, size_t size)
static void setup(void)
{
- int memfree, ret;
+ int ret;
+ long memfree;
check_config(TEST_NODES);
@@ -194,8 +195,8 @@ static void setup(void)
pgsz = (int)get_page_size();
SAFE_FILE_LINES_SCANF(PATH_MEMINFO, "Hugepagesize: %d", &hpsz);
- SAFE_FILE_LINES_SCANF(PATH_MEMINFO, "MemFree: %d", &memfree);
- tst_res(TINFO, "Free RAM %d kB", memfree);
+ SAFE_FILE_LINES_SCANF(PATH_MEMINFO, "MemFree: %ld", &memfree);
+ tst_res(TINFO, "Free RAM %ld kB", memfree);
if (4 * hpsz > memfree)
tst_brk(TBROK, "Not enough free RAM");
--
2.9.5
next reply other threads:[~2018-05-03 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 7:12 Li Wang [this message]
2018-05-03 8:41 ` [LTP] [PATCH] move_pages: fix integer overflow in memfree Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503071238.29890-1-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.