From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Guo Date: Thu, 03 May 2018 09:25:15 +0000 Subject: Re: [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_int Message-Id: <20180503092515.GI6755@simonLocalRHEL7.x64> List-Id: References: <1524657284-16706-1-git-send-email-wei.guo.simon@gmail.com> <1524657284-16706-10-git-send-email-wei.guo.simon@gmail.com> <20180503061049.GJ6795@fergus.ozlabs.ibm.com> In-Reply-To: <20180503061049.GJ6795@fergus.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org On Thu, May 03, 2018 at 04:10:49PM +1000, Paul Mackerras wrote: > On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@gmail.com wrote: > > From: Simon Guo > > > > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with > > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by > > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store() > > accordingly. > > > > The FP regs need to be flushed so that the right FP reg vals can be read > > from vcpu->arch.fpr. > > This only applies for store instructions; it would be clearer if you > said that explicitly. I will correct this message. > > > > > Suggested-by: Paul Mackerras > > Signed-off-by: Simon Guo > > Same comment about updating RA as for the other patches. Otherwise > this looks fine. > > Paul. Thanks, - Simon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40c8rJ0RKqzF2SM for ; Thu, 3 May 2018 19:25:20 +1000 (AEST) Received: by mail-pf0-x241.google.com with SMTP id a14so14244991pfi.1 for ; Thu, 03 May 2018 02:25:19 -0700 (PDT) Date: Thu, 3 May 2018 17:25:15 +0800 From: Simon Guo To: Paul Mackerras Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input Message-ID: <20180503092515.GI6755@simonLocalRHEL7.x64> References: <1524657284-16706-1-git-send-email-wei.guo.simon@gmail.com> <1524657284-16706-10-git-send-email-wei.guo.simon@gmail.com> <20180503061049.GJ6795@fergus.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180503061049.GJ6795@fergus.ozlabs.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 03, 2018 at 04:10:49PM +1000, Paul Mackerras wrote: > On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@gmail.com wrote: > > From: Simon Guo > > > > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with > > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by > > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store() > > accordingly. > > > > The FP regs need to be flushed so that the right FP reg vals can be read > > from vcpu->arch.fpr. > > This only applies for store instructions; it would be clearer if you > said that explicitly. I will correct this message. > > > > > Suggested-by: Paul Mackerras > > Signed-off-by: Simon Guo > > Same comment about updating RA as for the other patches. Otherwise > this looks fine. > > Paul. Thanks, - Simon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Guo Subject: Re: [PATCH 09/11] KVM: PPC: reconstruct LOAD_FP/STORE_FP instruction mmio emulation with analyse_intr() input Date: Thu, 3 May 2018 17:25:15 +0800 Message-ID: <20180503092515.GI6755@simonLocalRHEL7.x64> References: <1524657284-16706-1-git-send-email-wei.guo.simon@gmail.com> <1524657284-16706-10-git-send-email-wei.guo.simon@gmail.com> <20180503061049.GJ6795@fergus.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Paul Mackerras Return-path: Content-Disposition: inline In-Reply-To: <20180503061049.GJ6795@fergus.ozlabs.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org On Thu, May 03, 2018 at 04:10:49PM +1000, Paul Mackerras wrote: > On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@gmail.com wrote: > > From: Simon Guo > > > > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with > > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by > > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store() > > accordingly. > > > > The FP regs need to be flushed so that the right FP reg vals can be read > > from vcpu->arch.fpr. > > This only applies for store instructions; it would be clearer if you > said that explicitly. I will correct this message. > > > > > Suggested-by: Paul Mackerras > > Signed-off-by: Simon Guo > > Same comment about updating RA as for the other patches. Otherwise > this looks fine. > > Paul. Thanks, - Simon