From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/atomic: Clean old_state/new_state in drm_atomic_state_default_clear() Date: Thu, 3 May 2018 13:41:52 +0300 Message-ID: <20180503104152.GP23723@intel.com> References: <20180502183247.5746-1-ville.syrjala@linux.intel.com> <20180503063530.GE12521@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180503063530.GE12521@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: stable@vger.kernel.org, intel-gfx@lists.freedesktop.org, Abhay Kumar , Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMDMsIDIwMTggYXQgMDg6MzU6MzBBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE1heSAwMiwgMjAxOCBhdCAwOTozMjo0N1BNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gQ2xlYXIgdGhlIG9sZF9zdGF0ZSBhbmQgbmV3X3N0YXRl IHBvaW50ZXJzIGZvciBldmVyeSBvYmplY3QgaW4KPiA+IGRybV9hdG9taWNfc3RhdGVfZGVmYXVs dF9jbGVhcigpLiBPdGhlcndpc2UKPiA+IGRybV9hdG9taWNfZ2V0X3tuZXcsb2xkfV8qX3N0YXRl KCkgd2lsbCBoYW5kIG91dCBzdGFsZSBwb2ludGVycyB0bwo+ID4gYW55b25lIHdobyBoYXNuJ3Qg Zmlyc3QgY29uZmlybWVkIHRoYXQgdGhlIG9iamVjdCBpcyBpbiBmYWN0IHBhcnQgb2YKPiA+IHRo ZSBjdXJyZW50IGF0b21pYyB0cmFuc2NhdGlvbiwgaWYgdGhleSBhcmUgY2FsbGVkIGFmdGVyIHdl J3ZlIGRvbmUKPiA+IHRoZSB3dyBiYWNrb2ZmIGRhbmNlIHdoaWxlIGhhbmdpbmcgb24gdG8gdGhl IHNhbWUgZHJtX2F0b21pY19zdGF0ZS4KPiA+IAo+ID4gRm9yIGV4YW1wbGUsIGhhbmRsZV9jb25m bGljdGluZ19lbmNvZGVycygpIGxvb2tzIGxpa2UgaXQgY291bGQgaGl0Cj4gPiB0aGlzIHNpbmNl IGl0IGl0ZXJhdGVzIHRoZSBmdWxsIGNvbm5lY3RvciBsaXN0IGFuZCBqdXN0IGNhbGxzCj4gPiBk cm1fYXRvbWljX2dldF9uZXdfY29ubmVjdG9yX3N0YXRlKCkgZm9yIGVhY2guCj4gPiAKPiA+IEFu ZCBJIGJlbGlldmUgd2UgaGF2ZSBub3cgd2l0bmVzc2VkIHRoaXMgaGFwcGVuaW5nIGF0IGxlYXN0 IG9uY2UgaW4KPiA+IGk5MTUgY2hlY2tfZGlnaXRhbF9wb3J0X2NvbmZsaWN0cygpLiBDb21taXQg OGI2OTQ0OWQyNjYzICgiZHJtL2k5MTU6Cj4gPiBSZW1vdmUgbGFzdCByZWZlcmVuY2VzIHRvIGRy bV9hdG9taWNfZ2V0X2V4aXN0aW5nKiBtYWNyb3MiKSBjaGFuZ2VkCj4gPiB0aGUgc2FmZSBkcm1f YXRvbWljX2dldF9leGlzdGluZ19jb25uZWN0b3Jfc3RhdGUoKSB0byB0aGUgdW5zYWZlCj4gPiBk cm1fYXRvbWljX2dldF9uZXdfY29ubmVjdG9yX3N0YXRlKCksIHdoaWNoIG9wZW5lZCB0aGUgZG9v cnMgZm9yCj4gPiB0aGlzIHBhcnRpY3VsYXIgYnVnIHRoZXJlIGFzIHdlbGwuCj4gPiAKPiA+IENj OiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0 ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxs YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiBDYzogQWJoYXkgS3VtYXIgPGFi aGF5Lmt1bWFyQGludGVsLmNvbT4KPiA+IEZpeGVzOiA1ODFlNDlmZTZiNDEgKCJkcm0vYXRvbWlj OiBBZGQgbmV3IGl0ZXJhdG9ycyBvdmVyIGFsbCBzdGF0ZSwgdjMuIikKPiA+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4g VWggLi4uIHRoYXQncyBzb21lIGJhZCBvdmVyc2lnaHQgOi0vCj4gCj4gUmV2aWV3ZWQtYnk6IERh bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gYnR3IGZvciBzdGFibGUg d2UgbWlnaHQgd2FudCB0byBzcGxpdCB0aGlzIGludG8gMSBwYXRjaCBmb3IgY29yZSBvYmplY3Rz Cj4gYW5kIDEgcGF0Y2ggZm9yIGRyaXZlciBwcml2YXRlIHN0dWZmLgoKR29vZCBwb2ludC4gSSBm b3Jnb3Qgd2UgZGlkIHRoYXQgYWZ0ZXIgdGhlIG5ldyBpdGVyYXRvcnMgd2VyZQppbnRyb2R1Y2Vk LiBJJ2xsIGRvIHRoZSBzcGxpdC4KCj4gRmVlbCBmcmVlIHRvIGRvIHNvIHdoaWxlIGFwcGx5aW5n Cj4gYW5kIGtlZXAgbXkgci1iLiBUaGUgZml4ZXMgbGluZSBmb3IgdGhlIDJuZCBwYXRjaCB3b3Vs ZCBiZToKPiAKPiBGaXhlczogYTQzNzBjNzc3NDA2ICgiZHJtL2F0b21pYzogTWFrZSBwcml2YXRl IG9ianMgcHJvcGVyIG9iamVjdHMiKQo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2 NC4xNCsKClRhLgoKPiAKPiBDaGVlcnMsIERhbmllbAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWMuYyB8IDggKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4gaW5kZXggN2QyNWM0MmYyMmRi Li5jODI1Yzc2ZWRjMWQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Yy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiBAQCAtMTU1LDYg KzE1NSw4IEBAIHZvaWQgZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X2NsZWFyKHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAJCQkJCQkgICAgICAgc3RhdGUtPmNvbm5lY3RvcnNb aV0uc3RhdGUpOwo+ID4gIAkJc3RhdGUtPmNvbm5lY3RvcnNbaV0ucHRyID0gTlVMTDsKPiA+ICAJ CXN0YXRlLT5jb25uZWN0b3JzW2ldLnN0YXRlID0gTlVMTDsKPiA+ICsJCXN0YXRlLT5jb25uZWN0 b3JzW2ldLm9sZF9zdGF0ZSA9IE5VTEw7Cj4gPiArCQlzdGF0ZS0+Y29ubmVjdG9yc1tpXS5uZXdf c3RhdGUgPSBOVUxMOwo+ID4gIAkJZHJtX2Nvbm5lY3Rvcl9wdXQoY29ubmVjdG9yKTsKPiA+ICAJ fQo+ID4gIAo+ID4gQEAgLTE2OSw2ICsxNzEsOCBAQCB2b2lkIGRybV9hdG9taWNfc3RhdGVfZGVm YXVsdF9jbGVhcihzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgCj4gPiAgCQlz dGF0ZS0+Y3J0Y3NbaV0ucHRyID0gTlVMTDsKPiA+ICAJCXN0YXRlLT5jcnRjc1tpXS5zdGF0ZSA9 IE5VTEw7Cj4gPiArCQlzdGF0ZS0+Y3J0Y3NbaV0ub2xkX3N0YXRlID0gTlVMTDsKPiA+ICsJCXN0 YXRlLT5jcnRjc1tpXS5uZXdfc3RhdGUgPSBOVUxMOwo+ID4gIAl9Cj4gPiAgCj4gPiAgCWZvciAo aSA9IDA7IGkgPCBjb25maWctPm51bV90b3RhbF9wbGFuZTsgaSsrKSB7Cj4gPiBAQCAtMTgxLDYg KzE4NSw4IEBAIHZvaWQgZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X2NsZWFyKHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAJCQkJCQkgICBzdGF0ZS0+cGxhbmVzW2ldLnN0YXRl KTsKPiA+ICAJCXN0YXRlLT5wbGFuZXNbaV0ucHRyID0gTlVMTDsKPiA+ICAJCXN0YXRlLT5wbGFu ZXNbaV0uc3RhdGUgPSBOVUxMOwo+ID4gKwkJc3RhdGUtPnBsYW5lc1tpXS5vbGRfc3RhdGUgPSBO VUxMOwo+ID4gKwkJc3RhdGUtPnBsYW5lc1tpXS5uZXdfc3RhdGUgPSBOVUxMOwo+ID4gIAl9Cj4g PiAgCj4gPiAgCWZvciAoaSA9IDA7IGkgPCBzdGF0ZS0+bnVtX3ByaXZhdGVfb2JqczsgaSsrKSB7 Cj4gPiBAQCAtMTkwLDYgKzE5Niw4IEBAIHZvaWQgZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X2Ns ZWFyKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAJCQkJCQkgc3RhdGUtPnBy aXZhdGVfb2Jqc1tpXS5zdGF0ZSk7Cj4gPiAgCQlzdGF0ZS0+cHJpdmF0ZV9vYmpzW2ldLnB0ciA9 IE5VTEw7Cj4gPiAgCQlzdGF0ZS0+cHJpdmF0ZV9vYmpzW2ldLnN0YXRlID0gTlVMTDsKPiA+ICsJ CXN0YXRlLT5wcml2YXRlX29ianNbaV0ub2xkX3N0YXRlID0gTlVMTDsKPiA+ICsJCXN0YXRlLT5w cml2YXRlX29ianNbaV0ubmV3X3N0YXRlID0gTlVMTDsKPiA+ICAJfQo+ID4gIAlzdGF0ZS0+bnVt X3ByaXZhdGVfb2JqcyA9IDA7Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTYuMQo+ID4gCj4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJpLWRldmVs IG1haWxpbmcgbGlzdAo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAK PiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==