From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Thiebaud Weksteen <tweek@google.com>
Cc: Nayna Jain <nayna@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] tpm: Add explicit endianness cast
Date: Thu, 3 May 2018 15:40:09 +0300 [thread overview]
Message-ID: <20180503124009.GA7825@linux.intel.com> (raw)
In-Reply-To: <CA+zpnLdasAFPKRXB=5SgiAi5=W08tgkbQTjO26V=PxjphJai=w@mail.gmail.com>
On Wed, May 02, 2018 at 08:49:41AM +0000, Thiebaud Weksteen wrote:
> On Tue, May 1, 2018 at 1:49 PM Jarkko Sakkinen <
> jarkko.sakkinen@linux.intel.com> wrote:
>
> > On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote:
> > > Signed-off-by: Thiebaud Weksteen <tweek@google.com>
> > > ---
> > > drivers/char/tpm/tpm_eventlog_of.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/char/tpm/tpm_eventlog_of.c
> b/drivers/char/tpm/tpm_eventlog_of.c
> > > index 96fd5646f866..ea0f16f19d73 100644
> > > --- a/drivers/char/tpm/tpm_eventlog_of.c
> > > +++ b/drivers/char/tpm/tpm_eventlog_of.c
> > > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip)
> > > * but physical tpm needs the conversion.
> > > */
> > > if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) {
> > > - size = be32_to_cpup(sizep);
> > > - base = be64_to_cpup(basep);
> > > + size = be32_to_cpup((__force __be32 *)sizep);
> > > + base = be64_to_cpup((__force __be64 *)basep);
> > > } else {
> > > size = *sizep;
> > > base = *basep;
> > > --
> > > 2.17.0.484.g0c8726318c-goog
> > >
>
> > Repeal and replace, right (no change log)?
>
> Yep, that's right. Thanks.
Done.
/Jarkko
prev parent reply other threads:[~2018-05-03 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 13:26 [PATCH v3 1/4] tpm: Add explicit endianness cast Thiebaud Weksteen
2018-05-01 11:49 ` Jarkko Sakkinen
2018-05-02 8:49 ` Thiebaud Weksteen
2018-05-03 12:40 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503124009.GA7825@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.