From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place. Date: Thu, 3 May 2018 06:07:45 -0700 Message-ID: <20180503130745.GA2054@intel.com> References: <20180502140316.GG23723@intel.com> <20180502175255.5344-1-rodrigo.vivi@intel.com> <20180502191251.GO23723@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 428BB6E18C for ; Thu, 3 May 2018 13:07:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180502191251.GO23723@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDIsIDIwMTggYXQgMTA6MTI6NTFQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgTWF5IDAyLCAyMDE4IGF0IDEwOjUyOjU1QU0gLTA3MDAsIFJvZHJp Z28gVml2aSB3cm90ZToKPiA+IE9uIGludGVsX2RwX2NvbXB1dGVfY29uZmlnKCkgd2Ugd2VyZSBj YWxjdWxhdGluZyB0aGUgbmVlZGVkIHZjbwo+ID4gZm9yIGVEUCBvbiBnZW45IGFuZCB3ZSBzdGFz aGluZyBpdCBpbgo+ID4gaW50ZWxfYXRvbWljX3N0YXRlLmNkY2xrLmxvZ2ljYWwudmNvCj4gPiAK PiA+IEhvd2V2ZXIgZmV3IG1vbWVudHMgbGF0ZXIgb24gaW50ZWxfbW9kZXNldF9jaGVja3MoKSB3 ZSBmdWxseQo+ID4gcmVwbGFjZSBlbnRpcmUgaW50ZWxfYXRvbWljX3N0YXRlLmNkY2xrLmxvZ2lj YWwgd2l0aAo+ID4gZGV2X3ByaXYtPmNkY2xrLmxvZ2ljYWwgZnVsbHkgb3ZlcndyaXRpbmcgdGhl IGxvZ2ljYWwgZGVzaXJlZAo+ID4gdmNvIGZvciBlRFAgb24gZ2VuOS4KPiA+IAo+ID4gU28sIHdp dGggd3JvbmcgVkNPIHZhbHVlIHdlIGVuZCB1cCB3aXRoIHdyb25nIGRlc2lyZWQgY2RjbGssIGJ1 dAo+ID4gYWxzbyBpdCB3aWxsIHJhaXNlIGEgbG90IG9mIFdBUk5zOiBPbiBnZW45LCB3aGVuIHdl IHJlYWQKPiA+IENEQ0xLX0NUTCB0byB2ZXJpZnkgaWYgd2UgY29uZmlndXJlZCBwcm9wZXJseSB0 aGUgZGVzaXJlZAo+ID4gZnJlcXVlbmN5IHRoZSBDRCBGcmVxdWVuY3kgU2VsZWN0IGJpdHMgWzI3 OjI2XSA9PSAxMGIgY2FuIG1lYW4KPiA+IDMzNy41IG9yIDMwOC41NyBNSHogZGVwZW5kaW5nIG9u IHRoZSBWQ08uIFNvIGlmIHdlIGhhdmUgd3JvbmcKPiA+IFZDTyB2YWx1ZSBzdGFzaGVkIHdlIHdp bGwgYmVsaWV2ZSB0aGUgZnJlcXVlbmN5IHNlbGVjdGlvbiBkaWRuJ3QKPiA+IHN0aWNrIGFuZCBz dGFydCB0byByYWlzZSBXQVJOcyBvZiBjZGNsayBtaXNtYXRjaC4KPiA+IAo+ID4gWyAgIDQyLjg1 NzUxOV0gW2RybTppbnRlbF9kdW1wX2NkY2xrX3N0YXRlIFtpOTE1XV0gQ2hhbmdpbmcgQ0RDTEsg dG8gMzA4NTcxIGtIeiwgVkNPIDg2NDAwMDAga0h6LCByZWYgMjQwMDAga0h6LCBieXBhc3MgMjQw MDAga0h6LCB2b2x0YWdlIGxldmVsIDAKPiA+IFsgICA0Mi44OTcyNjldIGNkY2xrIHN0YXRlIGRv ZXNuJ3QgbWF0Y2ghCj4gPiBbICAgNDIuOTAxMDUyXSBXQVJOSU5HOiBDUFU6IDUgUElEOiAxMTE2 IGF0IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmM6MjA4NCBpbnRlbF9zZXRfY2Rj bGsrMHg1ZC8weDExMCBbaTkxNV0KPiA+IFsgICA0Mi45MzgwMDRdIFJJUDogMDAxMDppbnRlbF9z ZXRfY2RjbGsrMHg1ZC8weDExMCBbaTkxNV0KPiA+IFsgICA0My4xNTUyNTNdIFdBUk5JTkc6IENQ VTogNSBQSUQ6IDExMTYgYXQgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYzoyMDg0 IGludGVsX3NldF9jZGNsaysweDVkLzB4MTEwIFtpOTE1XQo+ID4gWyAgIDQzLjE3MDI3N10gW2Ry bTppbnRlbF9kdW1wX2NkY2xrX3N0YXRlIFtpOTE1XV0gW2h3IHN0YXRlXSAzMzc1MDAga0h6LCBW Q08gODEwMDAwMCBrSHosIHJlZiAyNDAwMCBrSHosIGJ5cGFzcyAyNDAwMCBrSHosIHZvbHRhZ2Ug bGV2ZWwgMAo+ID4gWyAgIDQzLjE4MjU2Nl0gW2RybTppbnRlbF9kdW1wX2NkY2xrX3N0YXRlIFtp OTE1XV0gW3N3IHN0YXRlXSAzMDg1NzEga0h6LCBWQ08gODY0MDAwMCBrSHosIHJlZiAyNDAwMCBr SHosIGJ5cGFzcyAyNDAwMCBrSHosIHZvbHRhZ2UgbGV2ZWwgMAo+ID4gCj4gPiB2MjogTW92ZSB0 aGUgZW50aXJlIGVEUCdzIHZjbyBsb2dpY2FsIGFkanVzdG1lbnQgdG8gaW5zaWRlCj4gPiAgICAg dGhlIHNrbF9tb2Rlc2V0X2NhbGNfY2RjbGsgYXMgc3VnZ2VzdGVkIGJ5IFZpbGxlLgo+ID4gCj4g PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgfCA0MSArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMgICAgfCAyMCAtLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgMiBmaWxlcyBjaGFu Z2VkLCAzNyBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jZGNsay5jCj4gPiBpbmRleCAzMmQyNGM2OWRhM2MuLjcwNGRkYjRkM2NhNyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+IEBAIC0yMzAyLDkgKzIz MDIsNDQgQEAgc3RhdGljIGludCBiZHdfbW9kZXNldF9jYWxjX2NkY2xrKHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSkKPiA+ICAJcmV0dXJuIDA7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRp YyBpbnQgc2tsX2RwbGwwX3ZjbyhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICppbnRlbF9zdGF0 ZSkKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5 MTUoaW50ZWxfc3RhdGUtPmJhc2UuZGV2KTsKPiA+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGM7 Cj4gPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4gKwlpbnQgdmNv LCBpOwo+ID4gKwo+ID4gKwl2Y28gPSBpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC52Y287Cj4g PiArCWlmICghdmNvKQo+ID4gKwkJdmNvID0gZGV2X3ByaXYtPnNrbF9wcmVmZXJyZWRfdmNvX2Zy ZXE7Cj4gPiArCj4gPiArCWZvcl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlKGludGVsX3N0 YXRlLCBjcnRjLCBjcnRjX3N0YXRlLCBpKSB7Cj4gPiArCQlpZiAoIWNydGNfc3RhdGUtPmJhc2Uu ZW5hYmxlKQo+ID4gKwkJCWNvbnRpbnVlOwo+ID4gKwo+ID4gKwkJaWYgKCFpbnRlbF9jcnRjX2hh c190eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9FRFApKQo+ID4gKwkJCWNvbnRpbnVlOwo+ ID4gKwo+ID4gKwkJLyoKPiA+ICsJCSAqIERQTEwwIFZDTyBtYXkgbmVlZCB0byBiZSBhZGp1c3Rl ZCB0byBnZXQgdGhlIGNvcnJlY3QKPiA+ICsJCSAqIGNsb2NrIGZvciBlRFAuIFRoaXMgd2lsbCBh ZmZlY3QgY2RjbGsgYXMgd2VsbC4KPiA+ICsJCSAqLwo+ID4gKwkJc3dpdGNoIChjcnRjX3N0YXRl LT5wb3J0X2Nsb2NrIC8gMikgewo+ID4gKwkJY2FzZSAxMDgwMDA6Cj4gPiArCQljYXNlIDIxNjAw MDoKPiA+ICsJCQl2Y28gPSA4NjQwMDAwOwo+ID4gKwkJCWJyZWFrOwo+ID4gKwkJZGVmYXVsdDoK PiA+ICsJCQl2Y28gPSA4MTAwMDAwOwo+ID4gKwkJCWJyZWFrOwo+ID4gKwkJfQo+ID4gKwl9Cj4g PiArCj4gPiArCXJldHVybiB2Y287Cj4gPiArfQo+IAo+IFllcC4gSSB0aGluayB0aGlzIHNob3Vs ZCBkbyB0aGUgcmlnaHQgdGhpbmcuIEZvciB0aGUgdGltZXMgd2hlbiB0aGUgcGlwZQo+IGRyaXZp bmcgZURQIGlzbid0IHBhcnQgb2YgdGhlIGF0b21pYyBzdGF0ZSB3ZSB3aWwgc2ltcGx5IHByZXNl cnZlIHRoZQo+IGN1cnJlbnQgdmNvIHNldHRpbmcuIFRoYXQgbWVhbnMgb3RoZXIgcGlwZXMgY2Fu J3QgYWN0dWFsbHkgbWFrZSBhIG1lc3MKPiBvZiB0aGUgRFBMTDAgVkNPIHdoaWxlIGVEUCBkZXBl bmRzIG9uIGl0Lgo+IAo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgoKVGhhbmtzIGZvciB0aGUgc3VnZ2VzdGlvbnMuCgpTbywgb24g c2V0dGluZyB0aGUgZXhhbXBsZXMgb2Ygd2hhdCAqbm90KiB0byBkbzogSSBmb3Jnb3QgdG8gaW5j bHVkZQpGaXhlczogYW5kIGNjIHN0YWJsZS4KCkx1Y2tpbHkgSSByZW1lbWJlcmVkIGJlZm9yZSBw dXNoaW5nLiBTbywKCkZpeGVzOiBiYjBmNGFhYjBlNzYgKCJkcm0vaTkxNTogVHJhY2sgZnVsbCBj ZGNsayBzdGF0ZSBmb3IgdGhlIGxvZ2ljYWwgYW5kIGFjdHVhbCBjZGNsayBmcmVxdWVuY2llcyIp CkNjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMisKCnNlZW1zIHJpZ2h0IGZvciB5 b3U/Cgo+IAo+ID4gKwo+ID4gIHN0YXRpYyBpbnQgc2tsX21vZGVzZXRfY2FsY19jZGNsayhzdHJ1 Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgewo+ID4gLQlzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHN0YXRlLT5kZXYpOwo+ID4gIAlzdHJ1Y3QgaW50 ZWxfYXRvbWljX3N0YXRlICppbnRlbF9zdGF0ZSA9IHRvX2ludGVsX2F0b21pY19zdGF0ZShzdGF0 ZSk7Cj4gPiAgCWludCBtaW5fY2RjbGssIGNkY2xrLCB2Y287Cj4gPiAgCj4gPiBAQCAtMjMxMiw5 ICsyMzQ3LDcgQEAgc3RhdGljIGludCBza2xfbW9kZXNldF9jYWxjX2NkY2xrKHN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAJaWYgKG1pbl9jZGNsayA8IDApCj4gPiAgCQlyZXR1 cm4gbWluX2NkY2xrOwo+ID4gIAo+ID4gLQl2Y28gPSBpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNh bC52Y287Cj4gPiAtCWlmICghdmNvKQo+ID4gLQkJdmNvID0gZGV2X3ByaXYtPnNrbF9wcmVmZXJy ZWRfdmNvX2ZyZXE7Cj4gPiArCXZjbyA9IHNrbF9kcGxsMF92Y28oaW50ZWxfc3RhdGUpOwo+ID4g IAo+ID4gIAkvKgo+ID4gIAkgKiBGSVhNRSBzaG91bGQgYWxzbyBhY2NvdW50IGZvciBwbGFuZSBy YXRpbwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBpbmRleCA4M2RhNTBiMTNkODEuLmRk ZTkyZTRhZjVkMyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IEBAIC0xOTI5 LDI2ICsxOTI5LDYgQEAgaW50ZWxfZHBfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2VuY29k ZXIgKmVuY29kZXIsCj4gPiAgCQkJCQkgICAgICAgcmVkdWNlX21fbik7Cj4gPiAgCX0KPiA+ICAK PiA+IC0JLyoKPiA+IC0JICogRFBMTDAgVkNPIG1heSBuZWVkIHRvIGJlIGFkanVzdGVkIHRvIGdl dCB0aGUgY29ycmVjdAo+ID4gLQkgKiBjbG9jayBmb3IgZURQLiBUaGlzIHdpbGwgYWZmZWN0IGNk Y2xrIGFzIHdlbGwuCj4gPiAtCSAqLwo+ID4gLQlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2Rw KSAmJiBJU19HRU45X0JDKGRldl9wcml2KSkgewo+ID4gLQkJaW50IHZjbzsKPiA+IC0KPiA+IC0J CXN3aXRjaCAocGlwZV9jb25maWctPnBvcnRfY2xvY2sgLyAyKSB7Cj4gPiAtCQljYXNlIDEwODAw MDoKPiA+IC0JCWNhc2UgMjE2MDAwOgo+ID4gLQkJCXZjbyA9IDg2NDAwMDA7Cj4gPiAtCQkJYnJl YWs7Cj4gPiAtCQlkZWZhdWx0Ogo+ID4gLQkJCXZjbyA9IDgxMDAwMDA7Cj4gPiAtCQkJYnJlYWs7 Cj4gPiAtCQl9Cj4gPiAtCj4gPiAtCQl0b19pbnRlbF9hdG9taWNfc3RhdGUocGlwZV9jb25maWct PmJhc2Uuc3RhdGUpLT5jZGNsay5sb2dpY2FsLnZjbyA9IHZjbzsKPiA+IC0JfQo+ID4gLQo+ID4g IAlpZiAoIUhBU19EREkoZGV2X3ByaXYpKQo+ID4gIAkJaW50ZWxfZHBfc2V0X2Nsb2NrKGVuY29k ZXIsIHBpcGVfY29uZmlnKTsKPiA+ICAKPiA+IC0tIAo+ID4gMi4xMy42Cj4gCj4gLS0gCj4gVmls bGUgU3lyasOkbMOkCj4gSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==