From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place. Date: Thu, 3 May 2018 16:17:24 +0300 Message-ID: <20180503131724.GR23723@intel.com> References: <20180502140316.GG23723@intel.com> <20180502175255.5344-1-rodrigo.vivi@intel.com> <20180502191251.GO23723@intel.com> <20180503130745.GA2054@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id C36F66E17C for ; Thu, 3 May 2018 13:17:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180503130745.GA2054@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDMsIDIwMTggYXQgMDY6MDc6NDVBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFdlZCwgTWF5IDAyLCAyMDE4IGF0IDEwOjEyOjUxUE0gKzAzMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+IE9uIFdlZCwgTWF5IDAyLCAyMDE4IGF0IDEwOjUyOjU1QU0gLTA3 MDAsIFJvZHJpZ28gVml2aSB3cm90ZToKPiA+ID4gT24gaW50ZWxfZHBfY29tcHV0ZV9jb25maWco KSB3ZSB3ZXJlIGNhbGN1bGF0aW5nIHRoZSBuZWVkZWQgdmNvCj4gPiA+IGZvciBlRFAgb24gZ2Vu OSBhbmQgd2Ugc3Rhc2hpbmcgaXQgaW4KPiA+ID4gaW50ZWxfYXRvbWljX3N0YXRlLmNkY2xrLmxv Z2ljYWwudmNvCj4gPiA+IAo+ID4gPiBIb3dldmVyIGZldyBtb21lbnRzIGxhdGVyIG9uIGludGVs X21vZGVzZXRfY2hlY2tzKCkgd2UgZnVsbHkKPiA+ID4gcmVwbGFjZSBlbnRpcmUgaW50ZWxfYXRv bWljX3N0YXRlLmNkY2xrLmxvZ2ljYWwgd2l0aAo+ID4gPiBkZXZfcHJpdi0+Y2RjbGsubG9naWNh bCBmdWxseSBvdmVyd3JpdGluZyB0aGUgbG9naWNhbCBkZXNpcmVkCj4gPiA+IHZjbyBmb3IgZURQ IG9uIGdlbjkuCj4gPiA+IAo+ID4gPiBTbywgd2l0aCB3cm9uZyBWQ08gdmFsdWUgd2UgZW5kIHVw IHdpdGggd3JvbmcgZGVzaXJlZCBjZGNsaywgYnV0Cj4gPiA+IGFsc28gaXQgd2lsbCByYWlzZSBh IGxvdCBvZiBXQVJOczogT24gZ2VuOSwgd2hlbiB3ZSByZWFkCj4gPiA+IENEQ0xLX0NUTCB0byB2 ZXJpZnkgaWYgd2UgY29uZmlndXJlZCBwcm9wZXJseSB0aGUgZGVzaXJlZAo+ID4gPiBmcmVxdWVu Y3kgdGhlIENEIEZyZXF1ZW5jeSBTZWxlY3QgYml0cyBbMjc6MjZdID09IDEwYiBjYW4gbWVhbgo+ ID4gPiAzMzcuNSBvciAzMDguNTcgTUh6IGRlcGVuZGluZyBvbiB0aGUgVkNPLiBTbyBpZiB3ZSBo YXZlIHdyb25nCj4gPiA+IFZDTyB2YWx1ZSBzdGFzaGVkIHdlIHdpbGwgYmVsaWV2ZSB0aGUgZnJl cXVlbmN5IHNlbGVjdGlvbiBkaWRuJ3QKPiA+ID4gc3RpY2sgYW5kIHN0YXJ0IHRvIHJhaXNlIFdB Uk5zIG9mIGNkY2xrIG1pc21hdGNoLgo+ID4gPiAKPiA+ID4gWyAgIDQyLjg1NzUxOV0gW2RybTpp bnRlbF9kdW1wX2NkY2xrX3N0YXRlIFtpOTE1XV0gQ2hhbmdpbmcgQ0RDTEsgdG8gMzA4NTcxIGtI eiwgVkNPIDg2NDAwMDAga0h6LCByZWYgMjQwMDAga0h6LCBieXBhc3MgMjQwMDAga0h6LCB2b2x0 YWdlIGxldmVsIDAKPiA+ID4gWyAgIDQyLjg5NzI2OV0gY2RjbGsgc3RhdGUgZG9lc24ndCBtYXRj aCEKPiA+ID4gWyAgIDQyLjkwMTA1Ml0gV0FSTklORzogQ1BVOiA1IFBJRDogMTExNiBhdCBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jOjIwODQgaW50ZWxfc2V0X2NkY2xrKzB4NWQv MHgxMTAgW2k5MTVdCj4gPiA+IFsgICA0Mi45MzgwMDRdIFJJUDogMDAxMDppbnRlbF9zZXRfY2Rj bGsrMHg1ZC8weDExMCBbaTkxNV0KPiA+ID4gWyAgIDQzLjE1NTI1M10gV0FSTklORzogQ1BVOiA1 IFBJRDogMTExNiBhdCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jOjIwODQgaW50 ZWxfc2V0X2NkY2xrKzB4NWQvMHgxMTAgW2k5MTVdCj4gPiA+IFsgICA0My4xNzAyNzddIFtkcm06 aW50ZWxfZHVtcF9jZGNsa19zdGF0ZSBbaTkxNV1dIFtodyBzdGF0ZV0gMzM3NTAwIGtIeiwgVkNP IDgxMDAwMDAga0h6LCByZWYgMjQwMDAga0h6LCBieXBhc3MgMjQwMDAga0h6LCB2b2x0YWdlIGxl dmVsIDAKPiA+ID4gWyAgIDQzLjE4MjU2Nl0gW2RybTppbnRlbF9kdW1wX2NkY2xrX3N0YXRlIFtp OTE1XV0gW3N3IHN0YXRlXSAzMDg1NzEga0h6LCBWQ08gODY0MDAwMCBrSHosIHJlZiAyNDAwMCBr SHosIGJ5cGFzcyAyNDAwMCBrSHosIHZvbHRhZ2UgbGV2ZWwgMAo+ID4gPiAKPiA+ID4gdjI6IE1v dmUgdGhlIGVudGlyZSBlRFAncyB2Y28gbG9naWNhbCBhZGp1c3RtZW50IHRvIGluc2lkZQo+ID4g PiAgICAgdGhlIHNrbF9tb2Rlc2V0X2NhbGNfY2RjbGsgYXMgc3VnZ2VzdGVkIGJ5IFZpbGxlLgo+ ID4gPiAKPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu dGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNs ay5jIHwgNDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiA+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgfCAyMCAtLS0tLS0tLS0tLS0tLS0tLS0t Cj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygt KQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nk Y2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gPiA+IGluZGV4IDMy ZDI0YzY5ZGEzYy4uNzA0ZGRiNGQzY2E3IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2NkY2xrLmMKPiA+ID4gQEAgLTIzMDIsOSArMjMwMiw0NCBAQCBzdGF0aWMgaW50IGJkd19t b2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gPiAg CXJldHVybiAwOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgaW50IHNrbF9kcGxsMF92 Y28oc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3RhdGUpCj4gPiA+ICt7Cj4gPiA+ ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShpbnRlbF9zdGF0 ZS0+YmFzZS5kZXYpOwo+ID4gPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ID4gPiArCXN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4gPiArCWludCB2Y28sIGk7Cj4g PiA+ICsKPiA+ID4gKwl2Y28gPSBpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC52Y287Cj4gPiA+ ICsJaWYgKCF2Y28pCj4gPiA+ICsJCXZjbyA9IGRldl9wcml2LT5za2xfcHJlZmVycmVkX3Zjb19m cmVxOwo+ID4gPiArCj4gPiA+ICsJZm9yX2VhY2hfbmV3X2ludGVsX2NydGNfaW5fc3RhdGUoaW50 ZWxfc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPiA+ID4gKwkJaWYgKCFjcnRjX3N0YXRl LT5iYXNlLmVuYWJsZSkKPiA+ID4gKwkJCWNvbnRpbnVlOwo+ID4gPiArCj4gPiA+ICsJCWlmICgh aW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfRURQKSkKPiA+ID4g KwkJCWNvbnRpbnVlOwo+ID4gPiArCj4gPiA+ICsJCS8qCj4gPiA+ICsJCSAqIERQTEwwIFZDTyBt YXkgbmVlZCB0byBiZSBhZGp1c3RlZCB0byBnZXQgdGhlIGNvcnJlY3QKPiA+ID4gKwkJICogY2xv Y2sgZm9yIGVEUC4gVGhpcyB3aWxsIGFmZmVjdCBjZGNsayBhcyB3ZWxsLgo+ID4gPiArCQkgKi8K PiA+ID4gKwkJc3dpdGNoIChjcnRjX3N0YXRlLT5wb3J0X2Nsb2NrIC8gMikgewo+ID4gPiArCQlj YXNlIDEwODAwMDoKPiA+ID4gKwkJY2FzZSAyMTYwMDA6Cj4gPiA+ICsJCQl2Y28gPSA4NjQwMDAw Owo+ID4gPiArCQkJYnJlYWs7Cj4gPiA+ICsJCWRlZmF1bHQ6Cj4gPiA+ICsJCQl2Y28gPSA4MTAw MDAwOwo+ID4gPiArCQkJYnJlYWs7Cj4gPiA+ICsJCX0KPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4g KwlyZXR1cm4gdmNvOwo+ID4gPiArfQo+ID4gCj4gPiBZZXAuIEkgdGhpbmsgdGhpcyBzaG91bGQg ZG8gdGhlIHJpZ2h0IHRoaW5nLiBGb3IgdGhlIHRpbWVzIHdoZW4gdGhlIHBpcGUKPiA+IGRyaXZp bmcgZURQIGlzbid0IHBhcnQgb2YgdGhlIGF0b21pYyBzdGF0ZSB3ZSB3aWwgc2ltcGx5IHByZXNl cnZlIHRoZQo+ID4gY3VycmVudCB2Y28gc2V0dGluZy4gVGhhdCBtZWFucyBvdGhlciBwaXBlcyBj YW4ndCBhY3R1YWxseSBtYWtlIGEgbWVzcwo+ID4gb2YgdGhlIERQTEwwIFZDTyB3aGlsZSBlRFAg ZGVwZW5kcyBvbiBpdC4KPiA+IAo+ID4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gVGhhbmtzIGZvciB0aGUgc3VnZ2VzdGlv bnMuCj4gCj4gU28sIG9uIHNldHRpbmcgdGhlIGV4YW1wbGVzIG9mIHdoYXQgKm5vdCogdG8gZG86 IEkgZm9yZ290IHRvIGluY2x1ZGUKPiBGaXhlczogYW5kIGNjIHN0YWJsZS4KPiAKPiBMdWNraWx5 IEkgcmVtZW1iZXJlZCBiZWZvcmUgcHVzaGluZy4gU28sCj4gCj4gRml4ZXM6IGJiMGY0YWFiMGU3 NiAoImRybS9pOTE1OiBUcmFjayBmdWxsIGNkY2xrIHN0YXRlIGZvciB0aGUgbG9naWNhbCBhbmQg YWN0dWFsIGNkY2xrIGZyZXF1ZW5jaWVzIikKPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ ICMgdjQuMTIrCj4gCj4gc2VlbXMgcmlnaHQgZm9yIHlvdT8KClllYWgsIHRoYXQgbG9va3MgbGlr ZSB0aGUgb25lIHRvIGJsYW1lLgoKPiAKPiA+IAo+ID4gPiArCj4gPiA+ICBzdGF0aWMgaW50IHNr bF9tb2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4g PiAgewo+ID4gPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo c3RhdGUtPmRldik7Cj4gPiA+ICAJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqaW50ZWxfc3Rh dGUgPSB0b19pbnRlbF9hdG9taWNfc3RhdGUoc3RhdGUpOwo+ID4gPiAgCWludCBtaW5fY2RjbGss IGNkY2xrLCB2Y287Cj4gPiA+ICAKPiA+ID4gQEAgLTIzMTIsOSArMjM0Nyw3IEBAIHN0YXRpYyBp bnQgc2tsX21vZGVzZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUp Cj4gPiA+ICAJaWYgKG1pbl9jZGNsayA8IDApCj4gPiA+ICAJCXJldHVybiBtaW5fY2RjbGs7Cj4g PiA+ICAKPiA+ID4gLQl2Y28gPSBpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC52Y287Cj4gPiA+ IC0JaWYgKCF2Y28pCj4gPiA+IC0JCXZjbyA9IGRldl9wcml2LT5za2xfcHJlZmVycmVkX3Zjb19m cmVxOwo+ID4gPiArCXZjbyA9IHNrbF9kcGxsMF92Y28oaW50ZWxfc3RhdGUpOwo+ID4gPiAgCj4g PiA+ICAJLyoKPiA+ID4gIAkgKiBGSVhNRSBzaG91bGQgYWxzbyBhY2NvdW50IGZvciBwbGFuZSBy YXRpbwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gaW5kZXggODNkYTUwYjEzZDgx Li5kZGU5MmU0YWY1ZDMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4g PiBAQCAtMTkyOSwyNiArMTkyOSw2IEBAIGludGVsX2RwX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBp bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gPiAgCQkJCQkgICAgICAgcmVkdWNlX21fbik7Cj4g PiA+ICAJfQo+ID4gPiAgCj4gPiA+IC0JLyoKPiA+ID4gLQkgKiBEUExMMCBWQ08gbWF5IG5lZWQg dG8gYmUgYWRqdXN0ZWQgdG8gZ2V0IHRoZSBjb3JyZWN0Cj4gPiA+IC0JICogY2xvY2sgZm9yIGVE UC4gVGhpcyB3aWxsIGFmZmVjdCBjZGNsayBhcyB3ZWxsLgo+ID4gPiAtCSAqLwo+ID4gPiAtCWlm IChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApICYmIElTX0dFTjlfQkMoZGV2X3ByaXYpKSB7Cj4g PiA+IC0JCWludCB2Y287Cj4gPiA+IC0KPiA+ID4gLQkJc3dpdGNoIChwaXBlX2NvbmZpZy0+cG9y dF9jbG9jayAvIDIpIHsKPiA+ID4gLQkJY2FzZSAxMDgwMDA6Cj4gPiA+IC0JCWNhc2UgMjE2MDAw Ogo+ID4gPiAtCQkJdmNvID0gODY0MDAwMDsKPiA+ID4gLQkJCWJyZWFrOwo+ID4gPiAtCQlkZWZh dWx0Ogo+ID4gPiAtCQkJdmNvID0gODEwMDAwMDsKPiA+ID4gLQkJCWJyZWFrOwo+ID4gPiAtCQl9 Cj4gPiA+IC0KPiA+ID4gLQkJdG9faW50ZWxfYXRvbWljX3N0YXRlKHBpcGVfY29uZmlnLT5iYXNl LnN0YXRlKS0+Y2RjbGsubG9naWNhbC52Y28gPSB2Y287Cj4gPiA+IC0JfQo+ID4gPiAtCj4gPiA+ ICAJaWYgKCFIQVNfRERJKGRldl9wcml2KSkKPiA+ID4gIAkJaW50ZWxfZHBfc2V0X2Nsb2NrKGVu Y29kZXIsIHBpcGVfY29uZmlnKTsKPiA+ID4gIAo+ID4gPiAtLSAKPiA+ID4gMi4xMy42Cj4gPiAK PiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBJbnRlbAoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK