From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/5] drm/rect: Handle rounding errors in
 drm_rect_clip_scaled, v3.
Date: Thu, 3 May 2018 16:29:03 +0300
Message-ID: <20180503132903.GT23723@intel.com>
References: <20180503112217.37292-1-maarten.lankhorst@linux.intel.com>
 <20180503112217.37292-3-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180503112217.37292-3-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBNYXkgMDMsIDIwMTggYXQgMDE6MjI6MTRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gSW5zdGVhZCBvZiByZWx5aW5nIG9uIGEgc2NhbGUgd2hpY2ggbWF5IGluY3Jl
YXNlIHJvdW5kaW5nIGVycm9ycywKPiBjbGlwIHNyYyBieSBkb2luZzogc3JjICogKGRzdCAtIGNs
aXApIC8gZHN0IGFuZCByb3VuZGluZyB0aGUgcmVzdWx0Cj4gYXdheSBmcm9tIDEsIHNvIHRoZSBu
ZXcgY29vcmRpbmF0ZXMgZ2V0IGNsb3NlciB0byAxLiBXZSB3b24ndCBuZWVkCj4gdG8gZml4IHVw
IHdpdGggYSBtYWdpYyBtYWNybyBhZnRlcndhcmRzLCBiZWNhdXNlIG91ciBzY2FsaW5nIGZhY3Rv
cgo+IHdpbGwgbmV2ZXIgZ28gdG8gdGhlIG90aGVyIHNpZGUgb2YgMS4KPiAKPiBDaGFuZ2VzIHNp
bmNlIHYxOgo+IC0gQWRqdXN0IGRzdCBpbW1lZGlhdGVseSwgZWxzZSBkcm1fcmVjdF93aWR0aC9o
ZWlnaHQgb24gZHN0IGdpdmVzIGJvZ3VzCj4gICByZXN1bHRzLgo+IENoYW5nZSBzaW5jZSB2MjoK
PiAtIEdldCByaWQgb2YgbWFjcm9zIGFuZCB1c2UgNjQtYml0cyBtYXRoLgo+IAo+IFNpZ25lZC1v
ZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5j
b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgIDIgKy0K
PiAgZHJpdmVycy9ncHUvZHJtL2RybV9yZWN0LmMgICAgICAgICAgfCA0NSArKysrKysrKysrKysr
KysrKysrKy0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8
ICAyICstCj4gIGluY2x1ZGUvZHJtL2RybV9yZWN0LmggICAgICAgICAgICAgIHwgIDMgKy0KPiAg
NCBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJz
L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IDljYjIyMDlmNmZjOC4uMTMwZGE1
MTk1ZjNiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5j
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtNzY2LDcg
Kzc2Niw3IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19wbGFuZV9zdGF0ZShzdHJ1Y3Qg
ZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSwKPiAgCWlmIChjcnRjX3N0YXRlLT5lbmFibGUp
Cj4gIAkJZHJtX21vZGVfZ2V0X2h2X3RpbWluZygmY3J0Y19zdGF0ZS0+bW9kZSwgJmNsaXAueDIs
ICZjbGlwLnkyKTsKPiAgCj4gLQlwbGFuZV9zdGF0ZS0+dmlzaWJsZSA9IGRybV9yZWN0X2NsaXBf
c2NhbGVkKHNyYywgZHN0LCAmY2xpcCwgaHNjYWxlLCB2c2NhbGUpOwo+ICsJcGxhbmVfc3RhdGUt
PnZpc2libGUgPSBkcm1fcmVjdF9jbGlwX3NjYWxlZChzcmMsIGRzdCwgJmNsaXApOwo+ICAKPiAg
CWRybV9yZWN0X3JvdGF0ZV9pbnYoc3JjLCBmYi0+d2lkdGggPDwgMTYsIGZiLT5oZWlnaHQgPDwg
MTYsIHJvdGF0aW9uKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcmVj
dC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9yZWN0LmMKPiBpbmRleCA0NzM1NTI2Mjk3YWEuLmY0
NzcwNjNmMThlYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3JlY3QuYwo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcmVjdC5jCj4gQEAgLTUwLDEzICs1MCwyMSBAQCBib29s
IGRybV9yZWN0X2ludGVyc2VjdChzdHJ1Y3QgZHJtX3JlY3QgKnIxLCBjb25zdCBzdHJ1Y3QgZHJt
X3JlY3QgKnIyKQo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX3JlY3RfaW50ZXJzZWN0KTsKPiAg
Cj4gK3N0YXRpYyB1MzIgY2xpcF9zY2FsZWQodTMyIHNyYywgdTMyIGRzdCwgdTMyIGNsaXApCj4g
K3sKPiArCXU2NCBuZXdzcmMgPSBtdWxfdTMyX3UzMihzcmMsIGRzdCAtIGNsaXApOwoKJ25ld3Ny
YycgZmVlbHMgc2xpZ2h0bHkgbWlzbGVhZGluZy4gSXQgd291bGQgYmUgYSBkZWNlbnQgbmFtZSBm
b3IKdGhlIGZpbmFsIHJldHVybiB2YWx1ZSBvZiB0aGUgZnVuY3Rpb24sIGJ1dCBmb3IgdGhpcyBp
bnRlcm1lZGlhdGUKdmFsdWUgJ3RtcCcgb3Igc29tZXRoaW5nIGVxdWFsbHkgbm9uIHNwZWNpZmlj
IG1pZ2h0IGJlIGJldHRlci4KCj4gKwo+ICsJaWYgKHNyYyA8IChkc3QgPDwgMTYpKQo+ICsJCXJl
dHVybiBESVZfUk9VTkRfVVBfVUxMKG5ld3NyYywgZHN0KTsKPiArCWVsc2UKPiArCQlyZXR1cm4g
RElWX1JPVU5EX0RPV05fVUxMKG5ld3NyYywgZHN0KTsKCkkgdGhpbmsgd2UgY291bGQgdXNlIGEg
Y29tbWVudCBoZXJlIHRvIGV4cGxhaW4gdGhlIGNob2ljZSBvZgpyb3VuZGluZyBkaXJlY3Rpb24u
IEVnLgoKLyoKICogUm91bmQgdG93YXJkIDEuMCB3aGVuIGNsaXBwaW5nIHNvIHRoYXQgd2UgZG9u
J3QgYWNjaWRlbnRhbGx5CiAqIGNoYW5nZSB1cHNjYWxpbmcgdG8gZG93bnNjYWxpbmcgb3Igdmlj
ZSB2ZXJzYS4KICovCj8KCj4gK30KPiArCj4gIC8qKgo+ICAgKiBkcm1fcmVjdF9jbGlwX3NjYWxl
ZCAtIHBlcmZvcm0gYSBzY2FsZWQgY2xpcCBvcGVyYXRpb24KPiAgICogQHNyYzogc291cmNlIHdp
bmRvdyByZWN0YW5nbGUKPiAgICogQGRzdDogZGVzdGluYXRpb24gd2luZG93IHJlY3RhbmdsZQo+
ICAgKiBAY2xpcDogY2xpcCByZWN0YW5nbGUKPiAtICogQGhzY2FsZTogaG9yaXpvbnRhbCBzY2Fs
aW5nIGZhY3Rvcgo+IC0gKiBAdnNjYWxlOiB2ZXJ0aWNhbCBzY2FsaW5nIGZhY3Rvcgo+ICAgKgo+
ICAgKiBDbGlwIHJlY3RhbmdsZSBAZHN0IGJ5IHJlY3RhbmdsZSBAY2xpcC4gQ2xpcCByZWN0YW5n
bGUgQHNyYyBieSB0aGUKPiAgICogc2FtZSBhbW91bnRzIG11bHRpcGxpZWQgYnkgQGhzY2FsZSBh
bmQgQHZzY2FsZS4KPiBAQCAtNjYsMzMgKzc0LDQ0IEBAIEVYUE9SVF9TWU1CT0woZHJtX3JlY3Rf
aW50ZXJzZWN0KTsKPiAgICogJWZhbHNlIG90aGVyd2lzZQo+ICAgKi8KPiAgYm9vbCBkcm1fcmVj
dF9jbGlwX3NjYWxlZChzdHJ1Y3QgZHJtX3JlY3QgKnNyYywgc3RydWN0IGRybV9yZWN0ICpkc3Qs
Cj4gLQkJCSAgY29uc3Qgc3RydWN0IGRybV9yZWN0ICpjbGlwLAo+IC0JCQkgIGludCBoc2NhbGUs
IGludCB2c2NhbGUpCj4gKwkJCSAgY29uc3Qgc3RydWN0IGRybV9yZWN0ICpjbGlwKQo+ICB7Cj4g
IAlpbnQgZGlmZjsKPiAgCj4gIAlkaWZmID0gY2xpcC0+eDEgLSBkc3QtPngxOwo+ICAJaWYgKGRp
ZmYgPiAwKSB7Cj4gLQkJaW50NjRfdCB0bXAgPSBzcmMtPngxICsgKGludDY0X3QpIGRpZmYgKiBo
c2NhbGU7Cj4gLQkJc3JjLT54MSA9IGNsYW1wX3QoaW50NjRfdCwgdG1wLCBJTlRfTUlOLCBJTlRf
TUFYKTsKPiArCQl1MzIgbmV3X3NyY193ID0gY2xpcF9zY2FsZWQoZHJtX3JlY3Rfd2lkdGgoc3Jj
KSwKPiArCQkJCQkgICAgZHJtX3JlY3Rfd2lkdGgoZHN0KSwgZGlmZik7CgpDb3VsZCBoYXZlIHBy
ZWNvbXB1dGVkIHRoZSBzcmMvZHN0IHdpZHRoL2hlaWdodCB1cGZyb250IG1heWJlLgoKT2gsIEkg
Z3Vlc3MgeW91IGNhbid0IHNpbmNlIHlvdXIgY2xpcF9zY2FsZWQoKSB1c2VzIHRoZSBkc3Qgd2lk
dGgvaGVpZ2h0CmZvciBtb3JlIHRoYW4gdGhlIHNjYWxpbmcgZmFjdG9yLiBJZiBpdCBqdXN0IGNv
bXB1dGVkIGRpZmYqc3JjL2RzdApsaWtlIHRoZSBvcmlnaW5hbCBjb2RlIGRvZXMgdGhlbiBwcmVj
b21wdXRpbmcgd291bGQgd29yayBqdXN0IGZpbmUuCgpZb3VyIHdheSBmZWVscyBhIGJpdCBtb3Jl
IGNvbXBsaWNhdGVkIHRvIG1lLCBidXQgbG9va3MgbGlrZSBpdCBzaG91bGQKd29yay4KClJldmll
d2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoK
PiArCj4gKwkJc3JjLT54MSA9IGNsYW1wX3QoaW50NjRfdCwgc3JjLT54MiAtIG5ld19zcmNfdywg
SU5UX01JTiwgSU5UX01BWCk7Cj4gKwkJZHN0LT54MSA9IGNsaXAtPngxOwo+ICAJfQo+ICAJZGlm
ZiA9IGNsaXAtPnkxIC0gZHN0LT55MTsKPiAgCWlmIChkaWZmID4gMCkgewo+IC0JCWludDY0X3Qg
dG1wID0gc3JjLT55MSArIChpbnQ2NF90KSBkaWZmICogdnNjYWxlOwo+IC0JCXNyYy0+eTEgPSBj
bGFtcF90KGludDY0X3QsIHRtcCwgSU5UX01JTiwgSU5UX01BWCk7Cj4gKwkJdTMyIG5ld19zcmNf
aCA9IGNsaXBfc2NhbGVkKGRybV9yZWN0X2hlaWdodChzcmMpLAo+ICsJCQkJCSAgICBkcm1fcmVj
dF9oZWlnaHQoZHN0KSwgZGlmZik7Cj4gKwo+ICsJCXNyYy0+eTEgPSBjbGFtcF90KGludDY0X3Qs
IHNyYy0+eTIgLSBuZXdfc3JjX2gsIElOVF9NSU4sIElOVF9NQVgpOwo+ICsJCWRzdC0+eTEgPSBj
bGlwLT55MTsKPiAgCX0KPiAgCWRpZmYgPSBkc3QtPngyIC0gY2xpcC0+eDI7Cj4gIAlpZiAoZGlm
ZiA+IDApIHsKPiAtCQlpbnQ2NF90IHRtcCA9IHNyYy0+eDIgLSAoaW50NjRfdCkgZGlmZiAqIGhz
Y2FsZTsKPiAtCQlzcmMtPngyID0gY2xhbXBfdChpbnQ2NF90LCB0bXAsIElOVF9NSU4sIElOVF9N
QVgpOwo+ICsJCXUzMiBuZXdfc3JjX3cgPSBjbGlwX3NjYWxlZChkcm1fcmVjdF93aWR0aChzcmMp
LAo+ICsJCQkJCSAgICBkcm1fcmVjdF93aWR0aChkc3QpLCBkaWZmKTsKPiArCj4gKwkJc3JjLT54
MiA9IGNsYW1wX3QoaW50NjRfdCwgc3JjLT54MSArIG5ld19zcmNfdywgSU5UX01JTiwgSU5UX01B
WCk7Cj4gKwkJZHN0LT54MiA9IGNsaXAtPngyOwo+ICAJfQo+ICAJZGlmZiA9IGRzdC0+eTIgLSBj
bGlwLT55MjsKPiAgCWlmIChkaWZmID4gMCkgewo+IC0JCWludDY0X3QgdG1wID0gc3JjLT55MiAt
IChpbnQ2NF90KSBkaWZmICogdnNjYWxlOwo+IC0JCXNyYy0+eTIgPSBjbGFtcF90KGludDY0X3Qs
IHRtcCwgSU5UX01JTiwgSU5UX01BWCk7Cj4gKwkJdTMyIG5ld19zcmNfaCA9IGNsaXBfc2NhbGVk
KGRybV9yZWN0X2hlaWdodChzcmMpLAo+ICsJCQkJCSAgICBkcm1fcmVjdF9oZWlnaHQoZHN0KSwg
ZGlmZik7Cj4gKwo+ICsJCXNyYy0+eTIgPSBjbGFtcF90KGludDY0X3QsIHNyYy0+eTEgKyBuZXdf
c3JjX2gsIElOVF9NSU4sIElOVF9NQVgpOwo+ICsJCWRzdC0+eTIgPSBjbGlwLT55MjsKPiAgCX0K
PiAgCj4gLQlyZXR1cm4gZHJtX3JlY3RfaW50ZXJzZWN0KGRzdCwgY2xpcCk7Cj4gKwlyZXR1cm4g
ZHJtX3JlY3RfdmlzaWJsZShkc3QpOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX3JlY3RfY2xp
cF9zY2FsZWQpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
c3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGFh
MWRmYWE2OTJiOS4uNDRkN2FjYTIyMmIwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3By
aXRlLmMKPiBAQCAtMTAwOCw3ICsxMDA4LDcgQEAgaW50ZWxfY2hlY2tfc3ByaXRlX3BsYW5lKHN0
cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gIAkJZHJtX21vZGVfZ2V0X2h2X3RpbWluZygmY3J0
Y19zdGF0ZS0+YmFzZS5tb2RlLAo+ICAJCQkJICAgICAgICZjbGlwLngyLCAmY2xpcC55Mik7Cj4g
IAo+IC0Jc3RhdGUtPmJhc2UudmlzaWJsZSA9IGRybV9yZWN0X2NsaXBfc2NhbGVkKHNyYywgZHN0
LCAmY2xpcCwgaHNjYWxlLCB2c2NhbGUpOwo+ICsJc3RhdGUtPmJhc2UudmlzaWJsZSA9IGRybV9y
ZWN0X2NsaXBfc2NhbGVkKHNyYywgZHN0LCAmY2xpcCk7Cj4gIAo+ICAJY3J0Y194ID0gZHN0LT54
MTsKPiAgCWNydGNfeSA9IGRzdC0+eTE7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9y
ZWN0LmggYi9pbmNsdWRlL2RybS9kcm1fcmVjdC5oCj4gaW5kZXggNDRiYzEyMmI5ZWUwLi42YzU0
NTQ0YTRiZTcgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX3JlY3QuaAo+ICsrKyBiL2lu
Y2x1ZGUvZHJtL2RybV9yZWN0LmgKPiBAQCAtMTc1LDggKzE3NSw3IEBAIHN0YXRpYyBpbmxpbmUg
Ym9vbCBkcm1fcmVjdF9lcXVhbHMoY29uc3Qgc3RydWN0IGRybV9yZWN0ICpyMSwKPiAgCj4gIGJv
b2wgZHJtX3JlY3RfaW50ZXJzZWN0KHN0cnVjdCBkcm1fcmVjdCAqciwgY29uc3Qgc3RydWN0IGRy
bV9yZWN0ICpjbGlwKTsKPiAgYm9vbCBkcm1fcmVjdF9jbGlwX3NjYWxlZChzdHJ1Y3QgZHJtX3Jl
Y3QgKnNyYywgc3RydWN0IGRybV9yZWN0ICpkc3QsCj4gLQkJCSAgY29uc3Qgc3RydWN0IGRybV9y
ZWN0ICpjbGlwLAo+IC0JCQkgIGludCBoc2NhbGUsIGludCB2c2NhbGUpOwo+ICsJCQkgIGNvbnN0
IHN0cnVjdCBkcm1fcmVjdCAqY2xpcCk7Cj4gIGludCBkcm1fcmVjdF9jYWxjX2hzY2FsZShjb25z
dCBzdHJ1Y3QgZHJtX3JlY3QgKnNyYywKPiAgCQkJIGNvbnN0IHN0cnVjdCBkcm1fcmVjdCAqZHN0
LAo+ICAJCQkgaW50IG1pbl9oc2NhbGUsIGludCBtYXhfaHNjYWxlKTsKPiAtLSAKPiAyLjE3LjAK
Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==