All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 2/9] gst1-plugins-${base, good, bad, ugly}: bump to 1.14.0
Date: Thu, 3 May 2018 14:13:12 +0200	[thread overview]
Message-ID: <20180503141312.6c4b592e@windsurf> (raw)
In-Reply-To: <CAFSsvmqjoFRCCC5+w3f9X7HCOATyFhWCE2tzL4Xpi2kB=f04Sw@mail.gmail.com>

Hello,

On Wed, 02 May 2018 21:12:54 +0000, Adam Duskett wrote:

> > There are two issues with this patch:  
> 
> >   - You remove/rename a lot of options, but there is no Config.in.legacy
> >     handling for the options being removed/renamed.  
> 
> >   - The lame and mpg123 support is moved from plugins-ugly to
> >     plugins-good, but the corresponding options are not removed from
> >     plugins-ugly/Config.in.  
> 
> > Could you fix those issues, re-adjust the authorship for PATCH
> > 8/9 (you can do that with git commit --amend --author="..."), and send
> > an updated version of this patch series ?  
>
> I am going to have to decline. I really don't want to sit here through
> possibly several more revisions of the patch series.
> I have marked the series as rejected and anybody else is free to resubmit
> if they want.

I'm not sure I understand your decision here. There are a few things
that are obviously wrong in this v5 (lack of Config.in.legacy
handling), which are trivial to fix, and just for that reason, you give
up on the series ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-03 12:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 13:46 [Buildroot] [PATCH v5 1/9] gstreamer1: bump to 1.14.0 Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 2/9] gst1-plugins-${base, good, bad, ugly}: " Adam Duskett
2018-05-01 20:49   ` Thomas Petazzoni
2018-05-02 21:12     ` Adam Duskett
2018-05-03 12:13       ` Thomas Petazzoni [this message]
2018-05-01 13:46 ` [Buildroot] [PATCH v5 3/9] gst-omx: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 4/9] gst1-rtsp-server: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 5/9] gst1-vaapi: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 6/9] gst1-libav: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 7/9] gst1-validate: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 8/9] gstreamer1-editing-services: " Adam Duskett
2018-05-01 14:02   ` Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 9/9] gst1-imx: add hash for license file Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503141312.6c4b592e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.