From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Thu, 3 May 2018 17:05:34 +0200 Subject: [PATCH 06/17] irqchip/irq-mvebu-icu: switch to regmap In-Reply-To: <20180430155352.1b24d1d8@windsurf> References: <20180421135537.24716-1-miquel.raynal@bootlin.com> <20180421135537.24716-7-miquel.raynal@bootlin.com> <20180430155352.1b24d1d8@windsurf> Message-ID: <20180503170534.6b42510e@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thomas, Gregory, On Mon, 30 Apr 2018 15:53:52 +0200, Thomas Petazzoni wrote: > Hello, > > On Sat, 21 Apr 2018 15:55:26 +0200, Miquel Raynal wrote: > > The ICU DT nodes have now the 'syscon' compatible, we can switch to > > have now -> now have > > > regmap before splitting the code to support multiple platform devices to > > be probed (one for the ICU, one per interrupt group). > > > > Signed-off-by: Miquel Raynal > > As I explained in the review of PATCH 03/17, I think we could simply > create the regmap in the ->probe() of the parent device, instead of > using the "syscon" property, which is mainly useful when there is no > parent device. This is a much better idea than adding the 'syscon' compatible. I will work on it. > > The rest of the conversion to regmap looks good otherwise. > > Best regards, > > Thomas Thanks, Miqu?l -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 06/17] irqchip/irq-mvebu-icu: switch to regmap Date: Thu, 3 May 2018 17:05:34 +0200 Message-ID: <20180503170534.6b42510e@xps13> References: <20180421135537.24716-1-miquel.raynal@bootlin.com> <20180421135537.24716-7-miquel.raynal@bootlin.com> <20180430155352.1b24d1d8@windsurf> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180430155352.1b24d1d8@windsurf> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Thomas Petazzoni Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Marc Zyngier , Catalin Marinas , Gregory Clement , Haim Boot , Will Deacon , Maxime Chevallier , Nadav Haklai , Antoine Tenart , Rob Herring , Thomas Gleixner , Hanna Hawa , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgVGhvbWFzLCBHcmVnb3J5LAoKT24gTW9uLCAzMCBBcHIgMjAxOCAxNTo1Mzo1MiArMDIwMCwg VGhvbWFzIFBldGF6em9uaQo8dGhvbWFzLnBldGF6em9uaUBib290bGluLmNvbT4gd3JvdGU6Cgo+ IEhlbGxvLAo+IAo+IE9uIFNhdCwgMjEgQXByIDIwMTggMTU6NTU6MjYgKzAyMDAsIE1pcXVlbCBS YXluYWwgd3JvdGU6Cj4gPiBUaGUgSUNVIERUIG5vZGVzIGhhdmUgbm93IHRoZSAnc3lzY29uJyBj b21wYXRpYmxlLCB3ZSBjYW4gc3dpdGNoIHRvICAKPiAKPiBoYXZlIG5vdyAtPiBub3cgaGF2ZQo+ IAo+ID4gcmVnbWFwIGJlZm9yZSBzcGxpdHRpbmcgdGhlIGNvZGUgdG8gc3VwcG9ydCBtdWx0aXBs ZSBwbGF0Zm9ybSBkZXZpY2VzIHRvCj4gPiBiZSBwcm9iZWQgKG9uZSBmb3IgdGhlIElDVSwgb25l IHBlciBpbnRlcnJ1cHQgZ3JvdXApLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNaXF1ZWwgUmF5 bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiAgCj4gCj4gQXMgSSBleHBsYWluZWQgaW4g dGhlIHJldmlldyBvZiBQQVRDSCAwMy8xNywgSSB0aGluayB3ZSBjb3VsZCBzaW1wbHkKPiBjcmVh dGUgdGhlIHJlZ21hcCBpbiB0aGUgLT5wcm9iZSgpIG9mIHRoZSBwYXJlbnQgZGV2aWNlLCBpbnN0 ZWFkIG9mCj4gdXNpbmcgdGhlICJzeXNjb24iIHByb3BlcnR5LCB3aGljaCBpcyBtYWlubHkgdXNl ZnVsIHdoZW4gdGhlcmUgaXMgbm8KPiBwYXJlbnQgZGV2aWNlLgoKVGhpcyBpcyBhIG11Y2ggYmV0 dGVyIGlkZWEgdGhhbiBhZGRpbmcgdGhlICdzeXNjb24nIGNvbXBhdGlibGUuIEkgd2lsbAp3b3Jr IG9uIGl0LgoKPiAKPiBUaGUgcmVzdCBvZiB0aGUgY29udmVyc2lvbiB0byByZWdtYXAgbG9va3Mg Z29vZCBvdGhlcndpc2UuCj4gCj4gQmVzdCByZWdhcmRzLAo+IAo+IFRob21hcwoKVGhhbmtzLApN aXF1w6hsCgotLSAKTWlxdWVsIFJheW5hbCwgQm9vdGxpbiAoZm9ybWVybHkgRnJlZSBFbGVjdHJv bnMpCkVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGlu LmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=