From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: sandeen@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/9] libfrog: refactor fs geometry printing function
Date: Thu, 3 May 2018 14:35:39 -0700 [thread overview]
Message-ID: <20180503213539.GA26569@magnolia> (raw)
In-Reply-To: <557aeadb-c8ea-1b63-9acd-71157e10c91c@sandeen.net>
On Thu, May 03, 2018 at 04:27:28PM -0500, Eric Sandeen wrote:
> On 4/17/18 9:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Move the fs geometry printing function to libfrog so that mkfs and others
> > can share.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
>
> > + printf(_(
> > +"meta-data=%-22s isize=%-6d agcount=%u, agsize=%u blks\n"
> > +" =%-22s sectsz=%-5u attr=%u, projid32bit=%u\n"
> > +" =%-22s crc=%-8u finobt=%u, sparse=%u, rmapbt=%u\n"
> > +" =%-22s reflink=%u\n"
> > +"data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n"
> > +" =%-22s sunit=%-6u swidth=%u blks\n"
> > +"naming =version %-14u bsize=%-6u ascii-ci=%d, ftype=%d\n"
> > +"log =%-22s bsize=%-6d blocks=%u, version=%d\n"
> > +" =%-22s sectsz=%-5u sunit=%d blks, lazy-count=%d\n"
> > +"realtime =%-22s extsz=%-6d blocks=%lld, rtextents=%lld\n"),
>
> Actually, I'd like to put a whitespace break here as there was in old code,
> as this is a giant, dense blob of code that's pretty hard to grok visually.
>
> Any objection? :)
None here.
--D
> -Eric
>
> > + mntpoint, geo->inodesize, geo->agcount, geo->agblocks,
> > + "", geo->sectsize, attrversion, projid32bit,
> > + "", crcs_enabled, finobt_enabled, spinodes, rmapbt_enabled,
> > + "", reflink_enabled,
> > + "", geo->blocksize, (unsigned long long)geo->datablocks,
> > + geo->imaxpct,
> > + "", geo->sunit, geo->swidth,
> > + dirversion, geo->dirblocksize, cimode, ftype_enabled,
> > + isint ? _("internal log") : logname ? logname : _("external"),
> > + geo->blocksize, geo->logblocks, logversion,
> > + "", geo->logsectsize, geo->logsunit / geo->blocksize, lazycount,
> > + !geo->rtblocks ? _("none") : rtname ? rtname : _("external"),
> > + geo->rtextsize * geo->blocksize, (unsigned long long)geo->rtblocks,
> > + (unsigned long long)geo->rtextents);
> > +}
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-03 21:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 2:45 [PATCH 0/9] xfsprogs-4.17: geometry refactoring Darrick J. Wong
2018-04-18 2:45 ` [PATCH 1/9] libfrog: move platform specific runtime support code out of libxfs Darrick J. Wong
2018-05-03 18:23 ` Eric Sandeen
2018-04-18 2:45 ` [PATCH 2/9] libfrog: refactor fs geometry printing function Darrick J. Wong
2018-05-03 18:47 ` Eric Sandeen
2018-05-03 21:27 ` Eric Sandeen
2018-05-03 21:35 ` Darrick J. Wong [this message]
2018-04-18 2:45 ` [PATCH 3/9] mkfs: use geometry generation / helper functions Darrick J. Wong
2018-05-03 18:52 ` Eric Sandeen
2018-04-18 2:45 ` [PATCH 4/9] xfs_db: add a superblock info command Darrick J. Wong
2018-05-03 20:53 ` Eric Sandeen
2018-05-03 21:44 ` Darrick J. Wong
2018-05-23 3:30 ` [PATCH v2 " Darrick J. Wong
2018-05-23 3:57 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 5/9] xfs_spaceman: print a nicer message when the file path isn't on an xfs Darrick J. Wong
2018-05-03 20:57 ` Eric Sandeen
2018-05-23 3:31 ` [PATCH v2 " Darrick J. Wong
2018-05-23 3:58 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 6/9] xfs_spaceman: add a superblock info command Darrick J. Wong
2018-05-03 21:09 ` Eric Sandeen
2018-05-03 21:39 ` Darrick J. Wong
2018-05-08 15:24 ` Darrick J. Wong
2018-05-23 3:32 ` [PATCH v2 " Darrick J. Wong
2018-05-23 4:08 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 7/9] xfs_info: move to xfs_spaceman Darrick J. Wong
2018-05-03 21:17 ` Eric Sandeen
2018-05-03 21:48 ` Darrick J. Wong
2018-04-18 2:46 ` [PATCH 8/9] xfs_info: call xfs_db for offline filesystems Darrick J. Wong
2018-05-03 21:22 ` Eric Sandeen
2018-05-03 21:55 ` Darrick J. Wong
2018-05-23 3:33 ` [PATCH v2 " Darrick J. Wong
2018-05-23 4:36 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 9/9] xfs_growfs: refactor geometry reporting Darrick J. Wong
2018-05-03 21:25 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503213539.GA26569@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.