All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
Cc: syzbot <syzbot+4f2e5f086147d543ab03@syzkaller.appspotmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>,
	Alexey Khoroshilov <khoroshilov@ispras.ru>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] hfsplus: clean up delayed work if fill_super fails
Date: Thu, 3 May 2018 23:31:15 +0100	[thread overview]
Message-ID: <20180503223115.GD30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <dadb7856c5a0da0fa3c1f2c30f18f09fad62d45d.1525384741.git.ernesto.mnd.fernandez@gmail.com>

On Thu, May 03, 2018 at 07:08:22PM -0300, Ernesto A. Fern�ndez wrote:
> If no hidden directory exists, the hfsplus_fill_super() function will
> create it. A delayed work is then queued to sync the superblock, which
> is never canceled in case of failure. Fix this.

Wouldn't it be simpler to avoid all the crap with clearing ->s_root
on failure, letting ->put_super() take care of everything?  Or, better
yet, take cleanups into ->kill_sb(), which is always called on
superblock shutdown, ->s_root or no ->s_root...

  parent reply	other threads:[~2018-05-03 22:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 22:08 [PATCH 1/2] hfsplus: clean up delayed work if fill_super fails Ernesto A. Fernández
2018-05-03 22:10 ` [PATCH 2/2] hfsplus: always return error " Ernesto A. Fernández
2018-05-03 22:31 ` Al Viro [this message]
2018-05-08  1:48   ` [PATCH 1/2] hfsplus: clean up delayed work " Ernesto A. Fernández
2018-05-21  2:06     ` [PATCH v3] hfsplus: fix cleanup for hfsplus_fill_super() Ernesto A. Fernández

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503223115.GD30522@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=ernesto.mnd.fernandez@gmail.com \
    --cc=hch@lst.de \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=syzbot+4f2e5f086147d543ab03@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.