From: Alexander Duyck <alexander.duyck@gmail.com>
To: netdev@vger.kernel.org, willemb@google.com, davem@davemloft.net
Subject: [net-next PATCH 1/5] udp: Record gso_segs when supporting UDP segmentation offload
Date: Thu, 03 May 2018 17:33:21 -0700 [thread overview]
Message-ID: <20180504003321.4496.34585.stgit@localhost.localdomain> (raw)
In-Reply-To: <20180504002817.4496.64616.stgit@localhost.localdomain>
From: Alexander Duyck <alexander.h.duyck@intel.com>
We need to record the number of segments that will be generated when this
frame is segmented. The expectation is that if gso_size is set then
gso_segs is set as well. Without this some drivers such as ixgbe get
confused if they attempt to offload this as they record 0 segments for the
entire packet instead of the correct value.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
net/ipv4/udp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index dd3102a37ef9..e07db83b311e 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -793,6 +793,8 @@ static int udp_send_skb(struct sk_buff *skb, struct flowi4 *fl4,
skb_shinfo(skb)->gso_size = cork->gso_size;
skb_shinfo(skb)->gso_type = SKB_GSO_UDP_L4;
+ skb_shinfo(skb)->gso_segs = DIV_ROUND_UP(len - sizeof(uh),
+ cork->gso_size);
goto csum_partial;
}
next prev parent reply other threads:[~2018-05-04 0:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 0:33 [net-next PATCH 0/5] UDP GSO Segmentation clean-ups Alexander Duyck
2018-05-04 0:33 ` Alexander Duyck [this message]
2018-05-04 1:50 ` [net-next PATCH 1/5] udp: Record gso_segs when supporting UDP segmentation offload Eric Dumazet
2018-05-04 0:33 ` [net-next PATCH 2/5] udp: Do not pass checksum or MSS as parameters Alexander Duyck
2018-05-04 1:56 ` Eric Dumazet
2018-05-04 14:27 ` Alexander Duyck
2018-05-04 0:33 ` [net-next PATCH 3/5] udp: Add support for software checksum and GSO_PARTIAL with GSO offload Alexander Duyck
2018-05-04 3:50 ` Eric Dumazet
2018-05-04 14:22 ` Alexander Duyck
2018-05-04 0:33 ` [net-next PATCH 4/5] udp: Do not copy destructor if one is not present Alexander Duyck
2018-05-04 1:58 ` Eric Dumazet
2018-05-04 14:23 ` Alexander Duyck
2018-05-04 0:33 ` [net-next PATCH 5/5] net: Add NETIF_F_GSO_UDP_L4 to list of GSO offloads with fallback Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504003321.4496.34585.stgit@localhost.localdomain \
--to=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.