All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx7s: Pass the 'fsl,sec-era' property
Date: Fri, 4 May 2018 15:19:27 +0800	[thread overview]
Message-ID: <20180504071926.GT3443@dragon> (raw)
In-Reply-To: <1524601519-23502-1-git-send-email-festevam@gmail.com>

On Tue, Apr 24, 2018 at 05:25:19PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Currently the following error is seen from the CAAM driver:
> 
> caam 30900000.caam: device ID = 0x0a16030000000000 (Era -524)
> 
> Pass the 'fsl,sec-era' property to properly describe the
> era information.
> 
> This error happens because the 'fsl,sec-era' is not passed via
> device tree.
> 
> The era information is used in various places inside drivers/crypto/caam,
> so pass the correct version via device tree.

The property is documented as optional in the bindings.  Missing the
property shouldn't cause any fatal error, I guess.

Shawn

> 
> Fixes: 0eeabcad7da5 ("ARM: dts: imx7s: add CAAM device node")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> I have sent a patch for 4.18 that allows retrieving the era information
> from the CAAM registers in run-time:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/crypto/caam/ctrl.c?h=next-20180424&id=654f2b937b389295581bcb4aa26011a63db7bc8f
> 
> This will only be applied in 4.18 though.
> 
> In order to avoid i.MX7 report the incorrect era version in 4.17,
> let's pass this property.
> 
>  arch/arm/boot/dts/imx7s.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index a6fe324..b416d2b 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -884,6 +884,7 @@
>  
>  			crypto: caam at 30900000 {
>  				compatible = "fsl,sec-v4.0";
> +				fsl,sec-era = <8>;
>  				#address-cells = <1>;
>  				#size-cells = <1>;
>  				reg = <0x30900000 0x40000>;
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-05-04  7:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 20:25 [PATCH] ARM: dts: imx7s: Pass the 'fsl,sec-era' property Fabio Estevam
2018-05-04  7:19 ` Shawn Guo [this message]
2018-05-04 16:31   ` Fabio Estevam
2018-05-07  1:17     ` Shawn Guo
2018-05-07  1:51       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504071926.GT3443@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.