From: Jonathan Tan <jonathantanmy@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>
Subject: Re: [PATCH v2 1/3] upload-pack: fix error message typo
Date: Fri, 4 May 2018 09:10:37 -0700 [thread overview]
Message-ID: <20180504091037.ff633aaa412e925d4493ab3f@google.com> (raw)
In-Reply-To: <xmqqr2mstaxk.fsf@gitster-ct.c.googlers.com>
On Fri, 04 May 2018 11:24:39 +0900
Junio C Hamano <gitster@pobox.com> wrote:
> Hmm, when somebody breaks "git server serve", we probably would not
> want to see the binary spewed to the output while debugging it. So
> I'd probably keep the redirection---it may be an improvement to use
> ">out" and then checking it is empty after the expected failure.
That's a good point - I've readded the redirection in my local copy.
I'll send out the new version if needed.
I checked the other patches and patch 3 has a similar situation but
still has the >/dev/null because I forgot to remove it when I removed it
in patch 1, so nothing needs to be changed in patch 3.
next prev parent reply other threads:[~2018-05-04 16:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 22:22 [PATCH 0/2] Supporting partial clones in protocol v2 Jonathan Tan
2018-05-01 22:22 ` [PATCH 1/2] upload-pack: fix error message typo Jonathan Tan
2018-05-01 22:25 ` Jonathan Tan
2018-05-01 22:22 ` [PATCH 2/2] {fetch,upload}-pack: support filter in protocol v2 Jonathan Tan
2018-05-01 22:36 ` Brandon Williams
2018-05-02 0:31 ` [PATCH v2 0/3] Supporting partial clones " Jonathan Tan
2018-05-02 0:31 ` [PATCH v2 1/3] upload-pack: fix error message typo Jonathan Tan
2018-05-03 18:58 ` Stefan Beller
2018-05-03 23:41 ` Jonathan Tan
2018-05-04 2:24 ` Junio C Hamano
2018-05-04 16:10 ` Jonathan Tan [this message]
2018-05-02 0:31 ` [PATCH v2 2/3] upload-pack: read config when serving protocol v2 Jonathan Tan
2018-05-03 19:08 ` Stefan Beller
2018-05-03 23:45 ` Jonathan Tan
2018-05-02 0:31 ` [PATCH v2 3/3] {fetch,upload}-pack: support filter in " Jonathan Tan
2018-05-03 20:15 ` Stefan Beller
2018-05-03 23:46 ` [PATCH v3 0/3] Supporting partial clones " Jonathan Tan
2018-05-03 23:46 ` [PATCH v3 1/3] upload-pack: fix error message typo Jonathan Tan
2018-05-03 23:46 ` [PATCH v3 2/3] upload-pack: read config when serving protocol v2 Jonathan Tan
2018-05-03 23:46 ` [PATCH v3 3/3] {fetch,upload}-pack: support filter in " Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504091037.ff633aaa412e925d4493ab3f@google.com \
--to=jonathantanmy@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.