From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Fri, 04 May 2018 13:52:39 +0000 Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-Id: <20180504105227.70c756c8@vento.lan> List-Id: References: <2542100.cElVns0SR0@amdc3058> <20180423105557.267c5ecf@vento.lan> <52576986.R85hrt8lfa@amdc3058> In-Reply-To: <52576986.R85hrt8lfa@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List Em Wed, 25 Apr 2018 12:47:34 +0200 Bartlomiej Zolnierkiewicz escreveu: > On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 14:47:28 +0200 > > Bartlomiej Zolnierkiewicz escreveu: > > > > > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > > > Add stubs for omapfb_dss.h, in the case it is included by > > > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > > > happen on ARM when DRM_OMAP is not 'n'. > > > > > > > > That allows building such driver(s) with COMPILE_TEST. > > > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > This patch should be dropped (together with patch #6/7) as it was > > > superseded by a better solution suggested by Laurent: > > > > > > https://patchwork.kernel.org/patch/10325193/ > > > > > > ACK-ed by Tomi: > > > > > > https://www.spinics.net/lists/dri-devel/msg171918.html > > > > > > and already merged by you (commit 7378f1149884 "media: omap2: > > > omapfb: allow building it with COMPILE_TEST").. > > > > I "ressurected" this patch due to patch 6/7. > > > > The problem with the solution already acked/merged is that > > it works *only* if you don't try to build for ARM. > > > > At the moment you want to build a FB_OMAP2-dependent driver > > on ARM with allyesc onfig, DRM_OMAP will be true, and FB_OMAP2 > > will be disabled: > > > > menuconfig FB_OMAP2 > > tristate "OMAP2+ frame buffer support" > > depends on FB > > depends on DRM_OMAP = n > > > > One solution might be to change the depends on to: > > depends on (DRM_OMAP = n || COMPILE_TEST) > > > > But someone pointed me that the above check was added to avoid building > > duplicated symbols. So, the above would cause build failures. > > > > So, in order to build for ARM with DRM_OMAP selected (allyesconfig, > > allmodconfig), we have the following alternatives: > > > > 1) apply patch 5/7; > > 2) make sure that FB_OMAP2 and DRM_OMAP won't declare the > > same non-static symbols; > > 3) redesign FB_OMAP2 to work with DRM_OMAP built. > > > > I suspect that (1) is easier. > > I agree. > > You can merge this patch through your tree with: > > Acked-by: Bartlomiej Zolnierkiewicz Thanks, I'll merge it. It would still be really cool if Tony or someone else could find a better way for omap3isp driver to not depend on it. Regards, Maur Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Fri, 4 May 2018 10:52:39 -0300 Message-ID: <20180504105227.70c756c8@vento.lan> References: <2542100.cElVns0SR0@amdc3058> <20180423105557.267c5ecf@vento.lan> <52576986.R85hrt8lfa@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id E89156E8A5 for ; Fri, 4 May 2018 13:52:46 +0000 (UTC) In-Reply-To: <52576986.R85hrt8lfa@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org RW0gV2VkLCAyNSBBcHIgMjAxOCAxMjo0NzozNCArMDIwMApCYXJ0bG9taWVqIFpvbG5pZXJraWV3 aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+IGVzY3JldmV1OgoKPiBPbiBNb25kYXksIEFw cmlsIDIzLCAyMDE4IDEwOjU1OjU3IEFNIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZToKPiA+ IEVtIE1vbiwgMjMgQXByIDIwMTggMTQ6NDc6MjggKzAyMDAKPiA+IEJhcnRsb21pZWogWm9sbmll cmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4gZXNjcmV2ZXU6Cj4gPiAgIAo+ID4g PiBPbiBGcmlkYXksIEFwcmlsIDIwLCAyMDE4IDAxOjQyOjUxIFBNIE1hdXJvIENhcnZhbGhvIENo ZWhhYiB3cm90ZTogIAo+ID4gPiA+IEFkZCBzdHVicyBmb3Igb21hcGZiX2Rzcy5oLCBpbiB0aGUg Y2FzZSBpdCBpcyBpbmNsdWRlZCBieQo+ID4gPiA+IHNvbWUgZHJpdmVyIHdoZW4gQ09ORklHX0ZC X09NQVAyIGlzIG5vdCBkZWZpbmVkLCB3aXRoIGNhbgo+ID4gPiA+IGhhcHBlbiBvbiBBUk0gd2hl biBEUk1fT01BUCBpcyBub3QgJ24nLgo+ID4gPiA+IAo+ID4gPiA+IFRoYXQgYWxsb3dzIGJ1aWxk aW5nIHN1Y2ggZHJpdmVyKHMpIHdpdGggQ09NUElMRV9URVNULgo+ID4gPiA+IAo+ID4gPiA+IFNp Z25lZC1vZmYtYnk6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhhYkBzLW9wZW5zb3VyY2Uu Y29tPiAgICAKPiA+ID4gCj4gPiA+IFRoaXMgcGF0Y2ggc2hvdWxkIGJlIGRyb3BwZWQgKHRvZ2V0 aGVyIHdpdGggcGF0Y2ggIzYvNykgYXMgaXQgd2FzCj4gPiA+IHN1cGVyc2VkZWQgYnkgYSBiZXR0 ZXIgc29sdXRpb24gc3VnZ2VzdGVkIGJ5IExhdXJlbnQ6Cj4gPiA+IAo+ID4gPiBodHRwczovL3Bh dGNod29yay5rZXJuZWwub3JnL3BhdGNoLzEwMzI1MTkzLwo+ID4gPiAKPiA+ID4gQUNLLWVkIGJ5 IFRvbWk6Cj4gPiA+IAo+ID4gPiBodHRwczovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9kcmktZGV2 ZWwvbXNnMTcxOTE4Lmh0bWwKPiA+ID4gCj4gPiA+IGFuZCBhbHJlYWR5IG1lcmdlZCBieSB5b3Ug KGNvbW1pdCA3Mzc4ZjExNDk4ODQgIm1lZGlhOiBvbWFwMjoKPiA+ID4gb21hcGZiOiBhbGxvdyBi dWlsZGluZyBpdCB3aXRoIENPTVBJTEVfVEVTVCIpLi4gIAo+ID4gCj4gPiBJICJyZXNzdXJlY3Rl ZCIgdGhpcyBwYXRjaCBkdWUgdG8gcGF0Y2ggNi83Lgo+ID4gCj4gPiBUaGUgcHJvYmxlbSB3aXRo IHRoZSBzb2x1dGlvbiBhbHJlYWR5IGFja2VkL21lcmdlZCBpcyB0aGF0Cj4gPiBpdCB3b3JrcyAq b25seSogaWYgeW91IGRvbid0IHRyeSB0byBidWlsZCBmb3IgQVJNLgo+ID4gCj4gPiBBdCB0aGUg bW9tZW50IHlvdSB3YW50IHRvIGJ1aWxkIGEgRkJfT01BUDItZGVwZW5kZW50IGRyaXZlcgo+ID4g b24gQVJNIHdpdGggYWxseWVzYyBvbmZpZywgRFJNX09NQVAgd2lsbCBiZSB0cnVlLCBhbmQgRkJf T01BUDIKPiA+IHdpbGwgYmUgZGlzYWJsZWQ6Cj4gPiAKPiA+IAltZW51Y29uZmlnIEZCX09NQVAy Cj4gPiAgICAgICAgIAl0cmlzdGF0ZSAiT01BUDIrIGZyYW1lIGJ1ZmZlciBzdXBwb3J0Igo+ID4g CSAgICAgICAgZGVwZW5kcyBvbiBGQgo+ID4gICAgICAgICAJZGVwZW5kcyBvbiBEUk1fT01BUCA9 IG4KPiA+IAo+ID4gT25lIHNvbHV0aW9uIG1pZ2h0IGJlIHRvIGNoYW5nZSB0aGUgZGVwZW5kcyBv biB0bzoKPiA+ICAgICAgICAgCWRlcGVuZHMgb24gKERSTV9PTUFQID0gbiB8fCBDT01QSUxFX1RF U1QpCj4gPiAKPiA+IEJ1dCBzb21lb25lIHBvaW50ZWQgbWUgdGhhdCB0aGUgYWJvdmUgY2hlY2sg d2FzIGFkZGVkIHRvIGF2b2lkIGJ1aWxkaW5nCj4gPiBkdXBsaWNhdGVkIHN5bWJvbHMuIFNvLCB0 aGUgYWJvdmUgd291bGQgY2F1c2UgYnVpbGQgZmFpbHVyZXMuCj4gPiAKPiA+IFNvLCBpbiBvcmRl ciB0byBidWlsZCBmb3IgQVJNIHdpdGggRFJNX09NQVAgc2VsZWN0ZWQgKGFsbHllc2NvbmZpZywK PiA+IGFsbG1vZGNvbmZpZyksIHdlIGhhdmUgdGhlIGZvbGxvd2luZyBhbHRlcm5hdGl2ZXM6Cj4g PiAKPiA+IAkxKSBhcHBseSBwYXRjaCA1Lzc7Cj4gPiAJMikgbWFrZSBzdXJlIHRoYXQgRkJfT01B UDIgYW5kIERSTV9PTUFQIHdvbid0IGRlY2xhcmUgdGhlCj4gPiAJICAgc2FtZSBub24tc3RhdGlj IHN5bWJvbHM7Cj4gPiAJMykgcmVkZXNpZ24gRkJfT01BUDIgdG8gd29yayB3aXRoIERSTV9PTUFQ IGJ1aWx0Lgo+ID4gCj4gPiBJIHN1c3BlY3QgdGhhdCAoMSkgaXMgZWFzaWVyLiAgCj4gCj4gSSBh Z3JlZS4KPiAKPiBZb3UgY2FuIG1lcmdlIHRoaXMgcGF0Y2ggdGhyb3VnaCB5b3VyIHRyZWUgd2l0 aDoKPiAKPiBBY2tlZC1ieTogQmFydGxvbWllaiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVya2ll QHNhbXN1bmcuY29tPgoKVGhhbmtzLCBJJ2xsIG1lcmdlIGl0LiBJdCB3b3VsZCBzdGlsbCBiZSBy ZWFsbHkgY29vbCBpZiBUb255Cm9yIHNvbWVvbmUgZWxzZSBjb3VsZCBmaW5kIGEgYmV0dGVyIHdh eSBmb3Igb21hcDNpc3AgZHJpdmVyIHRvCm5vdCBkZXBlbmQgb24gaXQuCgpSZWdhcmRzLApNYXVy CgpUaGFua3MsCk1hdXJvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:44372 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbeEDNwp (ORCPT ); Fri, 4 May 2018 09:52:45 -0400 Date: Fri, 4 May 2018 10:52:39 -0300 From: Mauro Carvalho Chehab To: Bartlomiej Zolnierkiewicz Cc: Linux Media Mailing List , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Laurent Pinchart , Tomi Valkeinen Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-ID: <20180504105227.70c756c8@vento.lan> In-Reply-To: <52576986.R85hrt8lfa@amdc3058> References: <2542100.cElVns0SR0@amdc3058> <20180423105557.267c5ecf@vento.lan> <52576986.R85hrt8lfa@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Wed, 25 Apr 2018 12:47:34 +0200 Bartlomiej Zolnierkiewicz escreveu: > On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 14:47:28 +0200 > > Bartlomiej Zolnierkiewicz escreveu: > > > > > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > > > Add stubs for omapfb_dss.h, in the case it is included by > > > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > > > happen on ARM when DRM_OMAP is not 'n'. > > > > > > > > That allows building such driver(s) with COMPILE_TEST. > > > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > This patch should be dropped (together with patch #6/7) as it was > > > superseded by a better solution suggested by Laurent: > > > > > > https://patchwork.kernel.org/patch/10325193/ > > > > > > ACK-ed by Tomi: > > > > > > https://www.spinics.net/lists/dri-devel/msg171918.html > > > > > > and already merged by you (commit 7378f1149884 "media: omap2: > > > omapfb: allow building it with COMPILE_TEST").. > > > > I "ressurected" this patch due to patch 6/7. > > > > The problem with the solution already acked/merged is that > > it works *only* if you don't try to build for ARM. > > > > At the moment you want to build a FB_OMAP2-dependent driver > > on ARM with allyesc onfig, DRM_OMAP will be true, and FB_OMAP2 > > will be disabled: > > > > menuconfig FB_OMAP2 > > tristate "OMAP2+ frame buffer support" > > depends on FB > > depends on DRM_OMAP = n > > > > One solution might be to change the depends on to: > > depends on (DRM_OMAP = n || COMPILE_TEST) > > > > But someone pointed me that the above check was added to avoid building > > duplicated symbols. So, the above would cause build failures. > > > > So, in order to build for ARM with DRM_OMAP selected (allyesconfig, > > allmodconfig), we have the following alternatives: > > > > 1) apply patch 5/7; > > 2) make sure that FB_OMAP2 and DRM_OMAP won't declare the > > same non-static symbols; > > 3) redesign FB_OMAP2 to work with DRM_OMAP built. > > > > I suspect that (1) is easier. > > I agree. > > You can merge this patch through your tree with: > > Acked-by: Bartlomiej Zolnierkiewicz Thanks, I'll merge it. It would still be really cool if Tony or someone else could find a better way for omap3isp driver to not depend on it. Regards, Maur Thanks, Mauro