Re: [PATCH] media: vsp1: cleanup a false positive warning

[Mauro Carvalho Chehab <mchehab+samsung@kernel.org>]

Em Fri, 4 May 2018 16:37:23 +0200
Geert Uytterhoeven <geert@linux-m68k.org> escreveu:

> Hi Mauro,
> 
> On Fri, May 4, 2018 at 2:13 PM, Mauro Carvalho Chehab
> <mchehab+samsung@kernel.org> wrote:
> > With the new vsp1 code changes introduced by changeset
> > f81f9adc4ee1 ("media: v4l: vsp1: Assign BRU and BRS to pipelines dynamically"),
> > smatch complains with:
> >         drivers/media/platform/vsp1/vsp1_drm.c:262 vsp1_du_pipeline_setup_bru() error: we previously assumed 'pipe->bru' could be null (see line 180)
> >
> > This is a false positive, as, if pipe->bru is NULL, the brx
> > var will be different, with ends by calling a code that will
> > set pipe->bru to another value.
> >
> > Yet, cleaning this false positive is as easy as adding an explicit
> > check if pipe->bru is NULL.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>  
> 
> Thanks for your patch!
> 
> s/bru/brx/

Hah, yeah... there was a rename from bru->brx... 
I guess that confused me, as I saw this error before the renaming patch
(even though I wrote it to be applied after them) :-)

> 
> > --- a/drivers/media/platform/vsp1/vsp1_drm.c
> > +++ b/drivers/media/platform/vsp1/vsp1_drm.c
> > @@ -185,7 +185,7 @@ static int vsp1_du_pipeline_setup_brx(struct vsp1_device *vsp1,
> >                 brx = &vsp1->brs->entity;
> >
> >         /* Switch BRx if needed. */
> > -       if (brx != pipe->brx) {
> > +       if (brx != pipe->brx || !pipe->brx) {
> >                 struct vsp1_entity *released_brx = NULL;
> >
> >                 /* Release our BRx if we have one. */  
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 



Thanks,
Mauro