From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42 Date: Fri, 4 May 2018 22:00:01 +0100 Message-ID: <20180504210001.GB30250@redhat.com> References: <20180504160026.14017-1-berrange@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fEhoK-0007r5-8d for xen-devel@lists.xenproject.org; Fri, 04 May 2018 21:00:12 +0000 Content-Disposition: inline In-Reply-To: <20180504160026.14017-1-berrange@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Cc: Peter Maydell , Thomas Huth , Michael Roth , Stefan Berger , Olaf Hering , Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini , Eric Blake List-Id: xen-devel@lists.xenproject.org Q0MnaW5nIHhlbi1kZXZlbCBpbiBjYXNlIFhlbiBtYWludGFpbmVycyBoYXZlIGEgbmVlZCBmb3Ig c29tZXRoaW5nIHRoYXQKd2lsbCB0aGF0IGNvbmZsaWN0IHdpdGggdGhpcyBwcm9wb3NhbCB3cnQg c3VwcG9ydGVkIGJ1aWxkIHBsYXRmb3Jtcy4KCk9uIEZyaSwgTWF5IDA0LCAyMDE4IGF0IDA1OjAw OjIzUE0gKzAxMDAsIERhbmllbCBQLiBCZXJyYW5nw6kgd3JvdGU6Cj4gVGhpcyBzaG9ydCBzZXJp ZXMgaXMgYSBmb2xsb3d1cCB0aGUgZGlzY3Vzc2lvbnMgYXJvdW5kIG1pbiBnbGliIHZlcnNpb24K PiB3aGVuIE9sYWYgZm91bmQgd2UgaGFkIGFjY2lkZW50YWxseSBpbmNyZWFzZWQgdGhlIG1pbiBn bGliIGJ5IHVzaW5nIGEKPiBuZXdlciBmdW5jdGlvbjoKPiAKPiAgIGh0dHBzOi8vbGlzdHMuZ251 Lm9yZy9hcmNoaXZlL2h0bWwvcWVtdS1kZXZlbC8yMDE4LTA0L21zZzAyNjk5Lmh0bWwKPiAKPiBT b21lIGtleSBwb2ludHMgZnJvbSB0aGF0IHRocmVhZAo+IAo+ICAgLSBBbHRob3VnaCB3ZSBoYXZl IGEgZG9ja2VyIGpvYiB0aGF0IHRyaWVzIHRvIHRlc3QgdGhlIG1pbiBnbGliCj4gICAgIHZlcnNp b24gaXMgYWRoZXJlZCB0bywgdGhhdCdzIG9ubHkgcnVuIHBvc3QtYnVpbGQsIG5vdCBieSBQZXRl cidzCj4gICAgIG1lcmdlIHRlc3RzLCBub3IgYnkgcGF0Y2hldy4KPiAKPiAgIC0gVGhlIGRvY2tl ciBtaW4gZ2xpYiB0ZXN0IGZhaWxlZCB0byBkZXRlY3QgdGhlIHByb2JsZW0gYW55d2F5Cj4gICAg IGJlY2F1c2UgUkhFTCBoYWQgYmFja3BvcnRlZCB0aGUgc3ltYm9sIGluIHF1ZXN0aW9uLgo+IAo+ ICAgLSBUaGUgZG9ja2VyIG1pbiBnbGliIHRlc3Qgb25seSBidWlsZHMgd2l0aCBjZXJ0YWluIGNv bmZpZ3VyZQo+ICAgICBvcHRpb25zIHNvIGlzbid0IGZvb2xwcm9vZi4KPiAKPiAgIC0gVGhlIG1v ZGVybiBkaXN0cm9zIHdlIGltcGxpY2l0bHkgY2FyZSBhYm91dCBoYXZlIHdheSBuZXdlciBnbGli Cj4gICAgIHRoYW4gMi4yMgo+IAo+ICAgLSBQZXRlcidzIE9TLVggYnVpbGQgaG9zdCBwcmV2aW91 c2x5IGhhZCAyLjIyLCBidXQgYWZ0ZXIgc3dpdGNoaW5nCj4gICAgIGZyb20gZmluayB0byBob21l YnJldyBub3cgaGFzIDIuNTYKPiAKPiAgIC0gSSBzdWdnZXN0ZWQgZm9sbG93aW5nIGxpYnZpcnQn cyBsZWFkIGluIHdyaXRpbmcgYSBwb2xpY3kgZm9yIGhvdwo+ICAgICB3ZSBwaWNrIHN1cHBvcnRl ZCBPUyB0YXJnZXRzIHRvIGluZm9ybSBtYWludGFpbmVycyB3aGVuIG1pbiB2ZXJzaW9ucwo+ICAg ICBjYW4gYmUgaW5jcmVhc2VkLgo+IAo+IFRoaXMgc2VyaWVzIHdyaXRlcyBzdWNoIGEgZG9jdW1l bnQgbGFyZ2VseSBiYXNlZCBvbiBvbmUgSSB3cm90ZSBmb3IKPiBsaWJ2aXJ0IHdpdGggYSBmZXcg Y2hhbmdlcywgbGFyZ2VseSBhcm91bmQgT1MtWCBhbmQgKkJTRC4gTm90ZSBpdAo+IGlzIG5vdCBt ZWFudCB0byBiZSBhbiBleGhhdXN0aXZlIGxpc3Qgb2YgZGlzdHJvcyB3ZSdsbCBidWlsZCBvbiwg cmF0aGVyCj4gYSByZXByZXNlbnRhdGl2ZSBzZWxlY3Rpb24sIHNvIHRoYXQgd2UgY2FuIGlkZW50 aWZ5IHRoZSByYW5nZSBvZiAzcmQKPiBwYXJ0eSBsaWJyYXJ5IHZlcnNpb25zIHdlIG5lZWQgdG8g Y2FyZSBhYm91dC4gU28gaWYgeW91ciBmYXZvdXJpdGUKPiBkaXN0cm8gaXMgbWlzc2luZywgZG9u dCBiZSBhbGFybWVkLCBhcyBpdCBwcm9iYWJseSBzaGlwcyBzaW1pbGFyCj4gdmludGFnZSBzb2Z0 d2FyZSB0byBvbmUgb2YgdGhvc2UgbGlzdGVkIC0gaWYgbm90IGZlZWwgZnJlZSB0byBzdWdnZXN0 Cj4gYWRkaXRpb25zLgo+IAo+IEJhc2VkIG9uIHRoYXQgZG9jIGFuZCBodHRwczovL3JlcG9sb2d5 Lm9yZy9tZXRhcGFja2FnZS9nbGliL3ZlcnNpb25zLAo+IEkgaWRlbnRpZmllZCB0aGF0IHdlIGNv dWxkIGZlYXNpYmx5IHNldCBtaW4gZ2xpYiB0byAyLjQyLiBOb3RlIHRoYXQKPiB0aGlzIHdvdWxk IGJlIGRyb3BwaW5nIFJIRUwtNiBhcyBhIGJ1aWxkIGhvc3QgKFJIRUwtNi4wIGNhbWUgb3V0IGlu Cj4gMjAxMCBzbyB0aGF0J3MgcmVhc29uYWJsZSB0byBkcm9wIElNSE8pLiBJdCB3b3VsZCBzdGls bCBjb3ZlciAyIG1ham9yCj4gRGViaWFuIHZlcnNpb25zIGFuZCAyIG1vc3QgcmVjZW50IFVidW50 dSBMVFMgKDE2LjA0LCAxOC4wNCwgYnV0ICpub3QqCj4gMTQuMDQpLiBUaGlzIG1pbiBnbGliIGxl dHMgdXMgcmVtb3ZlIGFsbW9zdCBhbGwgb3VyIGNvbXBhdCBjb2RlLgo+IAo+IE1vc3QgaW50ZXJl c3RpbmdseSwgdGhhbmtzIHRvdGhlIG5ldyBtaW4gdmVyc2lvbiBiZWluZyBncmVhdGVyIHRoYW4K PiAyLjMyLCB3ZSBjYW4gbm93IHVzZSBHTElCX1ZFUlNJT05fTUFYX0FMTE9XRUQgdG8gdmFsaWRh dGUgdGhlIGNvcnJlY3QKPiBBUEkgdXNhZ2UgYWNjb3JkaW5nIHRvIG91ciBtaW4gdmVyc2lvbjoK PiAKPiAgIGh0dHBzOi8vZGV2ZWxvcGVyLmdub21lLm9yZy9nbGliL3N0YWJsZS9nbGliLVZlcnNp b24tSW5mb3JtYXRpb24uaHRtbCNHTElCLVZFUlNJT04tTUFYLUFMTE9XRUQ6Q0FQUwo+IAo+IFRo aXMgbWVhbnMgdGhhdCAqYWxsKiBvdXIgQ0kgam9icyAmIGRldmVsb3BlciBidWlsZHMgd2lsbCBi ZSBlbmZvcmNpbmcKPiB0aGUgbWluIHZlcnNpb24sIHNvIG1lYW5zIHZlcnkgbWFueSBtb3JlIGNv bmRpdGlvbmFsbHkgYnVpbHQgZmVhdHVyZXMKPiB3aWxsIGdldCB0aGVpciBidWlsZCB2YWxpZGF0 ZWQgYWdhaW5zdCBtaW4gZ2xpYiB2ZXJzaW9uLiBUaGlzIHdvdWxkCj4gZG8gYSBtdWNoIGJldHRl ciBqb2Igb2YgY2F0Y2hpbmcgbWlzdGFrZXMgdGhhbiBvdXIgbWluLWdsaWIgZG9ja2VyCj4gam9i LCBtYWtpbmcgdGhhdCBvYnNvbGV0ZS4KPiAKPiBEYW5pZWwgUC4gQmVycmFuZ8OpICgzKToKPiAg IHFlbXUtZG9jOiBwcm92aWRlIGRldGFpbHMgb2Ygc3VwcG9ydGVkIGJ1aWxkIHBsYXRmb3Jtcwo+ ICAgZ2xpYjogYnVtcCBtaW4gcmVxdWlyZWQgZ2xpYiBsaWJyYXJ5IHZlcnNpb24gdG8gMi40Mgo+ ICAgZ2xpYjogZW5mb3JjZSB0aGUgbWluaW11bSByZXF1aXJlZCB2ZXJzaW9uIGFuZCB3YXJuIGFi b3V0IG9sZCBBUElzCj4gCj4gIGNvbmZpZ3VyZSAgICAgICAgICAgICAgIHwgICA2ICstCj4gIGlu Y2x1ZGUvZ2xpYi1jb21wYXQuaCAgIHwgMzYyICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBxZW11LWRvYy50ZXhpICAgICAgICAgICB8ICA2OCArKysr KysrKysKPiAgdGVzdHMvdGVzdC1xbXAtZXZlbnQuYyAgfCAgIDIgKy0KPiAgdGVzdHMvdHBtLWVt dS5oICAgICAgICAgfCAgIDQgKy0KPiAgdGVzdHMvdmhvc3QtdXNlci10ZXN0LmMgfCAgIDQgKy0K PiAgdHJhY2Uvc2ltcGxlLmMgICAgICAgICAgfCAgIDYgKy0KPiAgNyBmaWxlcyBjaGFuZ2VkLCAx MjMgaW5zZXJ0aW9ucygrKSwgMzI5IGRlbGV0aW9ucygtKQo+IAo+IC0tIAo+IDIuMTQuMwo+IAoK UmVnYXJkcywKRGFuaWVsCi0tIAp8OiBodHRwczovL2JlcnJhbmdlLmNvbSAgICAgIC1vLSAgICBo dHRwczovL3d3dy5mbGlja3IuY29tL3Bob3Rvcy9kYmVycmFuZ2UgOnwKfDogaHR0cHM6Ly9saWJ2 aXJ0Lm9yZyAgICAgICAgIC1vLSAgICAgICAgICAgIGh0dHBzOi8vZnN0b3AxMzguYmVycmFuZ2Uu Y29tIDp8Cnw6IGh0dHBzOi8vZW50YW5nbGUtcGhvdG8ub3JnICAgIC1vLSAgICBodHRwczovL3d3 dy5pbnN0YWdyYW0uY29tL2RiZXJyYW5nZSA6fAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEhoM-0006Pv-Op for qemu-devel@nongnu.org; Fri, 04 May 2018 17:00:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEhoJ-0000y2-47 for qemu-devel@nongnu.org; Fri, 04 May 2018 17:00:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60740 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEhoI-0000xg-V8 for qemu-devel@nongnu.org; Fri, 04 May 2018 17:00:11 -0400 Date: Fri, 4 May 2018 22:00:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180504210001.GB30250@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180504160026.14017-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180504160026.14017-1-berrange@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Cc: Peter Maydell , Markus Armbruster , Paolo Bonzini , Thomas Huth , Olaf Hering , Stefan Hajnoczi , Michael Roth , Eric Blake , Stefan Berger CC'ing xen-devel in case Xen maintainers have a need for something that will that conflict with this proposal wrt supported build platforms. On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrang=C3=A9 wrote: > This short series is a followup the discussions around min glib version > when Olaf found we had accidentally increased the min glib by using a > newer function: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg02699.html >=20 > Some key points from that thread >=20 > - Although we have a docker job that tries to test the min glib > version is adhered to, that's only run post-build, not by Peter's > merge tests, nor by patchew. >=20 > - The docker min glib test failed to detect the problem anyway > because RHEL had backported the symbol in question. >=20 > - The docker min glib test only builds with certain configure > options so isn't foolproof. >=20 > - The modern distros we implicitly care about have way newer glib > than 2.22 >=20 > - Peter's OS-X build host previously had 2.22, but after switching > from fink to homebrew now has 2.56 >=20 > - I suggested following libvirt's lead in writing a policy for how > we pick supported OS targets to inform maintainers when min version= s > can be increased. >=20 > This series writes such a document largely based on one I wrote for > libvirt with a few changes, largely around OS-X and *BSD. Note it > is not meant to be an exhaustive list of distros we'll build on, rather > a representative selection, so that we can identify the range of 3rd > party library versions we need to care about. So if your favourite > distro is missing, dont be alarmed, as it probably ships similar > vintage software to one of those listed - if not feel free to suggest > additions. >=20 > Based on that doc and https://repology.org/metapackage/glib/versions, > I identified that we could feasibly set min glib to 2.42. Note that > this would be dropping RHEL-6 as a build host (RHEL-6.0 came out in > 2010 so that's reasonable to drop IMHO). It would still cover 2 major > Debian versions and 2 most recent Ubuntu LTS (16.04, 18.04, but *not* > 14.04). This min glib lets us remove almost all our compat code. >=20 > Most interestingly, thanks tothe new min version being greater than > 2.32, we can now use GLIB_VERSION_MAX_ALLOWED to validate the correct > API usage according to our min version: >=20 > https://developer.gnome.org/glib/stable/glib-Version-Information.html= #GLIB-VERSION-MAX-ALLOWED:CAPS >=20 > This means that *all* our CI jobs & developer builds will be enforcing > the min version, so means very many more conditionally built features > will get their build validated against min glib version. This would > do a much better job of catching mistakes than our min-glib docker > job, making that obsolete. >=20 > Daniel P. Berrang=C3=A9 (3): > qemu-doc: provide details of supported build platforms > glib: bump min required glib library version to 2.42 > glib: enforce the minimum required version and warn about old APIs >=20 > configure | 6 +- > include/glib-compat.h | 362 ++++++----------------------------------= -------- > qemu-doc.texi | 68 +++++++++ > tests/test-qmp-event.c | 2 +- > tests/tpm-emu.h | 4 +- > tests/vhost-user-test.c | 4 +- > trace/simple.c | 6 +- > 7 files changed, 123 insertions(+), 329 deletions(-) >=20 > --=20 > 2.14.3 >=20 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|