From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls Date: Sat, 5 May 2018 08:51:43 +0200 Message-ID: <20180505085056.6c6011ca@scratchpost.org> References: <20180502210800.1971-1-dannym@scratchpost.org> <20180502210800.1971-4-dannym@scratchpost.org> <20180503144618.oojhvmey44dtg5fa@flea> Reply-To: dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0"; protocol="application/pgp-signature" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20180503144618.oojhvmey44dtg5fa@flea> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Andrea Bondavalli , Fabio Estevam , Icenowy Zheng , Philipp Zabel , Kuninori Morimoto , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: alsa-devel@alsa-project.org --Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0 Content-Type: text/plain; charset="UTF-8" Hi Maxime, On Thu, 3 May 2018 16:46:19 +0200 Maxime Ripard wrote: > Doesn't that mean that the controls will be shared between the right > and left mixers now, which wasn't the case before? Yes. However Chen-Yu said that except for debugfs that cannot be observed by user space anyway. It's nice to have the NEW controls have multiple channels, which is what this does. >And also, wouldn't > the controls be called "Left Mixer Left Mixer Left DAC Playback > Switch" (for the first one) now? No. I checked using "amixer" - the names look fine, "Left Mixer Left DAC Playback Switch". With the patch series, amixer says: numid=10,iface=MIXER,name='FM Playback Switch' numid=6,iface=MIXER,name='FM Playback Volume' numid=5,iface=MIXER,name='Line Boost Volume' numid=9,iface=MIXER,name='Line Playback Switch' numid=4,iface=MIXER,name='Line Playback Volume' numid=1,iface=MIXER,name='Mic1 Boost Volume' numid=11,iface=MIXER,name='Mic1 Playback Switch' numid=2,iface=MIXER,name='Mic2 Boost Volume' numid=12,iface=MIXER,name='Mic2 Playback Switch' numid=7,iface=MIXER,name='Mic Playback Volume' numid=18,iface=MIXER,name='Capture Source' numid=19,iface=MIXER,name='Differential Line Source' numid=8,iface=MIXER,name='Left Mixer Left DAC Playback Switch' numid=15,iface=MIXER,name='Power Amplifier DAC Playback Switch' numid=16,iface=MIXER,name='Power Amplifier Mixer Playback Switch' numid=17,iface=MIXER,name='Power Amplifier Mute Switch' numid=3,iface=MIXER,name='Power Amplifier Volume' numid=14,iface=MIXER,name='Right Mixer Left DAC Playback Switch' numid=13,iface=MIXER,name='Right Mixer Right DAC Playback Switch' --Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: dannym@scratchpost.org (Danny Milosavljevic) Date: Sat, 5 May 2018 08:51:43 +0200 Subject: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls In-Reply-To: <20180503144618.oojhvmey44dtg5fa@flea> References: <20180502210800.1971-1-dannym@scratchpost.org> <20180502210800.1971-4-dannym@scratchpost.org> <20180503144618.oojhvmey44dtg5fa@flea> Message-ID: <20180505085056.6c6011ca@scratchpost.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maxime, On Thu, 3 May 2018 16:46:19 +0200 Maxime Ripard wrote: > Doesn't that mean that the controls will be shared between the right > and left mixers now, which wasn't the case before? Yes. However Chen-Yu said that except for debugfs that cannot be observed by user space anyway. It's nice to have the NEW controls have multiple channels, which is what this does. >And also, wouldn't > the controls be called "Left Mixer Left Mixer Left DAC Playback > Switch" (for the first one) now? No. I checked using "amixer" - the names look fine, "Left Mixer Left DAC Playback Switch". With the patch series, amixer says: numid=10,iface=MIXER,name='FM Playback Switch' numid=6,iface=MIXER,name='FM Playback Volume' numid=5,iface=MIXER,name='Line Boost Volume' numid=9,iface=MIXER,name='Line Playback Switch' numid=4,iface=MIXER,name='Line Playback Volume' numid=1,iface=MIXER,name='Mic1 Boost Volume' numid=11,iface=MIXER,name='Mic1 Playback Switch' numid=2,iface=MIXER,name='Mic2 Boost Volume' numid=12,iface=MIXER,name='Mic2 Playback Switch' numid=7,iface=MIXER,name='Mic Playback Volume' numid=18,iface=MIXER,name='Capture Source' numid=19,iface=MIXER,name='Differential Line Source' numid=8,iface=MIXER,name='Left Mixer Left DAC Playback Switch' numid=15,iface=MIXER,name='Power Amplifier DAC Playback Switch' numid=16,iface=MIXER,name='Power Amplifier Mixer Playback Switch' numid=17,iface=MIXER,name='Power Amplifier Mute Switch' numid=3,iface=MIXER,name='Power Amplifier Volume' numid=14,iface=MIXER,name='Right Mixer Left DAC Playback Switch' numid=13,iface=MIXER,name='Right Mixer Right DAC Playback Switch' -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751206AbeEEGvy (ORCPT ); Sat, 5 May 2018 02:51:54 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:50438 "EHLO dd26836.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbeEEGvx (ORCPT ); Sat, 5 May 2018 02:51:53 -0400 Date: Sat, 5 May 2018 08:51:43 +0200 From: Danny Milosavljevic To: Maxime Ripard Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Andrea Bondavalli , Fabio Estevam , Icenowy Zheng , Philipp Zabel , Kuninori Morimoto , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls Message-ID: <20180505085056.6c6011ca@scratchpost.org> In-Reply-To: <20180503144618.oojhvmey44dtg5fa@flea> References: <20180502210800.1971-1-dannym@scratchpost.org> <20180502210800.1971-4-dannym@scratchpost.org> <20180503144618.oojhvmey44dtg5fa@flea> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Maxime, On Thu, 3 May 2018 16:46:19 +0200 Maxime Ripard wrote: > Doesn't that mean that the controls will be shared between the right > and left mixers now, which wasn't the case before? Yes. However Chen-Yu said that except for debugfs that cannot be observed by user space anyway. It's nice to have the NEW controls have multiple channels, which is what this does. >And also, wouldn't > the controls be called "Left Mixer Left Mixer Left DAC Playback > Switch" (for the first one) now? No. I checked using "amixer" - the names look fine, "Left Mixer Left DAC Playback Switch". With the patch series, amixer says: numid=3D10,iface=3DMIXER,name=3D'FM Playback Switch' numid=3D6,iface=3DMIXER,name=3D'FM Playback Volume' numid=3D5,iface=3DMIXER,name=3D'Line Boost Volume' numid=3D9,iface=3DMIXER,name=3D'Line Playback Switch' numid=3D4,iface=3DMIXER,name=3D'Line Playback Volume' numid=3D1,iface=3DMIXER,name=3D'Mic1 Boost Volume' numid=3D11,iface=3DMIXER,name=3D'Mic1 Playback Switch' numid=3D2,iface=3DMIXER,name=3D'Mic2 Boost Volume' numid=3D12,iface=3DMIXER,name=3D'Mic2 Playback Switch' numid=3D7,iface=3DMIXER,name=3D'Mic Playback Volume' numid=3D18,iface=3DMIXER,name=3D'Capture Source' numid=3D19,iface=3DMIXER,name=3D'Differential Line Source' numid=3D8,iface=3DMIXER,name=3D'Left Mixer Left DAC Playback Switch' numid=3D15,iface=3DMIXER,name=3D'Power Amplifier DAC Playback Switch' numid=3D16,iface=3DMIXER,name=3D'Power Amplifier Mixer Playback Switch' numid=3D17,iface=3DMIXER,name=3D'Power Amplifier Mute Switch' numid=3D3,iface=3DMIXER,name=3D'Power Amplifier Volume' numid=3D14,iface=3DMIXER,name=3D'Right Mixer Left DAC Playback Switch' numid=3D13,iface=3DMIXER,name=3D'Right Mixer Right DAC Playback Switch' --Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlrtVH8ACgkQ5xo1VCww uqWwlggAgfHEgljWfgiB2oJ5uYkyydqdJvrws9QwwzJV9d8I8gN0HD6W82Ok+0hr Q6JewwOxjBsBZwyBM0uT1k3QJoQhBU0DDkTjAkP6H5ycTKofCUkplCUVhndnEBnF XFab4ZlnpcAxtIFAQ62ALOSx8wkXojVNvamay+YfXc8iFas/XOMVwWFX2SFBZVUa b79DCj4mKhvRXbWqvqOFZ1EelrLeFhNlEDcRb9kmcWDb1TDk1ZDaoK9SmDiM+ho/ PzoREKY8mrfho8iPHtW4i3VqyCn8gOXpA/qu/CdAUQ8vi8cfqgI2m//hTSO1HoyX JDn5+cNaTIlMBiTuxya4Zjdc2wDg0A== =bxuI -----END PGP SIGNATURE----- --Sig_/Vzt_SN1Zr8bWNbQ9ZXq_W+0--