From: Danny Milosavljevic <dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
To: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Andrea Bondavalli
<andrea.bondavalli74-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v14 8/8] ASoC: sun4i-codec: Add Left Capture Select, Right Capture Select
Date: Sat, 5 May 2018 12:40:50 +0200 [thread overview]
Message-ID: <20180505124050.66f74999@scratchpost.org> (raw)
In-Reply-To: <20180503145408.yymk2ndt4sm2yt4i@flea>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
Hi Maxime,
On Thu, 3 May 2018 16:54:08 +0200
Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> wrote:
> > +static const char * const sun4i_codec_capture_source[] = {
> > + "Line",
> > + "FM",
> > + "Mic1",
> > + "Mic2",
> > + "Mic1,Mic2",
> > + "Mic1+Mic2",
> > + "Output Mixer",
> > + "Line,Mic1",
> > +};
>
> Shouldn't that be defined in a more generic way? As far as I know,
> there's no way to tell what the difference between "Mic1,Mic2" and
> "Mic1+Mic2" would be from the userspace.
Sounds good - but how?
Here, "Mic1,Mic2" means the left channel captured is Mic1 and the right
channel captured is Mic2.
On the other hand, "Mic1+Mic2" means that the signals from Mic1 and
Mic2 are added together and that is captured (both as left and as right).
"Mic1" means both the left channel and the right channel captured is
from Mic1. Likewise "Mic2".
WARNING: multiple messages have this Message-ID (diff)
From: dannym@scratchpost.org (Danny Milosavljevic)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 8/8] ASoC: sun4i-codec: Add Left Capture Select, Right Capture Select
Date: Sat, 5 May 2018 12:40:50 +0200 [thread overview]
Message-ID: <20180505124050.66f74999@scratchpost.org> (raw)
In-Reply-To: <20180503145408.yymk2ndt4sm2yt4i@flea>
Hi Maxime,
On Thu, 3 May 2018 16:54:08 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > +static const char * const sun4i_codec_capture_source[] = {
> > + "Line",
> > + "FM",
> > + "Mic1",
> > + "Mic2",
> > + "Mic1,Mic2",
> > + "Mic1+Mic2",
> > + "Output Mixer",
> > + "Line,Mic1",
> > +};
>
> Shouldn't that be defined in a more generic way? As far as I know,
> there's no way to tell what the difference between "Mic1,Mic2" and
> "Mic1+Mic2" would be from the userspace.
Sounds good - but how?
Here, "Mic1,Mic2" means the left channel captured is Mic1 and the right
channel captured is Mic2.
On the other hand, "Mic1+Mic2" means that the signals from Mic1 and
Mic2 are added together and that is captured (both as left and as right).
"Mic1" means both the left channel and the right channel captured is
from Mic1. Likewise "Mic2".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180505/01a96e0c/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Chen-Yu Tsai <wens@csie.org>,
Andrea Bondavalli <andrea.bondavalli74@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Icenowy Zheng <icenowy@aosc.xyz>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v14 8/8] ASoC: sun4i-codec: Add Left Capture Select, Right Capture Select
Date: Sat, 5 May 2018 12:40:50 +0200 [thread overview]
Message-ID: <20180505124050.66f74999@scratchpost.org> (raw)
In-Reply-To: <20180503145408.yymk2ndt4sm2yt4i@flea>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
Hi Maxime,
On Thu, 3 May 2018 16:54:08 +0200
Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > +static const char * const sun4i_codec_capture_source[] = {
> > + "Line",
> > + "FM",
> > + "Mic1",
> > + "Mic2",
> > + "Mic1,Mic2",
> > + "Mic1+Mic2",
> > + "Output Mixer",
> > + "Line,Mic1",
> > +};
>
> Shouldn't that be defined in a more generic way? As far as I know,
> there's no way to tell what the difference between "Mic1,Mic2" and
> "Mic1+Mic2" would be from the userspace.
Sounds good - but how?
Here, "Mic1,Mic2" means the left channel captured is Mic1 and the right
channel captured is Mic2.
On the other hand, "Mic1+Mic2" means that the signals from Mic1 and
Mic2 are added together and that is captured (both as left and as right).
"Mic1" means both the left channel and the right channel captured is
from Mic1. Likewise "Mic2".
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-05 10:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 21:07 [PATCH v14 0/8] ASoC: sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
[not found] ` <20180502210800.1971-1-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-02 21:07 ` [PATCH v14 1/8] ASoC: sun4i-codec: Add MIC2 Pre-Amplifier, Mic2, Mic Playback Volume Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
[not found] ` <20180502210800.1971-2-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-03 14:30 ` Maxime Ripard
2018-05-03 14:30 ` Maxime Ripard
2018-05-03 14:30 ` Maxime Ripard
2018-05-02 21:07 ` [PATCH v14 2/8] ASoC: sun4i-codec: Add Mic1 Boost Volume, Mic2 Boost Volume Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
[not found] ` <20180502210800.1971-3-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-03 14:33 ` Maxime Ripard
2018-05-03 14:33 ` Maxime Ripard
2018-05-03 14:33 ` Maxime Ripard
2018-05-05 7:05 ` Danny Milosavljevic
2018-05-05 7:05 ` Danny Milosavljevic
2018-05-05 7:05 ` Danny Milosavljevic
[not found] ` <20180505090513.7e3f02c2-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-14 14:05 ` Maxime Ripard
2018-05-14 14:05 ` Maxime Ripard
2018-05-14 14:05 ` Maxime Ripard
2018-05-02 21:07 ` [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
[not found] ` <20180502210800.1971-4-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-03 14:46 ` Maxime Ripard
2018-05-03 14:46 ` Maxime Ripard
2018-05-03 14:46 ` Maxime Ripard
2018-05-05 6:51 ` Danny Milosavljevic
2018-05-05 6:51 ` Danny Milosavljevic
2018-05-05 6:51 ` Danny Milosavljevic
[not found] ` <20180505085056.6c6011ca-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-14 14:06 ` Maxime Ripard
2018-05-14 14:06 ` Maxime Ripard
2018-05-14 14:06 ` Maxime Ripard
2018-05-02 21:07 ` [PATCH v14 4/8] ASoC: sun4i-codec: Add Mic1 Playback Switch, Mic2 Playback Switch Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` [PATCH v14 5/8] ASoC: sun4i-codec: Add FM Playback Volume, FM Left, FM Right, FM " Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` [PATCH v14 6/8] ASoC: sun4i-codec: Add Line Playback Volume, Line Boost Volume, Line Right, Line Left, Line " Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` [PATCH v14 7/8] ASoC: sun4i-codec: Add Differential Line Source Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:07 ` Danny Milosavljevic
2018-05-02 21:08 ` [PATCH v14 8/8] ASoC: sun4i-codec: Add Left Capture Select, Right Capture Select Danny Milosavljevic
2018-05-02 21:08 ` Danny Milosavljevic
2018-05-02 21:08 ` Danny Milosavljevic
[not found] ` <20180502210800.1971-9-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-03 14:54 ` Maxime Ripard
2018-05-03 14:54 ` Maxime Ripard
2018-05-03 14:54 ` Maxime Ripard
2018-05-05 10:40 ` Danny Milosavljevic [this message]
2018-05-05 10:40 ` Danny Milosavljevic
2018-05-05 10:40 ` Danny Milosavljevic
[not found] ` <20180505124050.66f74999-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2018-05-14 14:11 ` Maxime Ripard
2018-05-14 14:11 ` Maxime Ripard
2018-05-14 14:11 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180505124050.66f74999@scratchpost.org \
--to=dannym-bxpqe3t81xxwrsdmlxbzog@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=andrea.bondavalli74-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=icenowy-ymACFijhrKM@public.gmane.org \
--cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.