Re: [v3, 3/5] eventdev: add crypto adapter implementation

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Sun, 6 May 2018 00:17:08 +0530
> From: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
>  akhil.goyal@nxp.com, dev@dpdk.org
> CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com,
>  nikhil.rao@intel.com, gage.eads@intel.com
> Subject: [v3,3/5] eventdev: add crypto adapter implementation
> X-Mailer: git-send-email 1.9.1
> 
> Event crypto adapter is added to the meson build system
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
>  config/common_base                             |    1 +
>  lib/Makefile                                   |    3 +-
>  lib/librte_eventdev/Makefile                   |    3 +
>  lib/librte_eventdev/meson.build                |    8 +-
>  lib/librte_eventdev/rte_event_crypto_adapter.c | 1127 ++++++++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev_version.map   |   12 +
>  6 files changed, 1150 insertions(+), 4 deletions(-)
>  create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.c
> 
> diff --git a/config/common_base b/config/common_base
> index 03a8688..8420d29 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -577,6 +577,7 @@ CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG=n
>  CONFIG_RTE_EVENT_MAX_DEVS=16
>  CONFIG_RTE_EVENT_MAX_QUEUES_PER_DEV=64
>  CONFIG_RTE_EVENT_TIMER_ADAPTER_NUM_MAX=32
> +CONFIG_RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE=32
>  
>  #
>  # Compile PMD for skeleton event device
> diff --git a/lib/Makefile b/lib/Makefile
> index 057bf78..efddee0 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -32,7 +32,8 @@ DEPDIRS-librte_security := librte_eal librte_mempool librte_ring librte_mbuf
>  DEPDIRS-librte_security += librte_ethdev
>  DEPDIRS-librte_security += librte_cryptodev
>  DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += librte_eventdev
> -DEPDIRS-librte_eventdev := librte_eal librte_ring librte_ethdev librte_hash librte_mempool librte_timer
> +DEPDIRS-librte_eventdev := librte_eal librte_ring librte_ether librte_hash \

This creates build break with parallel build due to unwanted rename of
librte_ethdev -> librte_ether


> +                           librte_mempool librte_timer librte_cryptodev
>  SRCS-y += rte_event_ring.c
>  SRCS-y += rte_event_eth_rx_adapter.c
>  SRCS-y += rte_event_timer_adapter.c
> +SRCS-y += rte_event_crypto_adapter.c
>  
>  # export include files
> +/* Macros to check for valid adapter */
> +#define RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) do { \

Internal function(not exposed to public header file), Could be renamed to
EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET

> +
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 3ee28f7..2c674f5 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -97,4 +97,16 @@ EXPERIMENTAL {
>  	rte_event_timer_arm_burst;
>  	rte_event_timer_arm_tmo_tick_burst;
>  	rte_event_timer_cancel_burst;
> +        rte_event_crypto_adapter_create_ext;

extra space.

> +	rte_event_crypto_adapter_create;
> +	rte_event_crypto_adapter_free;
> +	rte_event_crypto_adapter_queue_pair_add;
> +	rte_event_crypto_adapter_queue_pair_del;
> +	rte_event_crypto_adapter_start;
> +	rte_event_crypto_adapter_stop;
> +	rte_event_crypto_adapter_stats_get;
> +	rte_event_crypto_adapter_stats_reset;
> +	rte_event_crypto_adapter_service_id_get;
> +	rte_event_crypto_adapter_event_port_get;

Arrange in alphabetical order.

> +
>  } DPDK_18.05;
> -- 
> 1.9.1
>