From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/4] Makefile: check rootfs overlays with BR2_ROOTFS_MERGED_USR enabled
Date: Mon, 7 May 2018 15:10:02 +0200 [thread overview]
Message-ID: <20180507151002.16e5f66d@windsurf> (raw)
In-Reply-To: <34105483.57140.1525698346092.JavaMail.zimbra@datacom.com.br>
Hello,
On Mon, 7 May 2018 10:05:46 -0300 (BRT), Carlos Santos wrote:
> >> @$(foreach d, $(call qstrip,$(BR2_ROOTFS_OVERLAY)), \
> >> $(call MESSAGE,"Copying overlay $(d)"); \
> >> - rsync -a --ignore-times --keep-dirlinks $(RSYNC_VCS_EXCLUSIONS) \
> >> - --chmod=u=rwX,go=rX --exclude .empty --exclude '*~' \
> >> - $(d)/ $(TARGET_DIR)$(sep))
> >> + $(call SYSTEM_RSYNC,$(d),$(TARGET_DIR))$(sep))
> >
> > This specific chunk is not directly related to checking that overlays
> > comply with the merged /usr rule, so shouldn't this be in a separate
> > commit ?
>
> It removes ?--keep-dirlinks?, so becomes identical to the SYSTEM_RSYNC
> logic, as observed by Peter Korsgaard in a previous message.
Agreed, but I don't see what it has to do with "check rootfs overlays
with BR2_ROOTFS_MERGED_USR enabled".
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-07 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 12:46 [Buildroot] [PATCH v2 0/4] Improve verification of custom rootfs skeletons and overlays Carlos Santos
2018-05-07 12:46 ` [Buildroot] [PATCH v2 1/4] skeleton-custom: use a script to check merged usr structure Carlos Santos
2018-05-07 12:46 ` [Buildroot] [PATCH v2 2/4] skeleton-custom: install /bin, /lib, and /sbin Carlos Santos
2018-05-07 12:46 ` [Buildroot] [PATCH v2 3/4] Makefile: check rootfs overlays with BR2_ROOTFS_MERGED_USR enabled Carlos Santos
2018-05-07 12:54 ` Thomas Petazzoni
2018-05-07 13:05 ` Carlos Santos
2018-05-07 13:10 ` Thomas Petazzoni [this message]
2018-05-07 13:28 ` Carlos Santos
2018-05-07 13:51 ` Thomas Petazzoni
2018-05-07 12:46 ` [Buildroot] [PATCH v2 4/4] system: allow selecting merged /usr along with custom rootfs skeleton Carlos Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507151002.16e5f66d@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.